aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/rpcdump.cpp
Commit message (Collapse)AuthorAgeFilesLines
* really s/Doge/Dis/g this timeTomo Ueda2021-09-021-3/+3
|
* really s/doge/dis/g this timeTomo Ueda2021-09-021-3/+3
|
* Switch `bitcoinprivkey` to `dogecoinprivkey`chromatic2021-04-181-1/+1
|
* Introduce basic Dogecoin brandingRoss Nicoll2019-03-251-5/+5
|
* Return correct error codes in removeprunedfunds().John Newbery2017-06-051-2/+2
| | | | | | | | | | | | | | | | The removeprunedfunds() RPC was returning misleading or incorrect error codes (for example RPC_INTERNAL_ERROR when the transaction was not found in the wallet). This commit fixes those error codes: - RPC_INTERNAL_ERROR should not be returned for application-level errors, only for genuine internal errors such as corrupted data. This error code has been replaced with RPC_WALLET_ERROR. This commit also updates the test cases to explicitly test the error code. Github-Pull: #9853 Rebased-From: 960bc7f778d8dd618e65f1e37ec734e2d4734051
* Fix importwallet edge case rescan bugRussell Yanofsky2017-05-231-6/+3
| | | | | | | | | | | Start importwallet rescans at the first block with timestamp greater or equal to the wallet birthday instead of the last block with timestamp less or equal. This fixes an edge case bug where importwallet could fail to start the rescan early enough if there are blocks with decreasing timestamps or multiple blocks with the same timestamp. Github-Pull: #10410 Rebased-From: 2a8e35a11d4bd4828631654fc7b8b8fe8f0a2460
* Clarify importprivkey help text with example of blank label without rescanWarren Togami2017-04-201-0/+2
| | | | | | | Occasionally I waste a lot of time not remembering that the second parameter to importprivkey must be blank if you intend to stop rescan with "false" as the third parameter. Github-Pull: #10207 Rebased-From: c9e31c36ffacedb85d4d9ce75a92e011a3e7d4b4
* Fix importmulti returning rescan errors for wrong keysRussell Yanofsky2017-02-281-0/+1
| | | | | | | | Bug was a missing ++i line in a new range for loop added in commit e2e2f4c "Return errors from importmulti if complete rescans are not successful" Github-Pull: #9829 Rebased-From: 306bd72157f089b962b9c537bbacf710a4158647
* Return errors from importmulti if complete rescans are not successfulRussell Yanofsky2017-02-221-2/+23
| | | | | Github-Pull: #9773 Rebased-From: e2e2f4c856363bbb0e3b5ba4df225f3754c3db39
* [wallet] Remove importmulti always-true checkRussell Yanofsky2017-02-201-1/+1
| | | | | | | | | | Remove "nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()" check from importmulti, which is always true because nLowestTimestamp is set to the minimum of the most recent block time and all the imported key timestamps, which is necessarily lower than the maximum block time. Github-Pull: #9760 Rebased-From: ec1267f13b7d0b9b5058c6821cf8dbf74e02d17c
* Use 2 hour grace period for key timestamps in importmulti rescansRussell Yanofsky2017-02-161-2/+3
| | | | | | | | Gregory Maxwell <[email protected]> pointed out the lack of grace period in https://github.com/bitcoin/bitcoin/pull/9490#issue-199407998. The importwallet RPC which uses key timestamps in a similar way already has a 2 hour grace period.
* Merge #9756: Return error when importmulti called with invalid address.Wladimir J. van der Laan2017-02-151-0/+3
|\ | | | | | | 9acf25c Return error when importmulti called with invalid address. (Russell Yanofsky)
| * Return error when importmulti called with invalid address.Russell Yanofsky2017-02-131-0/+3
| | | | | | | | Lack of error checking noticed by Alex Morcos <[email protected]>
* | Use importmulti timestamp when importing watch only keysRussell Yanofsky2017-02-101-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | When importing a watch-only address over importmulti with a specific timestamp, the wallet's nTimeFirstKey is currently set to 1. After this change, the provided timestamp will be used and stored as metadata associated with watch-only key. This can improve wallet performance because it can avoid the need to scan the entire blockchain for watch only addresses when timestamps are provided. Also adds timestamp to validateaddress return value (needed for tests). Fixes #9034.
* | Dedup nTimeFirstKey update logicRussell Yanofsky2017-02-101-9/+4
| | | | | | | | | | | | | | Also make nTimeFirstKey member variable private. This is just a cleanup change, it doesn't change behavior in any significant way.
* | Use MTP for importmulti "now" timestampsRussell Yanofsky2017-02-101-1/+1
| |
* | Require timestamps for importmulti keysRussell Yanofsky2017-02-101-6/+29
|/ | | | | | | | | | | | | | | Additionally, accept a "now" timestamp, to allow avoiding rescans for keys which are known never to have been used. Note that the behavior when "now" is specified is slightly different than the previous behavior when no timestamp was specified at all. Previously, when no timestamp was specified, it would avoid rescanning during the importmulti call, but set the key's nCreateTime value to 1, which would not prevent future block reads in later ScanForWalletTransactions calls. With this change, passing a "now" timestamp will set the key's nCreateTime to the current block time instead of 1. Fixes #9491
* Replace FindLatestBefore used by importmuti with FindEarliestAtLeast.Gregory Maxwell2017-01-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | In spite of the name FindLatestBefore used std::lower_bound to try to find the earliest block with a nTime greater or equal to the the requested value. But lower_bound uses bisection and requires the input to be ordered with respect to the comparison operation. Block times are not well ordered. I don't know what lower_bound is permitted to do when the data is not sufficiently ordered, but it's probably not good. (I could construct an implementation which would infinite loop...) To resolve the issue this commit introduces a maximum-so-far to the block indexes and searches that. For clarity the function is renamed to reflect what it actually does. An issue that remains is that there is no grace period in importmulti: If a address is created at time T and a send is immediately broadcast and included by a miner with a slow clock there may not yet have been any block with at least time T. The normal rescan has a grace period of 7200 seconds, but importmulti does not.
* rpc: Argument name consistencyWladimir J. van der Laan2017-01-051-3/+3
| | | | | | | | | The meaning is clear from the context, and we're inconsistent here. Also save typing when using named arguments. - `bitcoinaddress` -> `address` - `bitcoinprivkey` -> `privkey` - `bitcoinpubkey` -> `pubkey`
* rpc: Named arguments for wallet callsWladimir J. van der Laan2017-01-051-4/+4
|
* Increment MIT Licence copyright header year on files modified in 2016isle29832016-12-311-1/+1
| | | | | | Edited via: $ contrib/devtools/copyright_header.py update .
* Make DecodeHexTx return a CMutableTransactionPieter Wuille2016-12-021-2/+2
|
* Make CWalletTx store a CTransactionRef instead of inheritingPieter Wuille2016-12-021-1/+1
|
* Rename the remaining main.{h,cpp} to validation.{h,cpp}Matt Corallo2016-12-021-1/+1
|
* Initialize variable to prevent compiler warningPavel Janík2016-11-101-1/+1
|
* Merge #8981: Wshadow: Do not shadow argument with a local variableWladimir J. van der Laan2016-11-071-2/+2
|\ | | | | | | ff6639b Do not shadow local variable (Pavel Janík)
| * Do not shadow local variablePavel Janík2016-10-201-2/+2
| |
* | RPC: importmulti: Avoid using boost::variant::operator!=, which is only in ↵Luke Dashjr2016-10-201-4/+4
|/ | | | newer boost versions
* Add consistency check to RPC call importmultiPedro Branco2016-10-191-8/+40
|
* Add importmulti rpc callPedro Branco2016-10-191-0/+390
|
* [RPC] Give RPC commands more information about the RPC requestJonas Schnelli2016-10-191-50/+50
|
* [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfundsJonas Schnelli2016-09-201-2/+0
|
* [wallet] rpc: Drop misleading optionMarcoFalke2016-08-241-6/+1
|
* Remove CWalletDB* parameter from CWallet::AddToWalletPatrick Strateman2016-07-291-2/+1
|
* Split CWallet::AddToWallet into AddToWallet and LoadToWallet.Patrick Strateman2016-07-291-1/+1
| | | | | This removes the fFromLoadWallet flag in AddToWallet. These were already effectively two methods.
* [Wallet] add HD xpriv to dumpwalletJonas Schnelli2016-07-271-3/+26
|
* Merge #7687: Stop treating importaddress'ed scripts as changeWladimir J. van der Laan2016-06-201-0/+7
|\ | | | | | | 595b22e Stop treating importaddress'ed scripts as change (Pieter Wuille)
| * Stop treating importaddress'ed scripts as changePieter Wuille2016-06-021-0/+7
| | | | | | | | | | | | | | | | | | | | Before this, if someone imported a scriptPubKey directly (in hex form) using importaddress, outputs sending to it would be treated as change, as the corresponding CTxDestination was not added to the address book. Fix this by trying to detect scriptPubKeys that are in fact convertible to a CTxDestination and add them anyway. Add a warning to the RPC help to warn against importing raw non-standard scripts.
* | build: Get rid of `CLIENT_DATE`Wladimir J. van der Laan2016-06-091-1/+1
|/ | | | | | | Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common. Continues #7732 which did this for the GUI.
* Added companion removeprunedfunds call.instagibbs2016-03-231-0/+38
|
* Add importprunedfunds rpc callinstagibbs2016-03-231-0/+67
|
* Correct importaddress help reference to importpubkeyDenis Lukianov2016-03-211-1/+1
|
* move rpc* to rpc/Daniel Cousens2016-01-211-1/+1
|
* Bump copyright headers to 2015MarcoFalke2015-12-131-1/+1
|
* [Univalue] add univalue over subtreeJonas Schnelli2015-10-011-1/+1
| | | | similar to secp256k1 include and compile univalue over a subtree
* Enable wallet key imports without rescan in pruned mode.Gregory Maxwell2015-09-071-6/+9
| | | | | | | | | | | | | Complete rescan is incompatible with pruning, but rescan is optional on our wallet key import RPCs. Import on use is very useful in some common situations in conjunction with pruning, e.g. merchant payment tracking. This reenables importprivkey/importaddress/importpubkey when rescan is not used. In the future we should consider changing the rescan argument to allow depth or date to allow limited rescanning when compatible with the retained block depth.
* Merge pull request #6415Wladimir J. van der Laan2015-08-141-31/+104
|\ | | | | | | | | | | | | | | | | | | | | | | | | d042854 SQUASH "Implement watchonly support in fundrawtransaction" (Matt Corallo) 428a898 SQUASH "Add have-pubkey distinction to ISMINE flags" (Matt Corallo) 6bdb474 Implement watchonly support in fundrawtransaction (Matt Corallo) f5813bd Add logic to track pubkeys as watch-only, not just scripts (Matt Corallo) d3354c5 Add have-pubkey distinction to ISMINE flags (Matt Corallo) 5c17059 Update importaddress help to push its use to script-only (Matt Corallo) a1d7df3 Add importpubkey method to import a watch-only pubkey (Matt Corallo) 907a425 Add p2sh option to importaddress to import redeemScripts (Matt Corallo) 983d2d9 Split up importaddress into helper functions (Matt Corallo) cfc3dd3 Also remove pay-2-pubkey from watch when adding a priv key (Matt Corallo)
| * Update importaddress help to push its use to script-onlyMatt Corallo2015-07-201-6/+7
| |
| * Add importpubkey method to import a watch-only pubkeyMatt Corallo2015-07-201-0/+57
| |
| * Add p2sh option to importaddress to import redeemScriptsMatt Corallo2015-07-201-6/+20
| |
generated by cgit v1.2.3 (git 2.25.1) at 2026-03-12 02:53:39 +0000