aboutsummaryrefslogtreecommitdiff
path: root/src/torcontrol.cpp
diff options
context:
space:
mode:
authorWladimir J. van der Laan <[email protected]>2016-11-28 17:13:51 +0100
committerWladimir J. van der Laan <[email protected]>2016-11-28 17:18:46 +0100
commit7d3b627395582ae7c9d54ebdbc68096d7042162b (patch)
treed7b87a35b2d85d075f5211c8f0216283250f70ad /src/torcontrol.cpp
parentMerge #9219: doc: Improve windows build instructions using Linux subsystem (diff)
downloaddiscoin-7d3b627395582ae7c9d54ebdbc68096d7042162b.tar.xz
discoin-7d3b627395582ae7c9d54ebdbc68096d7042162b.zip
torcontrol: Explicitly request RSA1024 private key
When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See #9214.
Diffstat (limited to 'src/torcontrol.cpp')
-rw-r--r--src/torcontrol.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/torcontrol.cpp b/src/torcontrol.cpp
index 1ca6b4656..ffb9993f9 100644
--- a/src/torcontrol.cpp
+++ b/src/torcontrol.cpp
@@ -470,7 +470,7 @@ void TorController::auth_cb(TorControlConnection& _conn, const TorControlReply&
// Finally - now create the service
if (private_key.empty()) // No private key, generate one
- private_key = "NEW:BEST";
+ private_key = "NEW:RSA1024"; // Explicitly request RSA1024 - see issue #9214
// Request hidden service, redirect port.
// Note that the 'virtual' port doesn't have to be the same as our internal port, but this is just a convenient
// choice. TODO; refactor the shutdown sequence some day.