diff options
| author | Wladimir J. van der Laan <[email protected]> | 2016-09-27 14:05:24 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2016-09-28 12:44:13 +0200 |
| commit | 41e58faf043864a64a6db08a8df527fa5fd1ec5b (patch) | |
| tree | dbe0c6c2dee6615abee3d97d6b8af98c66effc47 /src/protocol.h | |
| parent | Merge #8655: Do not shadow variables (trivials) (diff) | |
| download | discoin-41e58faf043864a64a6db08a8df527fa5fd1ec5b.tar.xz discoin-41e58faf043864a64a6db08a8df527fa5fd1ec5b.zip | |
net: Consistent checksum handling
In principle, the checksums of P2P packets are simply 4-byte blobs which
are the first four bytes of SHA256(SHA256(payload)).
Currently they are handled as little-endian 32-bit integers half of the
time, as blobs the other half, sometimes copying the one to the other,
resulting in somewhat confused code.
This PR changes the handling to be consistent both at packet creation
and receiving, making it (I think) easier to understand.
Diffstat (limited to 'src/protocol.h')
| -rw-r--r-- | src/protocol.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/protocol.h b/src/protocol.h index 9b474ec79..177d74530 100644 --- a/src/protocol.h +++ b/src/protocol.h @@ -45,7 +45,7 @@ public: READWRITE(FLATDATA(pchMessageStart)); READWRITE(FLATDATA(pchCommand)); READWRITE(nMessageSize); - READWRITE(nChecksum); + READWRITE(FLATDATA(pchChecksum)); } // TODO: make private (improves encapsulation) @@ -62,7 +62,7 @@ public: char pchMessageStart[MESSAGE_START_SIZE]; char pchCommand[COMMAND_SIZE]; unsigned int nMessageSize; - unsigned int nChecksum; + uint8_t pchChecksum[CHECKSUM_SIZE]; }; /** |