diff options
| author | Gavin Andresen <[email protected]> | 2013-05-07 10:47:00 -0400 |
|---|---|---|
| committer | Gavin Andresen <[email protected]> | 2013-05-07 11:47:33 -0400 |
| commit | 92f2c1fe0fe2905540b0435188988851145f92be (patch) | |
| tree | bd9d7b05aee0bbe4520ddcb08b0a88947c51795d /src/init.cpp | |
| parent | Merge pull request #2621 from celeduc/master (diff) | |
| download | discoin-92f2c1fe0fe2905540b0435188988851145f92be.tar.xz discoin-92f2c1fe0fe2905540b0435188988851145f92be.zip | |
Use boost::asio::deadline_timer for walletpassphrase timeout
New method in bitcoinrpc: RunLater, that uses a map of deadline
timers to run a function later.
Behavior of walletpassphrase is changed; before, calling
walletpassphrase again before the lock timeout passed
would result in: Error: Wallet is already unlocked.
You would have to call lockwallet before walletpassphrase.
Now: the last walletpassphrase with correct password
wins, and overrides any previous timeout.
Fixes issue# 1961 which was caused by spawning too many threads.
Test plan:
Start with encrypted wallet, password 'foo'
NOTE:
python -c 'import time; print("%d"%time.time())'
... will tell you current unix timestamp.
Try:
walletpassphrase foo 600
getinfo
EXPECT: unlocked_until is about 10 minutes in the future
walletpassphrase foo 1
sleep 2
sendtoaddress mun74Bvba3B1PF2YkrF4NsgcJwHXXh12LF 11
EXPECT: Error: Please enter the wallet passphrase with walletpassphrase first.
walletpassphrase foo 600
walletpassphrase foo 0
getinfo
EXPECT: wallet is locked (unlocked_until is 0)
walletpassphrase foo 10
walletpassphrase foo 600
getinfo
EXPECT: wallet is unlocked until 10 minutes in future
walletpassphrase foo 60
walletpassphrase bar 600
EXPECT: Error, incorrect passphrase
getinfo
EXPECT: wallet still scheduled to lock 60 seconds from first (successful) walletpassphrase
Diffstat (limited to 'src/init.cpp')
0 files changed, 0 insertions, 0 deletions