aboutsummaryrefslogtreecommitdiff
path: root/src/bitcoinrpc.cpp
diff options
context:
space:
mode:
authorJeff Garzik <[email protected]>2012-05-17 08:49:16 -0700
committerJeff Garzik <[email protected]>2012-05-17 08:49:16 -0700
commitcf2f7c30a3b461c8db8703f3d522076fdacd81ba (patch)
treecaa85fe1518b5998cdb7c200b4d5d74c5576b300 /src/bitcoinrpc.cpp
parentMerge pull request #1316 from jgarzik/dead-code (diff)
parentAlways check return values of TxnBegin() and TxnCommit() (diff)
downloaddiscoin-cf2f7c30a3b461c8db8703f3d522076fdacd81ba.tar.xz
discoin-cf2f7c30a3b461c8db8703f3d522076fdacd81ba.zip
Merge pull request #1295 from jgarzik/txn-retval
[FIX] Always check return values of TxnBegin() and TxnCommit()
Diffstat (limited to 'src/bitcoinrpc.cpp')
-rw-r--r--src/bitcoinrpc.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/bitcoinrpc.cpp b/src/bitcoinrpc.cpp
index e058978eb..8e4361c92 100644
--- a/src/bitcoinrpc.cpp
+++ b/src/bitcoinrpc.cpp
@@ -1037,7 +1037,8 @@ Value movecmd(const Array& params, bool fHelp)
strComment = params[4].get_str();
CWalletDB walletdb(pwalletMain->strWalletFile);
- walletdb.TxnBegin();
+ if (!walletdb.TxnBegin())
+ throw JSONRPCError(-20, "database error");
int64 nNow = GetAdjustedTime();
@@ -1059,7 +1060,8 @@ Value movecmd(const Array& params, bool fHelp)
credit.strComment = strComment;
walletdb.WriteAccountingEntry(credit);
- walletdb.TxnCommit();
+ if (!walletdb.TxnCommit())
+ throw JSONRPCError(-20, "database error");
return true;
}