diff options
| author | Patrick Strateman <[email protected]> | 2015-12-07 16:14:12 -0800 |
|---|---|---|
| committer | Patrick Strateman <[email protected]> | 2015-12-10 22:44:09 -0800 |
| commit | e1030dddab11553d2854c1f466e5757d9815bfb8 (patch) | |
| tree | f391ea3704d59eada2f36aa2ee61d486c1664242 | |
| parent | Merge pull request #7179 (diff) | |
| download | discoin-e1030dddab11553d2854c1f466e5757d9815bfb8.tar.xz discoin-e1030dddab11553d2854c1f466e5757d9815bfb8.zip | |
Note that reviewers should mention the commit hash of the commits they reviewed.
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1d42dea84..53d6527d4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -95,6 +95,8 @@ Anyone may participate in peer review which is expressed by comments in the pull - Concept ACK means "I agree in the general principle of this pull request"; - Nit refers to trivial, often non-blocking issues. +Reviewers should include the commit hash which they reviewed in their comments. + Project maintainers reserve the right to weigh the opinions of peer reviewers using common sense judgement and also may weight based on meritocracy: Those that have demonstrated a deeper commitment and understanding towards the project (over time) or have clear domain expertise may naturally have more weight, as one would expect in all walks of life. Where a patch set affects consensus critical code, the bar will be set much higher in terms of discussion and peer review requirements, keeping in mind that mistakes could be very costly to the wider community. This includes refactoring of consensus critical code. |