diff options
| author | Jonas Schnelli <[email protected]> | 2016-09-20 15:31:51 +0200 |
|---|---|---|
| committer | Jonas Schnelli <[email protected]> | 2016-09-20 15:34:33 +0200 |
| commit | 6052d509105790a26b3ad5df43dd61e7f1b24a12 (patch) | |
| tree | 2a0b6ae772723599f15fa21fd3c5812f6b72821d | |
| parent | Merge #7783: [Qt] RPC-Console: support nested commands and simple value queries (diff) | |
| parent | qt: Adding transaction size to transaction details window (diff) | |
| download | discoin-6052d509105790a26b3ad5df43dd61e7f1b24a12.tar.xz discoin-6052d509105790a26b3ad5df43dd61e7f1b24a12.zip | |
Merge #8672: Qt: Show transaction size in transaction details window
c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg)
\-- merge fix for s/size/total size/
fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg)
| -rw-r--r-- | src/primitives/transaction.cpp | 5 | ||||
| -rw-r--r-- | src/primitives/transaction.h | 7 | ||||
| -rw-r--r-- | src/qt/transactiondesc.cpp | 1 |
3 files changed, 13 insertions, 0 deletions
diff --git a/src/primitives/transaction.cpp b/src/primitives/transaction.cpp index 2fdc59ea0..4afbe99fd 100644 --- a/src/primitives/transaction.cpp +++ b/src/primitives/transaction.cpp @@ -131,6 +131,11 @@ unsigned int CTransaction::CalculateModifiedSize(unsigned int nTxSize) const return nTxSize; } +unsigned int CTransaction::GetTotalSize() const +{ + return ::GetSerializeSize(*this, SER_NETWORK, PROTOCOL_VERSION); +} + std::string CTransaction::ToString() const { std::string str; diff --git a/src/primitives/transaction.h b/src/primitives/transaction.h index 5689d15bf..16c2e5c45 100644 --- a/src/primitives/transaction.h +++ b/src/primitives/transaction.h @@ -415,6 +415,13 @@ public: // Compute modified tx size for priority calculation (optionally given tx size) unsigned int CalculateModifiedSize(unsigned int nTxSize=0) const; + + /** + * Get the total transaction size in bytes, including witness data. + * "Total Size" defined in BIP141 and BIP144. + * @return Total transaction size in bytes + */ + unsigned int GetTotalSize() const; bool IsCoinBase() const { diff --git a/src/qt/transactiondesc.cpp b/src/qt/transactiondesc.cpp index bae0cbd1c..65144e786 100644 --- a/src/qt/transactiondesc.cpp +++ b/src/qt/transactiondesc.cpp @@ -241,6 +241,7 @@ QString TransactionDesc::toHTML(CWallet *wallet, CWalletTx &wtx, TransactionReco strHTML += "<br><b>" + tr("Comment") + ":</b><br>" + GUIUtil::HtmlEscape(wtx.mapValue["comment"], true) + "<br>"; strHTML += "<b>" + tr("Transaction ID") + ":</b> " + rec->getTxID() + "<br>"; + strHTML += "<b>" + tr("Transaction total size") + ":</b> " + QString::number(wtx.GetTotalSize()) + " bytes<br>"; strHTML += "<b>" + tr("Output index") + ":</b> " + QString::number(rec->getOutputIndex()) + "<br>"; // Message from normal bitcoin:URI (bitcoin:123...?message=example) |