diff options
| author | acdenisSK <[email protected]> | 2018-07-21 22:04:29 +0200 |
|---|---|---|
| committer | acdenisSK <[email protected]> | 2018-07-21 22:25:29 +0200 |
| commit | 9c4abcc8816a9019f5cf8cc595022ea9060070a8 (patch) | |
| tree | c00a2fe46c76607cdc501cba7d13b2d185a612fa /src/framework | |
| parent | Add default-commands for command-groups (#351) (diff) | |
| download | serenity-9c4abcc8816a9019f5cf8cc595022ea9060070a8.tar.xz serenity-9c4abcc8816a9019f5cf8cc595022ea9060070a8.zip | |
Some minor changes to `Args`
- use `?` rather than unwrap
- Remove the `PartialEq<TokenKind> impl; it's not needed anymore.
- Inline `at_end` because why not.
- Split the second part of the while condition as an if inside the body.
Diffstat (limited to 'src/framework')
| -rw-r--r-- | src/framework/standard/args.rs | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/src/framework/standard/args.rs b/src/framework/standard/args.rs index d561e30..bf3056b 100644 --- a/src/framework/standard/args.rs +++ b/src/framework/standard/args.rs @@ -88,12 +88,6 @@ impl Token { } } -impl PartialEq<TokenKind> for Token { - fn eq(&self, other: &TokenKind) -> bool { - self.kind == *other - } -} - #[derive(Debug)] struct Lexer<'a> { msg: &'a str, @@ -110,6 +104,7 @@ impl<'a> Lexer<'a> { } } + #[inline] fn at_end(&self) -> bool { self.offset >= self.msg.len() } @@ -137,17 +132,17 @@ impl<'a> Lexer<'a> { return None; } - if self.current().unwrap().contains(self.delims) { + if self.current()?.contains(self.delims) { let start = self.offset; self.next(); return Some(Token::new(TokenKind::Delimiter, &self.msg[start..self.offset], start)); } - if self.current().unwrap() == "\"" { + if self.current()? == "\"" { let start = self.offset; self.next(); - while !self.at_end() && self.current().unwrap() != "\"" { + while !self.at_end() && self.current()? != "\"" { self.next(); } @@ -166,7 +161,11 @@ impl<'a> Lexer<'a> { let start = self.offset; - while !self.at_end() && !self.current().unwrap().contains(self.delims) { + while !self.at_end() { + if self.current()?.contains(self.delims) { + break; + } + self.next(); } |