aboutsummaryrefslogtreecommitdiff
path: root/openssl/src
diff options
context:
space:
mode:
authorBenjamin Fry <[email protected]>2017-03-23 22:11:23 -0700
committerBastian Köcher <[email protected]>2018-03-07 13:54:15 +0100
commita1cfde765a2a63798411ce4d518b8d32c085ffbf (patch)
treebf7fe6506cc9d069965b0fb9591a80d02535ba85 /openssl/src
parentrestructure to self contained function (diff)
downloadrust-openssl-a1cfde765a2a63798411ce4d518b8d32c085ffbf.tar.xz
rust-openssl-a1cfde765a2a63798411ce4d518b8d32c085ffbf.zip
add cleanup ffi to store context
Diffstat (limited to 'openssl/src')
-rw-r--r--openssl/src/x509/mod.rs8
-rw-r--r--openssl/src/x509/tests.rs2
2 files changed, 7 insertions, 3 deletions
diff --git a/openssl/src/x509/mod.rs b/openssl/src/x509/mod.rs
index 5dd12b0e..0cfa8ada 100644
--- a/openssl/src/x509/mod.rs
+++ b/openssl/src/x509/mod.rs
@@ -117,14 +117,18 @@ impl X509StoreContextRef {
/// # Result
///
/// The Result must be `Some(None)` to be a valid certificate, otherwise the cert is not valid.
- pub fn verify_cert(trust: &store::X509StoreRef, cert: &X509Ref, cert_chain: &StackRef<X509>) -> Result<Option<X509VerifyError>, ErrorStack> {
+ pub fn verify_cert(trust: store::X509Store, cert: X509, cert_chain: Stack<X509>) -> Result<Option<X509VerifyError>, ErrorStack> {
unsafe {
ffi::init();
let context = try!(cvt_p(ffi::X509_STORE_CTX_new()).map(|p| X509StoreContext(p)));
try!(cvt(ffi::X509_STORE_CTX_init(context.as_ptr(), trust.as_ptr(), cert.as_ptr(), cert_chain.as_ptr()))
.map(|_| ()));
try!(cvt(ffi::X509_verify_cert(context.as_ptr())).map(|_| ()));
- Ok(context.error())
+
+ let result = Ok(context.error());
+ ffi::X509_STORE_CTX_cleanup(context.as_ptr());
+
+ result
}
}
diff --git a/openssl/src/x509/tests.rs b/openssl/src/x509/tests.rs
index 05baac12..96d45742 100644
--- a/openssl/src/x509/tests.rs
+++ b/openssl/src/x509/tests.rs
@@ -303,5 +303,5 @@ fn test_verify_cert() {
store_bldr.add_cert(ca).unwrap();
let store = store_bldr.build();
- assert!(X509StoreContext::verify_cert(&store, &cert, &Stack::new().unwrap()).unwrap().is_none());
+ assert!(X509StoreContext::verify_cert(store, cert, Stack::new().unwrap()).unwrap().is_none());
}