improvements to the binary writing function

1 files changed, 8 insertions, 15 deletions

diff --git a/CST 126/Homework2/Base64Helper.hpp b/CST 126/Homework2/Base64Helper.hpp
index 744707f..20721bf 100644
--- a/CST 126/Homework2/Base64Helper.hpp
+++ b/CST 126/Homework2/Base64Helper.hpp
@@ -74,7 +74,7 @@ inline char* ReadFileAsBinary(const char* fileName, char* buffer, const size_t&
 	}
 }
 
-inline bool WriteFileFromBinary(const size_t& size, const char* fileName, char* buffer, std::string fileContents)
+inline bool WriteFileFromBinary(const char* fileName, const char* buffer, std::string fileContents)
 {
 	try
 	{
@@ -85,21 +85,14 @@ inline bool WriteFileFromBinary(const size_t& size, const char* fileName, char*
 		{
 			std::cerr << "Could not open file for binary output: " << fileName;
 		}
-	
-		size_t NewSize = fileContents.size();
-	
-		buffer = new char[NewSize];
-
-		for (auto i = 0u; i < NewSize; i++)
-		{
-			buffer[i] = fileContents[i];
-		}
-
-		File.write(buffer, size);
+		
+		buffer = nullptr;
+		buffer = fileContents.c_str();
+		size_t NewSize = fileContents.size() - 1;
+		File.write(buffer, NewSize);
 		File.close();
 
-
-		return buffer;
+		return true;
 	}
 	catch (const std::exception& ex)
 	{
@@ -112,7 +105,7 @@ inline bool WriteFileFromBinary(const size_t& size, const char* fileName, char*
 	return false;
 }
 
-inline bool WriteTextToFile(const char* fileName, std::string fileContents/*const char* fileContents*/)
+inline bool WriteTextToFile(const char* fileName, std::string fileContents)
 {
 	std::ofstream File(fileName);