aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFuwn <[email protected]>2026-06-01 15:45:01 +0000
committerFuwn <[email protected]>2026-06-01 15:45:01 +0000
commit6a7228c06d7af2a28ead1f4ae1830a258c05afae (patch)
tree26a1fc3cc8546bd15dac92910998afb8c2a67fd9
parentfix(security): allow-list web-push endpoints to stop SSRF (diff)
downloaddue.moe-6a7228c06d7af2a28ead1f4ae1830a258c05afae.tar.xz
due.moe-6a7228c06d7af2a28ead1f4ae1830a258c05afae.zip
fix(security): sanitize third-party RSS HTML before {@html}
The /updates page rendered manga/novel feed fields (content, titles, series names) from mangaupdates/syosetu/wlnupdates via {@html} with no sanitization. CSP already blocks script execution, but injected markup could still phish, redirect, or track. Add sanitizeFeedHtml (DOMPurify with a small safe allow-list) and apply it on ingest. A behaviour-gate test plus a check against the live mangaupdates feed confirm legitimate formatting (entities, <i>/<b>/<a href>) is preserved while <script>, event handlers, <iframe>/<meta>/<style> and javascript: URLs are removed.
-rw-r--r--package.json1
-rw-r--r--pnpm-lock.yaml16
-rw-r--r--src/lib/Utility/sanitizeHtml.test.ts57
-rw-r--r--src/lib/Utility/sanitizeHtml.ts32
-rw-r--r--src/routes/updates/+page.svelte23
5 files changed, 127 insertions, 2 deletions
diff --git a/package.json b/package.json
index c9cce24b..ac44767c 100644
--- a/package.json
+++ b/package.json
@@ -58,6 +58,7 @@
"botid": "^1.5.10",
"caniuse-lite": "^1.0.30001655",
"dexie": "^4.0.1-alpha.25",
+ "dompurify": "^3.4.7",
"effect": "4.0.0-beta.25",
"fast-levenshtein": "^3.0.0",
"jsdom": "^23.0.1",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index d64ad94b..cc1644e5 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -32,6 +32,9 @@ importers:
dexie:
specifier: ^4.0.1-alpha.25
version: 4.2.1
+ dompurify:
+ specifier: ^3.4.7
+ version: 3.4.7
effect:
specifier: 4.0.0-beta.25
version: 4.0.0-beta.25
@@ -2105,6 +2108,9 @@ packages:
resolution: {integrity: sha512-/Ad8+nIOV7Rl++6f1BdKxFSMgmoqEoYbHRpPcx3JEfv8VRsQe9Z4mCXeJBzxs7mbHY/XOZZuXlRNfhpVPbs6ZA==}
+ '@types/[email protected]':
+ resolution: {integrity: sha512-ScaPdn1dQczgbl0QFTeTOmVHFULt394XJgOQNoyVhZ6r2vLnMLJfBPd53SB52T/3G36VI1/g2MZaX0cwDuXsfw==}
+
resolution: {integrity: sha512-GnJmSr40H3RAnj0s34FNTcJi1hmWFV5KXugE0mYWnYhgTAHLJ/dJKAwDmvPJYMke0RplY2XE9LnM4hqSqKIjhQ==}
@@ -2656,6 +2662,9 @@ packages:
resolution: {integrity: sha512-cgwlv/1iFQiFnU96XXgROh8xTeetsnJiDsTc7TYCLFd9+/WNkIqPTxiM/8pSd8VIrhXGTf1Ny1q1hquVqDJB5w==}
engines: {node: '>= 4'}
+ resolution: {integrity: sha512-2jBxDJY4RR06tQNy4w5FlFH7kfxsQZlufd0sbv+chfHCxeJwrFw2baUDsSwvBISD4K4RDbd0PTfy3uNXsR6siA==}
+
resolution: {integrity: sha512-6kZKyUajlDuqlHKVX1w7gyslj9MPIXzIFiz/rGu35uC1wMi+kMhQwGhl4lt9unC9Vb9INnY9Z3/ZA3+FhASLaw==}
@@ -6386,6 +6395,9 @@ snapshots:
'@types/[email protected]': {}
+ '@types/[email protected]':
+ optional: true
+
dependencies:
'@types/node': 17.0.45
@@ -6894,6 +6906,10 @@ snapshots:
dependencies:
domelementtype: 2.3.0
+ optionalDependencies:
+ '@types/trusted-types': 2.0.7
+
dependencies:
dom-serializer: 2.0.0
diff --git a/src/lib/Utility/sanitizeHtml.test.ts b/src/lib/Utility/sanitizeHtml.test.ts
new file mode 100644
index 00000000..1094635e
--- /dev/null
+++ b/src/lib/Utility/sanitizeHtml.test.ts
@@ -0,0 +1,57 @@
+// @vitest-environment jsdom
+import { describe, expect, it } from "vitest";
+import { sanitizeFeedHtml } from "./sanitizeHtml";
+
+describe("sanitizeFeedHtml", () => {
+ // Behaviour gate: the formatting real feeds use must survive untouched.
+ it("preserves entities, inline formatting and safe links", () => {
+ expect(sanitizeFeedHtml("Fruits &amp; Vegetables")).toBe(
+ "Fruits &amp; Vegetables",
+ );
+ expect(sanitizeFeedHtml("<i>italic</i> and <b>bold</b>")).toBe(
+ "<i>italic</i> and <b>bold</b>",
+ );
+ expect(sanitizeFeedHtml("Vol. 1 <em>Ch.</em> 5")).toBe(
+ "Vol. 1 <em>Ch.</em> 5",
+ );
+ expect(
+ sanitizeFeedHtml('<a href="https://example.com/x">link</a>'),
+ ).toContain('href="https://example.com/x"');
+ expect(sanitizeFeedHtml("line<br>break")).toContain("<br");
+ });
+
+ it("returns empty string for nullish input", () => {
+ expect(sanitizeFeedHtml(undefined)).toBe("");
+ expect(sanitizeFeedHtml(null)).toBe("");
+ expect(sanitizeFeedHtml("")).toBe("");
+ });
+
+ // The fix: scripts, handlers, dangerous tags and URLs must be removed.
+ it("strips scripts, event handlers and dangerous tags/urls", () => {
+ const script = sanitizeFeedHtml("<script>alert(1)</script>safe");
+ expect(script).not.toContain("script");
+ expect(script).toContain("safe");
+
+ const onerror = sanitizeFeedHtml("before<img src=x onerror=alert(1)>after");
+ expect(onerror).not.toContain("onerror");
+ expect(onerror).not.toContain("<img");
+ expect(onerror).toContain("before");
+ expect(onerror).toContain("after");
+
+ expect(
+ sanitizeFeedHtml('<a href="javascript:alert(1)">x</a>'),
+ ).not.toContain("javascript:");
+ expect(
+ sanitizeFeedHtml('<iframe src="https://evil.example.com"></iframe>'),
+ ).not.toContain("iframe");
+ expect(
+ sanitizeFeedHtml(
+ '<meta http-equiv="refresh" content="0;url=https://evil.example.com">',
+ ),
+ ).not.toContain("meta");
+ expect(sanitizeFeedHtml("<style>body{display:none}</style>")).not.toContain(
+ "style",
+ );
+ expect(sanitizeFeedHtml('<div onclick="steal()">text</div>')).toBe("text");
+ });
+});
diff --git a/src/lib/Utility/sanitizeHtml.ts b/src/lib/Utility/sanitizeHtml.ts
new file mode 100644
index 00000000..3d0229e4
--- /dev/null
+++ b/src/lib/Utility/sanitizeHtml.ts
@@ -0,0 +1,32 @@
+import DOMPurify from "dompurify";
+
+const feedConfig = {
+ ALLOWED_TAGS: [
+ "a",
+ "b",
+ "i",
+ "em",
+ "strong",
+ "u",
+ "s",
+ "br",
+ "p",
+ "span",
+ "small",
+ "sup",
+ "sub",
+ "code",
+ ],
+ ALLOWED_ATTR: ["href", "title"],
+ ALLOWED_URI_REGEXP: /^(?:https?|mailto):/i,
+};
+
+/**
+ * Sanitise HTML coming from third-party RSS feeds before it reaches an `{@html}`
+ * sink. Keeps the light formatting these feeds actually use (HTML entities,
+ * `<i>`/`<b>`/`<a href>`) and strips anything that could inject content or
+ * behaviour: `<script>`, event-handler attributes, `<iframe>`/`<meta>`/`<style>`,
+ * `javascript:` URLs, and so on. Browser-only — call it from client code.
+ */
+export const sanitizeFeedHtml = (html: string | undefined | null): string =>
+ html ? DOMPurify.sanitize(html, feedConfig) : "";
diff --git a/src/routes/updates/+page.svelte b/src/routes/updates/+page.svelte
index 357a5906..0534d0bb 100644
--- a/src/routes/updates/+page.svelte
+++ b/src/routes/updates/+page.svelte
@@ -5,6 +5,7 @@ import HeadTitle from "$lib/Home/HeadTitle.svelte";
import Skeleton from "$lib/Loading/Skeleton.svelte";
import { createHeightObserver } from "$lib/Utility/html";
import root from "$lib/Utility/root";
+import { sanitizeFeedHtml } from "$lib/Utility/sanitizeHtml";
import locale from "$stores/locale";
let feed:
@@ -35,10 +36,28 @@ onMount(async () => {
removeHeightObserver = createHeightObserver(false);
startTime = performance.now();
- novelFeed = await (await fetch(root("/api/updates/all-novels"))).json();
+
+ const allNovels = await (await fetch(root("/api/updates/all-novels"))).json();
+
+ if (allNovels?.data?.items)
+ for (const item of allNovels.data.items) {
+ if (item.postfix) item.postfix = sanitizeFeedHtml(item.postfix);
+ if (item.series) item.series.name = sanitizeFeedHtml(item.series.name);
+ }
+
+ novelFeed = allNovels;
novelEndTime = performance.now() - startTime;
startTime = performance.now();
- feed = await (await fetch(root("/api/updates/manga"))).json();
+
+ const mangaFeed = await (await fetch(root("/api/updates/manga"))).json();
+
+ if (mangaFeed?.items)
+ for (const item of mangaFeed.items) {
+ item.title = sanitizeFeedHtml(item.title);
+ item.content = sanitizeFeedHtml(item.content);
+ }
+
+ feed = mangaFeed;
mangaEndTime = performance.now() - startTime;
});