Switch to ID abstractions internally

10 files changed, 85 insertions, 57 deletions

diff --git a/lib/models/guild/guild.ml b/lib/models/guild/guild.ml
index 926b152..812a49e 100644
--- a/lib/models/guild/guild.ml
+++ b/lib/models/guild/guild.ml
@@ -4,16 +4,19 @@ open Async
 include Guild_t
 include Impl.Guild(Guild_t)
 
-let get_member ~id guild =
+let get_member ~(id:User_id_t.t) guild =
     match List.find ~f:(fun m -> m.user.id = id) guild.members with
     | Some m -> Deferred.Or_error.return m
-    | None -> Http.get_member (get_id guild) id
+    | None ->
+        let `User_id id = id in
+        Http.get_member (get_id guild) id
 
-let get_channel ~id guild =
+let get_channel ~(id:Channel_id_t.t) guild =
+    let `Channel_id id = id in
     match List.find ~f:(fun c -> Channel_t.get_id c = id) guild.channels with
     | Some c -> Deferred.Or_error.return c
     | None -> Http.get_channel id
 
 (* TODO add HTTP fallback *)
-let get_role ~id guild =
+let get_role ~(id:Role_id.t) guild =
     List.find ~f:(fun r -> r.id = id) guild.roles
\ No newline at end of file
diff --git a/lib/models/guild/guild.mli b/lib/models/guild/guild.mli
index a6d3bcf..81055a1 100644
--- a/lib/models/guild/guild.mli
+++ b/lib/models/guild/guild.mli
@@ -4,6 +4,6 @@ include module type of Guild_t
 include S.GuildImpl with
     type t := Guild_t.t
 
-val get_channel : id:Snowflake.t -> t -> Channel_t.t Deferred.Or_error.t
-val get_member : id:Snowflake.t -> t -> Member_t.t Deferred.Or_error.t
-val get_role : id:Snowflake.t -> t -> Role_t.t option
\ No newline at end of file
+val get_channel : id:Channel_id_t.t -> t -> Channel_t.t Deferred.Or_error.t
+val get_member : id:User_id_t.t -> t -> Member_t.t Deferred.Or_error.t
+val get_role : id:Role_id.t -> t -> Role_t.t option
\ No newline at end of file
diff --git a/lib/models/guild/guild_t.ml b/lib/models/guild/guild_t.ml
index 97e3c48..42e373c 100644
--- a/lib/models/guild/guild_t.ml
+++ b/lib/models/guild/guild_t.ml
@@ -5,16 +5,16 @@ type unavailable = {
 } [@@deriving sexp, yojson { strict = false }]
 
 type pre = {
-    id: Snowflake.t;
+    id: Guild_id_t.t;
     name: string;
     icon: string option [@default None];
     splash: string option [@default None];
-    owner_id: Snowflake.t;
+    owner_id: User_id_t.t;
     region: string;
-    afk_channel_id: Snowflake.t option [@default None];
+    afk_channel_id: Channel_id_t.t option [@default None];
     afk_timeout: int;
     embed_enabled: bool option [@default None];
-    embed_channel_id: Snowflake.t option [@default None];
+    embed_channel_id: Channel_id_t.t option [@default None];
     verification_level: int;
     default_message_notifications: int;
     explicit_content_filter: int;
@@ -34,16 +34,16 @@ type pre = {
 } [@@deriving sexp, yojson { strict = false }]
 
 type t = {
-    id: Snowflake.t;
+    id: Guild_id_t.t;
     name: string;
     icon: string option [@default None];
     splash: string option [@default None];
-    owner_id: Snowflake.t;
+    owner_id: User_id_t.t;
     region: string;
-    afk_channel_id: Snowflake.t option [@default None];
+    afk_channel_id: Channel_id_t.t option [@default None];
     afk_timeout: int;
     embed_enabled: bool option [@default None];
-    embed_channel_id: Snowflake.t option [@default None];
+    embed_channel_id: Channel_id_t.t option [@default None];
     verification_level: int;
     default_message_notifications: int;
     explicit_content_filter: int;
@@ -63,11 +63,12 @@ type t = {
 } [@@deriving sexp, yojson { strict = false }]
 
 let wrap ({id;name;icon;splash;owner_id;region;afk_channel_id;afk_timeout;embed_enabled;embed_channel_id;verification_level;default_message_notifications;explicit_content_filter;roles;emojis;features;mfa_level;application_id;widget_enabled;widget_channel;system_channel;large;unavailable;member_count;members;channels}:pre) =
+    let `Guild_id id = id in
     let roles = List.map ~f:(Role_t.wrap ~guild_id:id) roles in
     let members = List.map ~f:(Member_t.wrap ~guild_id:id) members in
     let channels = List.map ~f:Channel_t.wrap channels in
     let widget_channel = Option.map ~f:Channel_t.wrap widget_channel in
     let system_channel = Option.map ~f:Channel_t.wrap system_channel in
-    {id;name;icon;splash;owner_id;region;afk_channel_id;afk_timeout;embed_enabled;embed_channel_id;verification_level;default_message_notifications;explicit_content_filter;roles;emojis;features;mfa_level;application_id;widget_enabled;widget_channel;system_channel;large;unavailable;member_count;members;channels}
+    {id = `Guild_id id;name;icon;splash;owner_id;region;afk_channel_id;afk_timeout;embed_enabled;embed_channel_id;verification_level;default_message_notifications;explicit_content_filter;roles;emojis;features;mfa_level;application_id;widget_enabled;widget_channel;system_channel;large;unavailable;member_count;members;channels}
 
-let get_id guild = guild.id
\ No newline at end of file
+let get_id guild = let `Guild_id id = guild.id in id
\ No newline at end of file
diff --git a/lib/models/guild/guild_t.mli b/lib/models/guild/guild_t.mli
index 8fdd9a7..0b1ec92 100644
--- a/lib/models/guild/guild_t.mli
+++ b/lib/models/guild/guild_t.mli
@@ -3,16 +3,16 @@ type unavailable = {
 } [@@deriving sexp, yojson]
 
 type pre = {
-    id: Snowflake.t;
+    id: Guild_id_t.t;
     name: string;
     icon: string option;
     splash: string option;
-    owner_id: Snowflake.t;
+    owner_id: User_id_t.t;
     region: string;
-    afk_channel_id: Snowflake.t option;
+    afk_channel_id: Channel_id_t.t option;
     afk_timeout: int;
     embed_enabled: bool option;
-    embed_channel_id: Snowflake.t option;
+    embed_channel_id: Channel_id_t.t option;
     verification_level: int;
     default_message_notifications: int;
     explicit_content_filter: int;
@@ -32,16 +32,16 @@ type pre = {
 } [@@deriving sexp, yojson]
 
 type t = {
-    id: Snowflake.t;
+    id: Guild_id_t.t;
     name: string;
     icon: string option;
     splash: string option;
-    owner_id: Snowflake.t;
+    owner_id: User_id_t.t;
     region: string;
-    afk_channel_id: Snowflake.t option;
+    afk_channel_id: Channel_id_t.t option;
     afk_timeout: int;
     embed_enabled: bool option;
-    embed_channel_id: Snowflake.t option;
+    embed_channel_id: Channel_id_t.t option;
     verification_level: int;
     default_message_notifications: int;
     explicit_content_filter: int;
diff --git a/lib/models/guild/member.ml b/lib/models/guild/member.ml
index 7634d85..f083cce 100644
--- a/lib/models/guild/member.ml
+++ b/lib/models/guild/member.ml
@@ -1,39 +1,57 @@
 include Member_t
 
 let add_role ~(role:Role_t.t) member =
-    Http.add_member_role member.guild_id member.user.id role.id
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
+    let `Role_id role_id = role.id in
+    Http.add_member_role guild_id user_id role_id
 
 let remove_role ~(role:Role_t.t) member =
-    Http.remove_member_role member.guild_id member.user.id role.id
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
+    let `Role_id role_id = role.id in
+    Http.remove_member_role guild_id user_id role_id
 
 let ban ?(reason="") ?(days=0) member =
-    Http.guild_ban_add member.guild_id member.user.id (`Assoc [
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
+    Http.guild_ban_add guild_id user_id (`Assoc [
         ("delete-message-days", `Int days);
         ("reason", `String reason);
     ])
 
 let kick ?reason member =
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
     let payload = match reason with
     | Some r -> `Assoc [("reason", `String r)]
     | None -> `Null
-    in Http.remove_member member.guild_id member.user.id payload
+    in Http.remove_member guild_id user_id payload
 
 let mute member =
-    Http.edit_member member.guild_id member.user.id (`Assoc [
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
+    Http.edit_member guild_id user_id (`Assoc [
         ("mute", `Bool true);
     ])
 
 let deafen member =
-    Http.edit_member member.guild_id member.user.id (`Assoc [
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
+    Http.edit_member guild_id user_id (`Assoc [
         ("deaf", `Bool true);
     ])
 
 let unmute member =
-    Http.edit_member member.guild_id member.user.id (`Assoc [
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
+    Http.edit_member guild_id user_id (`Assoc [
         ("mute", `Bool false);
     ])
 
 let undeafen member =
-    Http.edit_member member.guild_id member.user.id (`Assoc [
+    let `Guild_id guild_id = member.guild_id in
+    let `User_id user_id = member.user.id in
+    Http.edit_member guild_id user_id (`Assoc [
         ("deaf", `Bool false);
     ])
diff --git a/lib/models/guild/member_t.ml b/lib/models/guild/member_t.ml
index e6edb61..10f1cf0 100644
--- a/lib/models/guild/member_t.ml
+++ b/lib/models/guild/member_t.ml
@@ -2,7 +2,7 @@ open Core
 
 type partial_member = {
     nick: string option [@default None];
-    roles: Snowflake.t list;
+    roles: Role_id.t list;
     joined_at: string;
     deaf: bool;
     mute: bool;
@@ -10,7 +10,7 @@ type partial_member = {
 
 type member = {
     nick: string option [@default None];
-    roles: Snowflake.t list;
+    roles: Role_id.t list;
     joined_at: string;
     deaf: bool;
     mute: bool;
@@ -18,26 +18,26 @@ type member = {
 } [@@deriving sexp, yojson { strict = false}]
 
 type member_wrapper = {
-    guild_id: Snowflake.t;
+    guild_id: Guild_id_t.t;
     user: User_t.t;
 } [@@deriving sexp, yojson { strict = false }]
 
 type member_update = {
-    guild_id: Snowflake.t;
-    roles: Snowflake.t list [@default []];
+    guild_id: Guild_id_t.t;
+    roles: Role_id.t list [@default []];
     user: User_t.t;
     nick: string option [@default None];
 } [@@deriving sexp, yojson { strict = false}]
 
 type t = {
     nick: string option [@default None];
-    roles: Snowflake.t list;
+    roles: Role_id.t list;
     joined_at: string;
     deaf: bool;
     mute: bool;
     user: User_t.t;
-    guild_id: Snowflake.t;
+    guild_id: Guild_id_t.t;
 } [@@deriving sexp, yojson { strict = false}]
 
 let wrap ~guild_id ({nick;roles;joined_at;deaf;mute;user}:member) =
-    {nick;roles;joined_at;deaf;mute;user;guild_id}
\ No newline at end of file
+    {nick;roles;joined_at;deaf;mute;user;guild_id = `Guild_id guild_id}
\ No newline at end of file
diff --git a/lib/models/guild/member_t.mli b/lib/models/guild/member_t.mli
index 4655b33..4f39b6c 100644
--- a/lib/models/guild/member_t.mli
+++ b/lib/models/guild/member_t.mli
@@ -1,6 +1,6 @@
 type partial_member = {
     nick: string option;
-    roles: Snowflake.t list;
+    roles: Role_id.t list;
     joined_at: string;
     deaf: bool;
     mute: bool;
@@ -8,7 +8,7 @@ type partial_member = {
 
 type member = {
     nick: string option;
-    roles: Snowflake.t list;
+    roles: Role_id.t list;
     joined_at: string;
     deaf: bool;
     mute: bool;
@@ -16,25 +16,25 @@ type member = {
 } [@@deriving sexp, yojson]
 
 type member_wrapper = {
-    guild_id: Snowflake.t;
+    guild_id: Guild_id_t.t;
     user: User_t.t;
 } [@@deriving sexp, yojson]
 
 type member_update = {
-    guild_id: Snowflake.t;
-    roles: Snowflake.t list;
+    guild_id: Guild_id_t.t;
+    roles: Role_id.t list;
     user: User_t.t;
     nick: string option;
 } [@@deriving sexp, yojson]
 
 type t = {
     nick: string option;
-    roles: Snowflake.t list;
+    roles: Role_id.t list;
     joined_at: string;
     deaf: bool;
     mute: bool;
     user: User_t.t;
-    guild_id: Snowflake.t;
+    guild_id: Guild_id_t.t;
 } [@@deriving sexp, yojson]
 
 val wrap : guild_id:Snowflake.t -> member -> t
\ No newline at end of file
diff --git a/lib/models/guild/role.ml b/lib/models/guild/role.ml
index ee6bb0a..46f908b 100644
--- a/lib/models/guild/role.ml
+++ b/lib/models/guild/role.ml
@@ -1,11 +1,17 @@
 include Role_t
 
-let edit_role ~body (role:t) = Http.guild_role_edit role.guild_id role.id body
+let edit_role ~body (role:t) =
+    let `Role_id id = role.id in
+    let `Guild_id guild_id = role.guild_id in
+    Http.guild_role_edit guild_id id body
 
 let allow_mention role =
     edit_role ~body:(`Assoc [("mentionable", `Bool true)]) role
 
-let delete (role:t) = Http.guild_role_remove role.guild_id role.id
+let delete (role:t) =
+    let `Role_id id = role.id in
+    let `Guild_id guild_id = role.guild_id in
+    Http.guild_role_remove guild_id id
 
 let disallow_mention role =
     edit_role ~body:(`Assoc [("mentionable", `Bool false)]) role
diff --git a/lib/models/guild/role_t.ml b/lib/models/guild/role_t.ml
index 9ae53a1..f012a15 100644
--- a/lib/models/guild/role_t.ml
+++ b/lib/models/guild/role_t.ml
@@ -1,7 +1,7 @@
 open Core
 
 type role = {
-    id: Snowflake.t;
+    id: Role_id.t;
     name: string;
     colour: int [@key "color"];
     hoist: bool;
@@ -12,7 +12,7 @@ type role = {
 } [@@deriving sexp, yojson { strict = false}]
 
 type t = {
-    id: Snowflake.t;
+    id: Role_id.t;
     name: string;
     colour: int [@key "color"];
     hoist: bool;
@@ -20,8 +20,8 @@ type t = {
     permissions: int;
     managed: bool;
     mentionable: bool;
-    guild_id: Snowflake.t;
+    guild_id: Guild_id_t.t;
 } [@@deriving sexp, yojson { strict = false}]
 
 let wrap ~guild_id ({id;name;colour;hoist;position;permissions;managed;mentionable}:role) =
-    {id;name;colour;hoist;position;permissions;managed;mentionable;guild_id}
\ No newline at end of file
+    {id;name;colour;hoist;position;permissions;managed;mentionable;guild_id = `Guild_id guild_id}
\ No newline at end of file
diff --git a/lib/models/guild/role_t.mli b/lib/models/guild/role_t.mli
index cd536fe..99517b8 100644
--- a/lib/models/guild/role_t.mli
+++ b/lib/models/guild/role_t.mli
@@ -1,5 +1,5 @@
 type role = {
-    id: Snowflake.t;
+    id: Role_id.t;
     name: string;
     colour: int;
     hoist: bool;
@@ -10,7 +10,7 @@ type role = {
 } [@@deriving sexp, yojson]
 
 type t = {
-    id: Snowflake.t;
+    id: Role_id.t;
     name: string;
     colour: int;
     hoist: bool;
@@ -18,7 +18,7 @@ type t = {
     permissions: int;
     managed: bool;
     mentionable: bool;
-    guild_id: Snowflake.t;
+    guild_id: Guild_id_t.t;
 } [@@deriving sexp, yojson]
 
 val wrap : guild_id:Snowflake.t -> role -> t
\ No newline at end of file