diff options
| author | Fuwn <[email protected]> | 2026-02-10 00:12:25 -0800 |
|---|---|---|
| committer | Fuwn <[email protected]> | 2026-02-10 00:12:25 -0800 |
| commit | 32219ec9656e7f46e516c7c41c133133d008e9a4 (patch) | |
| tree | e335fa4b2e32f562b0861cd02a1abe618e8cb6b9 /apps/web/app/reader/settings | |
| parent | fix: P2 security hardening and tier limit parity (diff) | |
| download | asa.news-32219ec9656e7f46e516c7c41c133133d008e9a4.tar.xz asa.news-32219ec9656e7f46e516c7c41c133133d008e9a4.zip | |
fix: reduce lint warnings from 34 to 0
Disable no-img-element (RSS reader needs <img> for arbitrary external
URLs). Remove unused variables/imports and redundant getUser() calls
guarded by middleware. Fix exhaustive-deps by adding stable deps,
wrapping handlers in useCallback, and suppressing intentional omissions.
Fix ref cleanup in use-realtime-entries. Allow triple-slash TS reference
directives in no-comments rule.
Diffstat (limited to 'apps/web/app/reader/settings')
4 files changed, 6 insertions, 10 deletions
diff --git a/apps/web/app/reader/settings/_components/account-settings.tsx b/apps/web/app/reader/settings/_components/account-settings.tsx index 84b8414..9679e3b 100644 --- a/apps/web/app/reader/settings/_components/account-settings.tsx +++ b/apps/web/app/reader/settings/_components/account-settings.tsx @@ -189,6 +189,7 @@ export function AccountSettings() { useEffect(() => { loadFactors() + // eslint-disable-next-line react-hooks/exhaustive-deps }, []) async function handleBeginEnrollment() { diff --git a/apps/web/app/reader/settings/_components/billing-settings.tsx b/apps/web/app/reader/settings/_components/billing-settings.tsx index 79269fc..1e38684 100644 --- a/apps/web/app/reader/settings/_components/billing-settings.tsx +++ b/apps/web/app/reader/settings/_components/billing-settings.tsx @@ -177,6 +177,7 @@ export function BillingSettings() { url.searchParams.delete("billing") window.history.replaceState({}, "", url.pathname) } + // eslint-disable-next-line react-hooks/exhaustive-deps }, [searchParameters, queryClient]) if (isLoading) { diff --git a/apps/web/app/reader/settings/_components/folders-settings.tsx b/apps/web/app/reader/settings/_components/folders-settings.tsx index 2c3d5f2..3bc0b7b 100644 --- a/apps/web/app/reader/settings/_components/folders-settings.tsx +++ b/apps/web/app/reader/settings/_components/folders-settings.tsx @@ -114,14 +114,7 @@ export function FoldersSettings() { ) } -function FolderRow({ - folderIdentifier, - name, - iconUrl, - feedCount, - onSave, - onDelete, -}: { +function FolderRow(properties: { folderIdentifier: string name: string iconUrl: string | null @@ -129,6 +122,7 @@ function FolderRow({ onSave: (name: string, iconUrl: string | null) => void onDelete: () => void }) { + const { name, iconUrl, feedCount, onSave, onDelete } = properties const [isEditing, setIsEditing] = useState(false) const [editedName, setEditedName] = useState(name) const [editedIconUrl, setEditedIconUrl] = useState(iconUrl ?? "") diff --git a/apps/web/app/reader/settings/_components/import-export-settings.tsx b/apps/web/app/reader/settings/_components/import-export-settings.tsx index 27f8933..f0ba3f3 100644 --- a/apps/web/app/reader/settings/_components/import-export-settings.tsx +++ b/apps/web/app/reader/settings/_components/import-export-settings.tsx @@ -61,7 +61,7 @@ export function ImportExportSettings() { for (const group of parsedGroups) { for (const feed of group.feeds) { try { - await new Promise<void>((resolve, reject) => { + await new Promise<void>((resolve) => { subscribeToFeed.mutate( { feedUrl: feed.url, @@ -72,7 +72,7 @@ export function ImportExportSettings() { importedCount++ resolve() }, - onError: (error) => { + onError: () => { failedCount++ resolve() }, |