Various fixes to address issues flagged by gcc / non-UE toolchain build (#621)

* gcc: avoid using memset on nontrivial struct
* redundant `return std::move`
* fixed various compilation issues flagged by gcc
* fix issue in xmake.lua detecting whether we are building with the UE toolchain or not
* add GCC ignore -Wundef (comment is inaccurate)
* remove redundant std::move
* don't catch exceptions by value
* unreferenced variables
* initialize "by the book" instead of memset
* remove unused exception reference
* add #include <cstring> to fix gcc build
* explicitly poulate KeyValueMap by traversing input spans fixes gcc compilation
* remove unreferenced variable
* eliminate redundant `std::move` which gcc complains about
* fix gcc compilation by including <cstring>
* tag unreferenced variable to fix gcc compilation
* fixes for various cases of naming members the same as their type

1 files changed, 1 insertions, 1 deletions

diff --git a/src/zenutil/environmentoptions.cpp b/src/zenutil/environmentoptions.cpp
index 1b7ce8029..ee40086c1 100644
--- a/src/zenutil/environmentoptions.cpp
+++ b/src/zenutil/environmentoptions.cpp
@@ -72,7 +72,7 @@ EnvironmentOptions::Parse(const cxxopts::ParseResult& CmdLineResult)
 		const Option&	 Opt	 = It.second;
 		if (CmdLineResult.count(Opt.CommandLineOptionName) == 0)
 		{
-			std::string EnvValue = GetEnvVariable(It.first);
+			std::string EnvValue = GetEnvVariable(EnvName);
 			if (!EnvValue.empty())
 			{
 				Opt.Value->Parse(EnvValue);