Various fixes to address issues flagged by gcc / non-UE toolchain build (#621)

* gcc: avoid using memset on nontrivial struct
* redundant `return std::move`
* fixed various compilation issues flagged by gcc
* fix issue in xmake.lua detecting whether we are building with the UE toolchain or not
* add GCC ignore -Wundef (comment is inaccurate)
* remove redundant std::move
* don't catch exceptions by value
* unreferenced variables
* initialize "by the book" instead of memset
* remove unused exception reference
* add #include <cstring> to fix gcc build
* explicitly poulate KeyValueMap by traversing input spans fixes gcc compilation
* remove unreferenced variable
* eliminate redundant `std::move` which gcc complains about
* fix gcc compilation by including <cstring>
* tag unreferenced variable to fix gcc compilation
* fixes for various cases of naming members the same as their type

1 files changed, 5 insertions, 0 deletions

diff --git a/src/zenstore/projectstore.cpp b/src/zenstore/projectstore.cpp
index 8ae74c8cf..7570b8513 100644
--- a/src/zenstore/projectstore.cpp
+++ b/src/zenstore/projectstore.cpp
@@ -4709,6 +4709,7 @@ ProjectStore::GetChunkInfo(LoggerRef InLog, Project& Project, Oplog& Oplog, cons
 	using namespace std::literals;
 
 	auto Log = [&InLog]() { return InLog; };
+	ZEN_UNUSED(Log);
 
 	IoBuffer Chunk = Oplog.FindChunk(Project.RootDir, ChunkId, nullptr);
 	if (!Chunk)
@@ -4869,6 +4870,7 @@ ProjectStore::GetChunkRange(LoggerRef	   InLog,
 	ZEN_TRACE_CPU("ProjectStore::GetChunkRange");
 
 	auto Log = [&InLog]() { return InLog; };
+	ZEN_UNUSED(Log);
 
 	uint64_t OldTag = OptionalInOutModificationTag == nullptr ? 0 : *OptionalInOutModificationTag;
 	IoBuffer Chunk	= Oplog.FindChunk(Project.RootDir, ChunkId, OptionalInOutModificationTag);
@@ -6066,6 +6068,7 @@ ProjectStore::LockState(GcCtx& Ctx)
 	ZEN_TRACE_CPU("Store::LockState");
 
 	auto Log = [&Ctx]() { return Ctx.Logger; };
+	ZEN_UNUSED(Log);
 
 	std::vector<RwLock::SharedLockScope> Locks;
 	Locks.emplace_back(RwLock::SharedLockScope(m_ProjectsLock));
@@ -6198,6 +6201,7 @@ ProjectStore::CreateReferenceValidators(GcCtx& Ctx)
 	}
 
 	auto Log = [&Ctx]() { return Ctx.Logger; };
+	ZEN_UNUSED(Log);
 
 	DiscoverProjects();
 
@@ -6408,6 +6412,7 @@ TEST_CASE("project.opkeys")
 		Cbo << "key"sv << LongKey.substr(0, i);
 
 		const Oid KeyId = ComputeOpKey(Cbo.Save());
+		ZEN_UNUSED(KeyId);
 	}
 
 	{