Various fixes to address issues flagged by gcc / non-UE toolchain build (#621)

* gcc: avoid using memset on nontrivial struct
* redundant `return std::move`
* fixed various compilation issues flagged by gcc
* fix issue in xmake.lua detecting whether we are building with the UE toolchain or not
* add GCC ignore -Wundef (comment is inaccurate)
* remove redundant std::move
* don't catch exceptions by value
* unreferenced variables
* initialize "by the book" instead of memset
* remove unused exception reference
* add #include <cstring> to fix gcc build
* explicitly poulate KeyValueMap by traversing input spans fixes gcc compilation
* remove unreferenced variable
* eliminate redundant `std::move` which gcc complains about
* fix gcc compilation by including <cstring>
* tag unreferenced variable to fix gcc compilation
* fixes for various cases of naming members the same as their type

1 files changed, 1 insertions, 3 deletions

diff --git a/src/zenstore/buildstore/buildstore.cpp b/src/zenstore/buildstore/buildstore.cpp
index aa28d8900..99cf7f16e 100644
--- a/src/zenstore/buildstore/buildstore.cpp
+++ b/src/zenstore/buildstore/buildstore.cpp
@@ -231,7 +231,7 @@ BuildStore::PutBlob(const IoHash& BlobHash, const IoBuffer& Payload)
 	uint64_t			   PayloadSize = Payload.GetSize();
 	CidStore::InsertResult Result	   = m_BlobStore.AddChunk(Payload, BlobHash);
 	PayloadEntry		   Entry	   = PayloadEntry(0, PayloadSize);
-	;
+	ZEN_UNUSED(Result);
 
 	IoHash MetadataHash;
 	{
@@ -1095,8 +1095,6 @@ public:
 		ZEN_TRACE_CPU("Builds::UpdateLockedState");
 		ZEN_MEMSCOPE(GetBuildstoreTag());
 
-		auto Log = [&Ctx]() { return Ctx.Logger; };
-
 		ZEN_ASSERT(m_Store.m_TrackedBlobKeys);
 
 		m_AddedReferences = std::move(*m_Store.m_TrackedBlobKeys);