block destructors from throwing exceptions (#321)

* ~FileMapping() is not allowed to throw exceptions
* ~ScopedActivityBase() should not call ZEN_ASSERT (which causes SIGABORT on error)
* ProjectStore::Project::WriteAccessTimes() which is called from ProjectStore::~Project() must not throw exceptions
* changelog

1 files changed, 5 insertions, 5 deletions

diff --git a/src/zenserver/projectstore/projectstore.cpp b/src/zenserver/projectstore/projectstore.cpp
index 4b0c801bc..deae58508 100644
--- a/src/zenserver/projectstore/projectstore.cpp
+++ b/src/zenserver/projectstore/projectstore.cpp
@@ -1144,14 +1144,14 @@ ProjectStore::Project::WriteAccessTimes()
 
 	Writer.Save(Mem);
 
-	CreateDirectories(m_OplogStoragePath);
+	try
+	{
+		CreateDirectories(m_OplogStoragePath);
 
-	std::filesystem::path ProjectAccessTimesFilePath = m_OplogStoragePath / "AccessTimes.zcb"sv;
+		std::filesystem::path ProjectAccessTimesFilePath = m_OplogStoragePath / "AccessTimes.zcb"sv;
 
-	ZEN_INFO("persisting access times for project '{}' to {}", Identifier, ProjectAccessTimesFilePath);
+		ZEN_INFO("persisting access times for project '{}' to {}", Identifier, ProjectAccessTimesFilePath);
 
-	try
-	{
 		BasicFile Blob;
 		Blob.Open(ProjectAccessTimesFilePath, BasicFile::Mode::kTruncate);
 		Blob.Write(Mem.Data(), Mem.Size(), 0);