Various fixes to address issues flagged by gcc / non-UE toolchain build (#621)

* gcc: avoid using memset on nontrivial struct
* redundant `return std::move`
* fixed various compilation issues flagged by gcc
* fix issue in xmake.lua detecting whether we are building with the UE toolchain or not
* add GCC ignore -Wundef (comment is inaccurate)
* remove redundant std::move
* don't catch exceptions by value
* unreferenced variables
* initialize "by the book" instead of memset
* remove unused exception reference
* add #include <cstring> to fix gcc build
* explicitly poulate KeyValueMap by traversing input spans fixes gcc compilation
* remove unreferenced variable
* eliminate redundant `std::move` which gcc complains about
* fix gcc compilation by including <cstring>
* tag unreferenced variable to fix gcc compilation
* fixes for various cases of naming members the same as their type

1 files changed, 3 insertions, 3 deletions

diff --git a/src/zenremotestore/projectstore/buildsremoteprojectstore.cpp b/src/zenremotestore/projectstore/buildsremoteprojectstore.cpp
index 1d749a17d..09ffc5d71 100644
--- a/src/zenremotestore/projectstore/buildsremoteprojectstore.cpp
+++ b/src/zenremotestore/projectstore/buildsremoteprojectstore.cpp
@@ -579,9 +579,9 @@ private:
 
 	LoggerRef m_Log;
 
-	BuildStorage::Statistics	  m_BuildStorageStats;
-	HttpClient					  m_BuildStorageHttp;
-	std::unique_ptr<BuildStorage> m_BuildStorage;
+	BuildStorageBase::Statistics	  m_BuildStorageStats;
+	HttpClient						  m_BuildStorageHttp;
+	std::unique_ptr<BuildStorageBase> m_BuildStorage;
 
 	BuildStorageCache::Statistics	   m_StorageCacheStats;
 	std::unique_ptr<HttpClient>		   m_BuildCacheStorageHttp;