Various fixes to address issues flagged by gcc / non-UE toolchain build (#621)

* gcc: avoid using memset on nontrivial struct
* redundant `return std::move`
* fixed various compilation issues flagged by gcc
* fix issue in xmake.lua detecting whether we are building with the UE toolchain or not
* add GCC ignore -Wundef (comment is inaccurate)
* remove redundant std::move
* don't catch exceptions by value
* unreferenced variables
* initialize "by the book" instead of memset
* remove unused exception reference
* add #include <cstring> to fix gcc build
* explicitly poulate KeyValueMap by traversing input spans fixes gcc compilation
* remove unreferenced variable
* eliminate redundant `std::move` which gcc complains about
* fix gcc compilation by including <cstring>
* tag unreferenced variable to fix gcc compilation
* fixes for various cases of naming members the same as their type

1 files changed, 9 insertions, 9 deletions

diff --git a/src/zenremotestore/builds/jupiterbuildstorage.cpp b/src/zenremotestore/builds/jupiterbuildstorage.cpp
index 14a5ecc85..fe8067905 100644
--- a/src/zenremotestore/builds/jupiterbuildstorage.cpp
+++ b/src/zenremotestore/builds/jupiterbuildstorage.cpp
@@ -30,7 +30,7 @@ namespace {
 	}
 }  // namespace
 
-class JupiterBuildStorage : public BuildStorage
+class JupiterBuildStorage : public BuildStorageBase
 {
 public:
 	JupiterBuildStorage(LoggerRef					 InLog,
@@ -499,14 +499,14 @@ private:
 	const std::filesystem::path m_TempFolderPath;
 };
 
-std::unique_ptr<BuildStorage>
-CreateJupiterBuildStorage(LoggerRef					   InLog,
-						  HttpClient&				   InHttpClient,
-						  BuildStorage::Statistics&	   Stats,
-						  std::string_view			   Namespace,
-						  std::string_view			   Bucket,
-						  bool						   AllowRedirect,
-						  const std::filesystem::path& TempFolderPath)
+std::unique_ptr<BuildStorageBase>
+CreateJupiterBuildStorage(LoggerRef						InLog,
+						  HttpClient&					InHttpClient,
+						  BuildStorageBase::Statistics& Stats,
+						  std::string_view				Namespace,
+						  std::string_view				Bucket,
+						  bool							AllowRedirect,
+						  const std::filesystem::path&	TempFolderPath)
 {
 	ZEN_TRACE_CPU("CreateJupiterBuildStorage");