aboutsummaryrefslogtreecommitdiff
path: root/src/zenremotestore/builds/buildstorageoperations.cpp
diff options
context:
space:
mode:
authorDan Engelbrecht <[email protected]>2025-12-01 11:44:02 +0100
committerGitHub Enterprise <[email protected]>2025-12-01 11:44:02 +0100
commit1c24992131d2a7d8362272d1ec83382dddf45d54 (patch)
treec4eacee25ac72bd068b234b730e0b6d4093d89c0 /src/zenremotestore/builds/buildstorageoperations.cpp
parentfix crash when parsing empty key in httpstats service (#671) (diff)
downloadzen-1c24992131d2a7d8362272d1ec83382dddf45d54.tar.xz
zen-1c24992131d2a7d8362272d1ec83382dddf45d54.zip
use scope guards to secure that BasicFile::Detach is called even on exception (#672)
Diffstat (limited to 'src/zenremotestore/builds/buildstorageoperations.cpp')
-rw-r--r--src/zenremotestore/builds/buildstorageoperations.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/zenremotestore/builds/buildstorageoperations.cpp b/src/zenremotestore/builds/buildstorageoperations.cpp
index ba82c5956..8dd85d439 100644
--- a/src/zenremotestore/builds/buildstorageoperations.cpp
+++ b/src/zenremotestore/builds/buildstorageoperations.cpp
@@ -378,8 +378,8 @@ MakeBufferMemoryBased(const CompositeBuffer& PartialBlockBuffer)
{
BasicFile Reader;
Reader.Attach(FileRef.FileHandle);
+ auto _ = MakeGuard([&Reader]() { Reader.Detach(); });
Reader.Read(ReadMem.GetData(), FileRef.FileChunkSize, FileRef.FileChunkOffset);
- Reader.Detach();
ReadMem = ReadMem.Mid(FileRef.FileChunkSize);
}
else