HTTP range responses (RFC 7233) - httpobjectstore (#928)

- Improvement: HTTP range responses (RFC 7233) are now fully compliant across the object store and build store
  - 206 Partial Content responses now include a `Content-Range` header; previously absent for single-range requests, which broke `HttpClient::GetRanges()`
  - 416 Range Not Satisfiable responses now include `Content-Range: bytes */N` as required by RFC 7233
  - Out-of-bounds range requests return 416 Range Not Satisfiable (was 400 Bad Request)
  - Single-byte ranges (`bytes=N-N`) are now correctly accepted (were previously rejected)
  - Range byte positions widened from 32-bit to 64-bit; RFC 7233 imposes no size limit on byte range values
  - Build store binary GET requests with a Range header now return 206 Partial Content with `Content-Range` (previously returned 200 OK without it)

1 files changed, 29 insertions, 1 deletions

diff --git a/src/zenhttp/servers/httpsys.cpp b/src/zenhttp/servers/httpsys.cpp
index 1b722940d..d45804c50 100644
--- a/src/zenhttp/servers/httpsys.cpp
+++ b/src/zenhttp/servers/httpsys.cpp
@@ -464,6 +464,8 @@ public:
 	inline int64_t	GetResponseBodySize() const { return m_TotalDataSize; }
 
 	void SetLocationHeader(std::string_view Location) { m_LocationHeader = Location; }
+	void SetContentTypeOverride(std::string Override) { m_ContentTypeOverride = std::move(Override); }
+	void SetContentRangeHeader(std::string V) { m_ContentRangeHeader = std::move(V); }
 
 private:
 	eastl::fixed_vector<HTTP_DATA_CHUNK, 16> m_HttpDataChunks;
@@ -473,6 +475,8 @@ private:
 	uint32_t								 m_RemainingChunkCount = 0;	 // Backlog for multi-call sends
 	bool									 m_IsInitialResponse   = true;
 	HttpContentType							 m_ContentType		   = HttpContentType::kBinary;
+	std::string								 m_ContentTypeOverride;
+	std::string								 m_ContentRangeHeader;
 	eastl::fixed_vector<IoBuffer, 16>		 m_DataBuffers;
 	std::string								 m_LocationHeader;
 
@@ -725,7 +729,8 @@ HttpMessageResponseRequest::IssueRequest(std::error_code& ErrorCode)
 
 		PHTTP_KNOWN_HEADER ContentTypeHeader = &HttpResponse.Headers.KnownHeaders[HttpHeaderContentType];
 
-		std::string_view ContentTypeString = MapContentTypeToString(m_ContentType);
+		std::string_view ContentTypeString =
+			m_ContentTypeOverride.empty() ? MapContentTypeToString(m_ContentType) : std::string_view(m_ContentTypeOverride);
 
 		ContentTypeHeader->pRawValue	  = ContentTypeString.data();
 		ContentTypeHeader->RawValueLength = (USHORT)ContentTypeString.size();
@@ -739,6 +744,15 @@ HttpMessageResponseRequest::IssueRequest(std::error_code& ErrorCode)
 			LocationHeader->RawValueLength	  = (USHORT)m_LocationHeader.size();
 		}
 
+		// Content-Range header (for 206 Partial Content single-range responses)
+
+		if (!m_ContentRangeHeader.empty())
+		{
+			PHTTP_KNOWN_HEADER ContentRangeHeader = &HttpResponse.Headers.KnownHeaders[HttpHeaderContentRange];
+			ContentRangeHeader->pRawValue		  = m_ContentRangeHeader.data();
+			ContentRangeHeader->RawValueLength	  = (USHORT)m_ContentRangeHeader.size();
+		}
+
 		std::string_view ReasonString = ReasonStringForHttpResultCode(m_ResponseCode);
 
 		HttpResponse.StatusCode	  = m_ResponseCode;
@@ -2279,6 +2293,11 @@ HttpSysServerRequest::WriteResponse(HttpResponseCode ResponseCode)
 
 	HttpMessageResponseRequest* Response = new HttpMessageResponseRequest(m_HttpTx, (uint16_t)ResponseCode);
 
+	if (!m_ContentRangeHeader.empty())
+	{
+		Response->SetContentRangeHeader(std::move(m_ContentRangeHeader));
+	}
+
 	if (SuppressBody())
 	{
 		Response->SuppressResponseBody();
@@ -2307,6 +2326,15 @@ HttpSysServerRequest::WriteResponse(HttpResponseCode ResponseCode, HttpContentTy
 
 	HttpMessageResponseRequest* Response = new HttpMessageResponseRequest(m_HttpTx, (uint16_t)ResponseCode, ContentType, Blobs);
 
+	if (!m_ContentTypeOverride.empty())
+	{
+		Response->SetContentTypeOverride(std::move(m_ContentTypeOverride));
+	}
+	if (!m_ContentRangeHeader.empty())
+	{
+		Response->SetContentRangeHeader(std::move(m_ContentRangeHeader));
+	}
+
 	if (SuppressBody())
 	{
 		Response->SuppressResponseBody();