Various fixes to address issues flagged by gcc / non-UE toolchain build (#621)

* gcc: avoid using memset on nontrivial struct
* redundant `return std::move`
* fixed various compilation issues flagged by gcc
* fix issue in xmake.lua detecting whether we are building with the UE toolchain or not
* add GCC ignore -Wundef (comment is inaccurate)
* remove redundant std::move
* don't catch exceptions by value
* unreferenced variables
* initialize "by the book" instead of memset
* remove unused exception reference
* add #include <cstring> to fix gcc build
* explicitly poulate KeyValueMap by traversing input spans fixes gcc compilation
* remove unreferenced variable
* eliminate redundant `std::move` which gcc complains about
* fix gcc compilation by including <cstring>
* tag unreferenced variable to fix gcc compilation
* fixes for various cases of naming members the same as their type

1 files changed, 14 insertions, 2 deletions

diff --git a/src/zenhttp/include/zenhttp/httpclient.h b/src/zenhttp/include/zenhttp/httpclient.h
index b12bdefb8..4fec1ec3f 100644
--- a/src/zenhttp/include/zenhttp/httpclient.h
+++ b/src/zenhttp/include/zenhttp/httpclient.h
@@ -144,8 +144,20 @@ public:
 		: Entries({{{std::string(Entry.first), std::string(Entry.second)}}})
 		{
 		}
-		KeyValueMap(std::span<std::pair<std::string_view, std::string_view>>&& List) : Entries(List.begin(), List.end()) {}
-		KeyValueMap(std::initializer_list<std::pair<std::string_view, std::string_view>>&& List) : Entries(List.begin(), List.end()) {}
+		KeyValueMap(std::span<std::pair<std::string_view, std::string_view>>&& List)
+		{
+			for (const auto& kv : List)
+			{
+				Entries.emplace(std::string(kv.first), std::string(kv.second));
+			}
+		}
+		KeyValueMap(std::initializer_list<std::pair<std::string_view, std::string_view>>&& List)
+		{
+			for (const auto& kv : List)
+			{
+				Entries.emplace(std::string(kv.first), std::string(kv.second));
+			}
+		}
 	};
 
 	struct Response