diff options
| author | Stefan Boberg <[email protected]> | 2026-03-18 11:19:10 +0100 |
|---|---|---|
| committer | GitHub Enterprise <[email protected]> | 2026-03-18 11:19:10 +0100 |
| commit | eba410c4168e23d7908827eb34b7cf0c58a5dc48 (patch) | |
| tree | 3cda8e8f3f81941d3bb5b84a8155350c5bb2068c /src/zencore/testing.cpp | |
| parent | bugfix release - v5.7.23 (#851) (diff) | |
| download | zen-eba410c4168e23d7908827eb34b7cf0c58a5dc48.tar.xz zen-eba410c4168e23d7908827eb34b7cf0c58a5dc48.zip | |
Compute batching (#849)
### Compute Batch Submission
- Consolidate duplicated action submission logic in `httpcomputeservice` into a single `HandleSubmitAction` supporting both single-action and batch (actions array) payloads
- Group actions by queue in `RemoteHttpRunner` and submit as batches with configurable chunk size, falling back to individual submission on failure
- Extract shared helpers: `MakeErrorResult`, `ValidateQueueForEnqueue`, `ActivateActionInQueue`, `RemoveActionFromActiveMaps`
### Retracted Action State
- Add `Retracted` state to `RunnerAction` for retry-free rescheduling — an explicit request to pull an action back and reschedule it on a different runner without incrementing `RetryCount`
- Implement idempotent `RetractAction()` on `RunnerAction` and `ComputeServiceSession`
- Add `POST jobs/{lsn}/retract` and `queues/{queueref}/jobs/{lsn}/retract` HTTP endpoints
- Add state machine documentation and per-state comments to `RunnerAction`
### Compute Race Fixes
- Fix race in `HandleActionUpdates` where actions enqueued between session abandon and scheduler tick were never abandoned, causing `GetActionResult` to return 202 indefinitely
- Fix queue `ActiveCount` race where `NotifyQueueActionComplete` was called after releasing `m_ResultsLock`, allowing callers to observe stale counters immediately after `GetActionResult` returned OK
### Logging Optimization and ANSI improvements
- Improve `AnsiColorStdoutSink` write efficiency — single write call, dirty-flag flush, `RwLock` instead of `std::mutex`
- Move ANSI color emission from sink into formatters via `Formatter::SetColorEnabled()`; remove `ColorRangeStart`/`End` from `LogMessage`
- Extract color helpers (`AnsiColorForLevel`, `StripAnsiSgrSequences`) into `helpers.h`
- Strip upstream ANSI SGR escapes in non-color output mode. This enables colour in log messages without polluting log files with ANSI control sequences
- Move `RotatingFileSink`, `JsonFormatter`, and `FullFormatter` from header-only to pimpl with `.cpp` files
### CLI / Exec Refactoring
- Extract `ExecSessionRunner` class from ~920-line `ExecUsingSession` into focused methods and a `ExecSessionConfig` struct
- Replace monolithic `ExecCommand` with subcommand-based architecture (`http`, `inproc`, `beacon`, `dump`, `buildlog`)
- Allow parent options to appear after subcommand name by parsing subcommand args permissively and forwarding unmatched tokens to the parent parser
### Testing Improvements
- Fix `--test-suite` filter being ignored due to accumulation with default wildcard filter
- Add test suite banners to test listener output
- Made `function.session.abandon_pending` test more robust
### Startup / Reliability Fixes
- Fix silent exit when a second zenserver instance detects a port conflict — use `ZEN_CONSOLE_*` for log calls that precede `InitializeLogging()`
- Fix two potential SIGSEGV paths during early startup: guard `sentry_options_new()` returning nullptr, and throw on `ZenServerState::Register()` returning nullptr instead of dereferencing
- Fail on unrecognized zenserver `--mode` instead of silently defaulting to store
### Other
- Show host details (hostname, platform, CPU count, memory) when discovering new compute workers
- Move frontend `html.zip` from source tree into build directory
- Add format specifications for Compact Binary and Compressed Buffer wire formats
- Add `WriteCompactBinaryObject` to zencore
- Extended `ConsoleTui` with additional functionality
- Add `--vscode` option to `xmake sln` for clangd / `compile_commands.json` support
- Disable compute/horde/nomad in release builds (not yet production-ready)
- Disable unintended `ASIO_HAS_IO_URING` enablement
- Fix crashpad patch missing leading whitespace
- Clean up code triggering gcc false positives
Diffstat (limited to 'src/zencore/testing.cpp')
| -rw-r--r-- | src/zencore/testing.cpp | 50 |
1 files changed, 37 insertions, 13 deletions
diff --git a/src/zencore/testing.cpp b/src/zencore/testing.cpp index f5bc723b1..c6ee5ee6b 100644 --- a/src/zencore/testing.cpp +++ b/src/zencore/testing.cpp @@ -181,6 +181,15 @@ struct TestListener : public doctest::IReporter void test_case_start(const doctest::TestCaseData& in) override { Current = ∈ + + if (in.m_test_suite && in.m_test_suite != CurrentSuite) + { + CurrentSuite = in.m_test_suite; + ZEN_CONSOLE("{}==============================================================================={}", ColorYellow, ColorNone); + ZEN_CONSOLE("{} TEST_SUITE: {}{}", ColorYellow, CurrentSuite, ColorNone); + ZEN_CONSOLE("{}==============================================================================={}", ColorYellow, ColorNone); + } + ZEN_CONSOLE("{}======== TEST_CASE: {:<50} ========{}", ColorYellow, Current->m_name, ColorNone); } @@ -217,8 +226,9 @@ struct TestListener : public doctest::IReporter void test_case_skipped(const doctest::TestCaseData& /*in*/) override {} - const doctest::TestCaseData* Current = nullptr; - std::chrono::steady_clock::time_point RunStart = {}; + const doctest::TestCaseData* Current = nullptr; + std::string_view CurrentSuite = {}; + std::chrono::steady_clock::time_point RunStart = {}; struct FailedTestInfo { @@ -244,15 +254,29 @@ TestRunner::~TestRunner() { } -void -TestRunner::SetDefaultSuiteFilter(const char* Pattern) -{ - m_Impl->Session.setOption("test-suite", Pattern); -} - int -TestRunner::ApplyCommandLine(int Argc, char const* const* Argv) +TestRunner::ApplyCommandLine(int Argc, char const* const* Argv, const char* DefaultSuiteFilter) { + // Apply the default suite filter only when the command line doesn't provide + // an explicit --test-suite / --ts override. + if (DefaultSuiteFilter) + { + bool HasExplicitSuiteFilter = false; + for (int i = 1; i < Argc; ++i) + { + std::string_view Arg = Argv[i]; + if (Arg.starts_with("--test-suite=") || Arg.starts_with("--ts=") || Arg.starts_with("-test-suite=") || Arg.starts_with("-ts=")) + { + HasExplicitSuiteFilter = true; + break; + } + } + if (!HasExplicitSuiteFilter) + { + m_Impl->Session.setOption("test-suite", DefaultSuiteFilter); + } + } + m_Impl->Session.applyCommandLine(Argc, Argv); for (int i = 1; i < Argc; ++i) @@ -316,6 +340,7 @@ RunTestMain(int Argc, char* Argv[], const char* ExecutableName, void (*ForceLink TestRunner Runner; // Derive default suite filter from ExecutableName: "zencore-test" -> "core.*" + std::string DefaultSuiteFilter; if (ExecutableName) { std::string_view Name = ExecutableName; @@ -329,13 +354,12 @@ RunTestMain(int Argc, char* Argv[], const char* ExecutableName, void (*ForceLink } if (!Name.empty()) { - std::string Filter(Name); - Filter += ".*"; - Runner.SetDefaultSuiteFilter(Filter.c_str()); + DefaultSuiteFilter = Name; + DefaultSuiteFilter += ".*"; } } - Runner.ApplyCommandLine(Argc, Argv); + Runner.ApplyCommandLine(Argc, Argv, DefaultSuiteFilter.empty() ? nullptr : DefaultSuiteFilter.c_str()); return Runner.Run(); } |