Claude config, some bug fixes (#813)

* Claude config updates
* Bug fixes and hardening across `zencore` and `zenhttp`, identified via static analysis.

### zencore

- **`ZEN_ASSERT` macro** -- extended to accept an optional string message literal; added `ZEN_ASSERT_MSG_` helper for message formatting. Callers needing runtime fmt-style formatting should use `ZEN_ASSERT_FORMAT`.
- **`MpscQueue`** -- fixed `TypeCompatibleStorage` to use a properly-sized `char Storage[sizeof(T)]` array instead of a single `char`; corrected `Data()` to cast `&Storage` rather than `this`; switched cache-line alignment to a fixed constant to avoid GCC's `-Winterference-size` warning. Enabled previously-disabled tests.
- **`StringBuilderImpl`** -- initialized `m_Base`/`m_CurPos`/`m_End` to `nullptr`. Fixed `StringCompare` return type (`bool` -> `int`). Fixed `ParseInt` to reject strings with trailing non-numeric characters. Removed deprecated `<codecvt>` include.
- **`NiceNumGeneral`** -- replaced `powl()` with integer `IntPow()` to avoid floating-point precision issues.
- **`RwLock::ExclusiveLockScope`** -- added move constructor/assignment; initialized `m_Lock` to `nullptr`.
- **`Latch::AddCount`** -- fixed variable type (`std::atomic_ptrdiff_t` -> `std::ptrdiff_t` for the return value of `fetch_add`).
- **`thread.cpp`** -- fixed Linux `pthread_setname_np` 16-byte name truncation; added null check before dereferencing in `Event::Close()`; fixed `NamedEvent::Close()` to call `close(Fd)` outside the lock region; added null guard in `NamedMutex` destructor; `Sleep()` now returns early for non-positive durations.
- **`MD5Stream`** -- was entirely stubbed out (no-op); now correctly calls `MD5Init`/`MD5Update`/`MD5Final`. Fixed `ToHexString` to use the correct string length. Fixed forward declarations. Fixed tests to compare `compare() == 0`.
- **`sentryintegration.cpp`** -- guard against null `filename`/`funcname` in spdlog message handler to prevent a crash in `fmt::format`.
- **`jobqueue.cpp`** -- fixed lost job ID when `IdGenerator` wraps around zero; fixed raw `Job*` in `RunningJobs` map (potential use-after-free) to `RefPtr<Job>`; fixed range-loop copies; fixed format string typo.
- **`trace.cpp`** -- suppress GCC false-positive warnings in third-party `trace.h` include.

### zenhttp

- **WebSocket close race** (`wsasio`, `wshttpsys`, `httpwsclient`) -- `m_CloseSent` promoted from `bool` to `std::atomic<bool>`; close check changed to `exchange(true)` to eliminate the check-then-set data race.
- **`wsframecodec.cpp`** -- reject WebSocket frames with payload > 256 MB to prevent OOM from malformed/malicious frames.
- **`oidc.cpp`** -- URL-encode refresh token and client ID in token requests (`FormUrlEncode`); parse `end_session_endpoint` and `device_authorization_endpoint` from OIDC discovery document.
- **`httpclientcommon.cpp`** -- propagate error code from `AppendData` when flushing the cache buffer.
- **`httpclient.h`** -- initialize all uninitialized members (`ErrorCode`, `UploadedBytes`, `DownloadedBytes`, `ElapsedSeconds`, `MultipartBoundary` fields).
- **`httpserver.h`** -- fix `operator=` return type for `HttpRpcHandler` (missing `&`).
- **`packageformat.h`** -- fix `~0u` (32-bit truncation) to `~uint64_t(0)` for a `uint64_t` field.
- **`httpparser`** -- initialize `m_RequestVerb` in both declaration and `ResetState()`.
- **`httpplugin.cpp`** -- initialize `m_BasePort`; fix format string missing quotes around connection name.
- **`httptracer.h`** -- move `#pragma once` before includes.
- **`websocket.h`** -- initialize `WebSocketMessage::Opcode`.

### zenserver

- **`hubservice.cpp`** -- fix two `ZEN_ASSERT` calls that incorrectly used fmt-style format args; converted to `ZEN_ASSERT_FORMAT`.

1 files changed, 8 insertions, 12 deletions

diff --git a/src/zencore/jobqueue.cpp b/src/zencore/jobqueue.cpp
index 35724b07a..d6a8a6479 100644
--- a/src/zencore/jobqueue.cpp
+++ b/src/zencore/jobqueue.cpp
@@ -90,7 +90,7 @@ public:
 		uint64_t NewJobId = IdGenerator.fetch_add(1);
 		if (NewJobId == 0)
 		{
-			IdGenerator.fetch_add(1);
+			NewJobId = IdGenerator.fetch_add(1);
 		}
 		RefPtr<Job> NewJob(new Job());
 		NewJob->Queue		   = this;
@@ -129,7 +129,7 @@ public:
 					QueuedJobs.erase(It);
 				}
 			});
-			ZEN_ERROR("Failed to schedule job {}:'{}' to job queue. Reason: ''", NewJob->Id.Id, NewJob->Name, Ex.what());
+			ZEN_ERROR("Failed to schedule job {}:'{}' to job queue. Reason: '{}'", NewJob->Id.Id, NewJob->Name, Ex.what());
 			throw;
 		}
 	}
@@ -221,11 +221,11 @@ public:
 
 		std::vector<JobInfo> Jobs;
 		QueueLock.WithSharedLock([&]() {
-			for (auto It : RunningJobs)
+			for (const auto& It : RunningJobs)
 			{
 				Jobs.push_back({.Id = JobId{It.first}, .Status = JobStatus::Running});
 			}
-			for (auto It : CompletedJobs)
+			for (const auto& It : CompletedJobs)
 			{
 				if (IsStale(It.second->EndTick))
 				{
@@ -234,7 +234,7 @@ public:
 				}
 				Jobs.push_back({.Id = JobId{It.first}, .Status = JobStatus::Completed});
 			}
-			for (auto It : AbortedJobs)
+			for (const auto& It : AbortedJobs)
 			{
 				if (IsStale(It.second->EndTick))
 				{
@@ -243,7 +243,7 @@ public:
 				}
 				Jobs.push_back({.Id = JobId{It.first}, .Status = JobStatus::Aborted});
 			}
-			for (auto It : QueuedJobs)
+			for (const auto& It : QueuedJobs)
 			{
 				Jobs.push_back({.Id = It->Id, .Status = JobStatus::Queued});
 			}
@@ -337,7 +337,7 @@ public:
 	std::atomic_bool						  InitializedFlag = false;
 	RwLock									  QueueLock;
 	std::deque<RefPtr<Job>>					  QueuedJobs;
-	std::unordered_map<uint64_t, Job*>		  RunningJobs;
+	std::unordered_map<uint64_t, RefPtr<Job>> RunningJobs;
 	std::unordered_map<uint64_t, RefPtr<Job>> CompletedJobs;
 	std::unordered_map<uint64_t, RefPtr<Job>> AbortedJobs;
 
@@ -429,20 +429,16 @@ JobQueue::ToString(JobStatus Status)
 	{
 		case JobQueue::JobStatus::Queued:
 			return "Queued"sv;
-			break;
 		case JobQueue::JobStatus::Running:
 			return "Running"sv;
-			break;
 		case JobQueue::JobStatus::Aborted:
 			return "Aborted"sv;
-			break;
 		case JobQueue::JobStatus::Completed:
 			return "Completed"sv;
-			break;
 		default:
 			ZEN_ASSERT(false);
+			return ""sv;
 	}
-	return ""sv;
 }
 
 std::unique_ptr<JobQueue>