aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Engelbrecht <[email protected]>2023-12-13 17:36:35 -0500
committerGitHub <[email protected]>2023-12-13 23:36:35 +0100
commit8e4100aaa4e247270c956af286e62d4bc1b01a18 (patch)
treed2b1193fb9740383ed0f030cc498068b03daa9cb
parent0.2.37-pre0 (diff)
downloadzen-8e4100aaa4e247270c956af286e62d4bc1b01a18.tar.xz
zen-8e4100aaa4e247270c956af286e62d4bc1b01a18.zip
Don't use copy of Payloads array when fetching memcached payload in GC (#609)
* Don't use copy of Payloads array when fetching memcached payload in GC
-rw-r--r--CHANGELOG.md1
-rw-r--r--src/zenserver/cache/cachedisklayer.cpp2
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8d92a12b5..b010ff6d1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
- Bugfix: Reorder shutdown to avoid crash due to late async log messages (spdlog workaround)
- Bugfix: Correctly calculate peak disk write size in GC status message
- Bugfix: Skip invalid chunks in block store GC when moving existing chunks
+- Bugfix: Don't use copy of Payloads array when fetching memcached payload in GC
- Improvement: Adjusted and added some trace scopes
## 0.2.36
diff --git a/src/zenserver/cache/cachedisklayer.cpp b/src/zenserver/cache/cachedisklayer.cpp
index f1aab6093..fc6adb989 100644
--- a/src/zenserver/cache/cachedisklayer.cpp
+++ b/src/zenserver/cache/cachedisklayer.cpp
@@ -2025,7 +2025,7 @@ ZenCacheDiskLayer::CacheBucket::GatherReferences(GcContext& GcCtx)
#endif // CALCULATE_BLOCKING_TIME
if (auto It = m_Index.find(Key); It != m_Index.end())
{
- const BucketPayload& CachedPayload = Payloads[It->second];
+ const BucketPayload& CachedPayload = m_Payloads[It->second];
if (CachedPayload.MemCached)
{
Buffer = m_MemCachedPayloads[CachedPayload.MemCached].Payload;