refactor zen command return value handling (#487)

- Improvement: Use consistent language for command line argument parsing errors
- Improvement: Changed zen command parsing errors to output help first and error last to make it easier to spot the error
- Improvement: Refactor zen command return codes to conform to valid Linux range (0-255)

        kSuccess     = 0,
        kOtherError  = 1,
        kBadInput    = 2,

        kOutOfMemory = 16,
        kOutOfDisk   = 17,

        kAssertError = 70,
        
        kHttpOtherClientError = 80,
        kHttpCantConnectError = 81,
        kHttpNotFound         = 66,  // NotFound(404)
        kHttpUnauthorized     = 77,  // Unauthorized(401),
        kHttpSLLError         = 82,
        kHttpForbidden        = 83,  // Forbidden(403)
        kHttpTimeout          = 84,  // RequestTimeout(408)
        kHttpConflict         = 85,  // Conflict(409)
        kHttpNoHost           = 86,
        
        kHttpOtherServerError	   = 90,
        kHttpInternalServerError = 91,  // InternalServerError(500)
        kHttpServiceUnavailable  = 69,  // ServiceUnavailable(503)
        kHttpBadGateway          = 92,  // BadGateway(502)
        kHttpGatewayTimeout      = 93,  // GatewayTimeout(504)

1 files changed, 9 insertions, 9 deletions

diff --git a/src/zen/cmds/version_cmd.cpp b/src/zen/cmds/version_cmd.cpp
index 1be02331d..979278e6c 100644
--- a/src/zen/cmds/version_cmd.cpp
+++ b/src/zen/cmds/version_cmd.cpp
@@ -32,13 +32,13 @@ VersionCommand::VersionCommand()
 
 VersionCommand::~VersionCommand() = default;
 
-int
+void
 VersionCommand::Run(const ZenCliOptions& GlobalOptions, int argc, char** argv)
 {
 	ZEN_UNUSED(GlobalOptions);
 	if (!ParseOptions(argc, argv))
 	{
-		return 0;
+		return;
 	}
 
 	std::string Version;
@@ -69,13 +69,14 @@ VersionCommand::Run(const ZenCliOptions& GlobalOptions, int argc, char** argv)
 			Parameters.Entries.insert_or_assign("detailed", "true");
 		}
 		const std::string_view VersionRequest("/health/version"sv);
-		HttpClient::Response   Response = Client.Get(VersionRequest, {}, Parameters);
-		if (!Response.IsSuccess())
+		if (HttpClient::Response Response = Client.Get(VersionRequest, {}, Parameters))
 		{
-			ZEN_CONSOLE_ERROR("{} failed: {}", VersionRequest, Response.ErrorMessage(""sv));
-			return 1;
+			Version = Response.AsText();
+		}
+		else
+		{
+			Response.ThrowError(fmt::format("{} failed", VersionRequest));
 		}
-		Version = Response.AsText();
 	}
 
 	if (m_OutputPath.empty())
@@ -90,7 +91,6 @@ VersionCommand::Run(const ZenCliOptions& GlobalOptions, int argc, char** argv)
 		OutputFile.Write(Version.data(), Version.length(), 0);
 		OutputFile.Close();
 	}
-
-	return 0;
 }
+
 }  // namespace zen