From 7d14daf1d5fce4d09471a3abe2aca49cf7680816 Mon Sep 17 00:00:00 2001
From: a1xd <68629610+a1xd@users.noreply.github.com>
Date: Wed, 2 Dec 2020 05:25:19 -0500
Subject: embed version info into assemblies

check app versions against lib, lib against driver

add an 'about' dialog which displays version details, accessible from menu

refactor error handling + add check for negative offset
---
 grapher/Models/Serialized/SettingsManager.cs | 29 ----------------------------
 1 file changed, 29 deletions(-)

(limited to 'grapher/Models/Serialized')

diff --git a/grapher/Models/Serialized/SettingsManager.cs b/grapher/Models/Serialized/SettingsManager.cs
index f13ba81..f5bb1f1 100644
--- a/grapher/Models/Serialized/SettingsManager.cs
+++ b/grapher/Models/Serialized/SettingsManager.cs
@@ -47,35 +47,6 @@ namespace grapher.Models.Serialized
         #endregion Properties
 
         #region Methods
-
-        public static string ErrorStringFrom(SettingsErrors errors)
-        {
-            StringBuilder builder = new StringBuilder();
-            bool yPresent = errors.y?.Count > 0;
-
-            if (yPresent)
-            {
-                builder.AppendLine("\nx:");
-            }
-
-            foreach (var error in errors.x)
-            {
-                builder.AppendLine(error);
-            }
-
-            if (yPresent)
-            {
-                builder.AppendLine("\ny:");
-
-                foreach (var error in errors.y)
-                {
-                    builder.AppendLine(error);
-                }
-            }
-
-            return builder.ToString();
-        }
-
         public SettingsErrors TryUpdateActiveSettings(DriverSettings settings)
         {
             var errors = TryUpdateAccel(settings);
-- 
cgit v1.2.3


From 5657d5a54c0a8e980c9b0cac39e2d16e452f302e Mon Sep 17 00:00:00 2001
From: a1xd <68629610+a1xd@users.noreply.github.com>
Date: Thu, 3 Dec 2020 20:00:31 -0500
Subject: add directional multipliers

adds multipliers for movement in negative directions (up & left by default, can be flipped by rot or sens)

avoid division by user input in mousewatcher
---
 grapher/Models/Serialized/RawAccelSettings.cs | 2 ++
 grapher/Models/Serialized/SettingsManager.cs  | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

(limited to 'grapher/Models/Serialized')

diff --git a/grapher/Models/Serialized/RawAccelSettings.cs b/grapher/Models/Serialized/RawAccelSettings.cs
index af87a65..67953ac 100644
--- a/grapher/Models/Serialized/RawAccelSettings.cs
+++ b/grapher/Models/Serialized/RawAccelSettings.cs
@@ -127,6 +127,8 @@ namespace grapher.Models.Serialized
 
             return accelSettings.sensitivity.x == 1 &&
                 accelSettings.sensitivity.y == 1 &&
+                accelSettings.negativeMultipliers.x <= 0 &&
+                accelSettings.negativeMultipliers.y <= 0 &&
                 accelSettings.rotation == 0 &&
                 accelSettings.modes.x == AccelMode.noaccel &&
                 wholeOrNoY;
diff --git a/grapher/Models/Serialized/SettingsManager.cs b/grapher/Models/Serialized/SettingsManager.cs
index f5bb1f1..41ebcb5 100644
--- a/grapher/Models/Serialized/SettingsManager.cs
+++ b/grapher/Models/Serialized/SettingsManager.cs
@@ -34,9 +34,9 @@ namespace grapher.Models.Serialized
 
         public RawAccelSettings RawAccelSettings { get; private set; }
 
-        private Field DpiField { get; set; }
+        public Field DpiField { get; private set; }
 
-        private Field PollRateField { get; set; }
+        public Field PollRateField { get; private set; }
 
         private ToolStripMenuItem AutoWriteMenuItem { get; set; }
 
-- 
cgit v1.2.3


From c221eb3d62ccbd7f2a5203abd3e0eae8e9bf31e8 Mon Sep 17 00:00:00 2001
From: a1xd <68629610+a1xd@users.noreply.github.com>
Date: Thu, 3 Dec 2020 22:42:29 -0500
Subject: add changes from review

rename some vars
prefer exceptions over assert
refactor poll rate field usage in MouseWatcher
---
 grapher/Models/Serialized/RawAccelSettings.cs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'grapher/Models/Serialized')

diff --git a/grapher/Models/Serialized/RawAccelSettings.cs b/grapher/Models/Serialized/RawAccelSettings.cs
index 67953ac..dcaf864 100644
--- a/grapher/Models/Serialized/RawAccelSettings.cs
+++ b/grapher/Models/Serialized/RawAccelSettings.cs
@@ -127,8 +127,8 @@ namespace grapher.Models.Serialized
 
             return accelSettings.sensitivity.x == 1 &&
                 accelSettings.sensitivity.y == 1 &&
-                accelSettings.negativeMultipliers.x <= 0 &&
-                accelSettings.negativeMultipliers.y <= 0 &&
+                accelSettings.directionalMultipliers.x <= 0 &&
+                accelSettings.directionalMultipliers.y <= 0 &&
                 accelSettings.rotation == 0 &&
                 accelSettings.modes.x == AccelMode.noaccel &&
                 wholeOrNoY;
-- 
cgit v1.2.3