aboutsummaryrefslogtreecommitdiff
path: root/discord/client.py
diff options
context:
space:
mode:
authorRapptz <[email protected]>2015-11-20 17:39:19 -0500
committerRapptz <[email protected]>2015-11-20 17:39:51 -0500
commit5ca04ea08f3d64d4e2bfb1b86c7a8a01b2480f87 (patch)
tree80501a19e4320067c808ab8d5c3a6ccc824461f8 /discord/client.py
parentAllow sending raw file objects in memory with client.send_raw_file (diff)
downloaddiscord.py-5ca04ea08f3d64d4e2bfb1b86c7a8a01b2480f87.tar.xz
discord.py-5ca04ea08f3d64d4e2bfb1b86c7a8a01b2480f87.zip
Use try-except instead of checking for membership.
Basically, a lot of the checks revolving "if x in y" could be written more efficiently by doing the task anyway and ignoring the exception a la the EAFP guideline.
Diffstat (limited to 'discord/client.py')
-rw-r--r--discord/client.py10
1 files changed, 8 insertions, 2 deletions
diff --git a/discord/client.py b/discord/client.py
index 12bc6766..9d1ae27c 100644
--- a/discord/client.py
+++ b/discord/client.py
@@ -311,8 +311,11 @@ class ConnectionState(object):
if server is not None:
user_id = data['user']['id']
member = utils.find(lambda m: m.id == user_id, server.members)
- if member in server.members:
+ try:
server.members.remove(member)
+ except ValueError:
+ return
+ else:
self.dispatch('member_remove', member)
def handle_guild_member_update(self, data):
@@ -364,8 +367,11 @@ class ConnectionState(object):
self.dispatch('server_unavailable', server)
return
- if server in self.servers:
+ try:
self.servers.remove(server)
+ except ValueError:
+ return
+ else:
self.dispatch('server_remove', server)
def handle_guild_role_create(self, data):