From f34c8c466a0e514edac2e8683127b4176ad5d321 Mon Sep 17 00:00:00 2001 From: practicalswift Date: Mon, 18 Jun 2018 07:58:28 +0200 Subject: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. --- src/validation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/validation.cpp') diff --git a/src/validation.cpp b/src/validation.cpp index 3e51221a5..2f966d2f5 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -421,7 +421,7 @@ bool CheckSequenceLocks(const CTransaction &tx, int flags, LockPoints* lp, bool // lock on a mempool input, so we can use the return value of // CheckSequenceLocks to indicate the LockPoints validity int maxInputHeight = 0; - for (int height : prevheights) { + for (const int height : prevheights) { // Can ignore mempool inputs since we'll fail if they had non-zero locks if (height != tip->nHeight+1) { maxInputHeight = std::max(maxInputHeight, height); @@ -4291,7 +4291,7 @@ void UnloadBlockIndex() warningcache[b].clear(); } - for (BlockMap::value_type& entry : mapBlockIndex) { + for (const BlockMap::value_type& entry : mapBlockIndex) { delete entry.second; } mapBlockIndex.clear(); @@ -4492,7 +4492,7 @@ void CChainState::CheckBlockIndex(const Consensus::Params& consensusParams) // Build forward-pointing map of the entire block tree. std::multimap forward; - for (auto& entry : mapBlockIndex) { + for (const std::pair& entry : mapBlockIndex) { forward.insert(std::make_pair(entry.second->pprev, entry.second)); } -- cgit v1.2.3