From b7b9f6e4cee262004643e2fe03d56cb47fdbf5c2 Mon Sep 17 00:00:00 2001 From: Antoine Riard Date: Tue, 30 Jul 2019 18:08:03 -0400 Subject: Remove p2pEnabled from Chain interface RPC server starts in warmup mode, it can't process yet calls, then follows connection manager initialization and finally RPC server get out of warmup mode. RPC calls shouldn't be able to get P2P disabled errors because once we initialize g_connman it's not unset until shutdown, after RPC server has been stopped. --- src/node/transaction.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/node/transaction.cpp') diff --git a/src/node/transaction.cpp b/src/node/transaction.cpp index 8e5649635..a28136a8e 100644 --- a/src/node/transaction.cpp +++ b/src/node/transaction.cpp @@ -16,6 +16,9 @@ TransactionError BroadcastTransaction(const CTransactionRef tx, std::string& err_string, const CAmount& max_tx_fee, bool relay, bool wait_callback) { + // BroadcastTransaction can be called by either sendrawtransaction RPC or wallet RPCs. + // g_connman is assigned both before chain clients and before RPC server is accepting calls, + // and reset after chain clients and RPC sever are stopped. g_connman should never be null here. assert(g_connman); std::promise promise; uint256 hashTx = tx->GetHash(); -- cgit v1.2.3