From faab55fbb17f2ea5080bf02bc59eeef5ca746f07 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Fri, 4 May 2018 17:38:49 -0400 Subject: Make CMutableTransaction constructor explicit Silently converting to a CMutableTransaction will drop all caches and should thus be done explicitly --- src/bitcoin-tx.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/bitcoin-tx.cpp') diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp index 07ad09ea7..5ece6c405 100644 --- a/src/bitcoin-tx.cpp +++ b/src/bitcoin-tx.cpp @@ -548,7 +548,7 @@ static void MutateTxSign(CMutableTransaction& tx, const std::string& flagStr) // mergedTx will end up with all the signatures; it // starts as a clone of the raw tx: CMutableTransaction mergedTx{tx}; - const CTransaction txv{tx}; + const CMutableTransaction txv{tx}; CCoinsView viewDummy; CCoinsViewCache view(&viewDummy); -- cgit v1.2.3