From a0fc0764763329df2c4b11a4e22715ccfc0cf7d3 Mon Sep 17 00:00:00 2001 From: Sebastian Falbesoner Date: Fri, 18 Oct 2019 02:05:05 +0200 Subject: refactor: test/bench: dedup Build{Crediting,Spending}Transaction() prototypes used in src/test/script_tests.cpp: - CMutableTransaction BuildCreditingTransaction(const CScript& scriptPubKey, int nValue = 0); - CMutableTransaction BuildSpendingTransaction(const CScript& scriptSig, const CScriptWitness& scriptWitness, const CTransaction& txCredit); prototypes used in bench/verify_script.cpp: - CMutableTransaction BuildCreditingTransaction(const CScript& scriptPubKey); - CMutableTransaction BuildSpendingTransaction(const CScript& scriptSig, const CMutableTransaction& txCredit); The more generic versions from the script tests are moved into a new file pair transaction_utils.cpp/h and the calls are adapted accordingly in the verify_script benchmark (passing the nValue of 1 explicitely for BuildCreditingTransaction(), passing empty scriptWitness explicitely and converting txCredit parameter to CTransaction in BuildSpendingTransaction()). --- src/Makefile.test.include | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/Makefile.test.include') diff --git a/src/Makefile.test.include b/src/Makefile.test.include index 7292ca078..3af55d9da 100644 --- a/src/Makefile.test.include +++ b/src/Makefile.test.include @@ -53,6 +53,8 @@ RAW_TEST_FILES = GENERATED_TEST_FILES = $(JSON_TEST_FILES:.json=.json.h) $(RAW_TEST_FILES:.raw=.raw.h) BITCOIN_TEST_SUITE = \ + test/lib/transaction_utils.h \ + test/lib/transaction_utils.cpp \ test/main.cpp \ test/setup_common.h \ test/setup_common.cpp -- cgit v1.2.3