aboutsummaryrefslogtreecommitdiff
path: root/test
Commit message (Collapse)AuthorAgeFilesLines
* Test that joinpsbts randomly shuffles the inputsAndrew Chow2019-09-241-0/+10
| | | | | Github-Pull: #16512 Rebased-From: c0b5d9710322a614a50ab5da081558cf6a38ad2a
* Bugfix: QA: Run tests with UPnP disabledLuke Dashjr2019-09-241-0/+1
| | | | | | | Needed for builds configured with --enable-upnp-default Github-Pull: #16646 Rebased-From: b168dd30cf71ac176e271bc610b0b1a79ceaf075
* util: No translation of `Bitcoin Core` in the copyrightMarcoFalke2019-09-241-2/+1
| | | | | Github-Pull: #16291 Rebased-From: fa64b947bb3075ff8737656706b941af691908ab
* 0.18: test: Add test for maxtxfee optionMarcoFalke2019-08-251-0/+39
| | | | | Github-Pull: #16322 Rebased-From: 0d101a340c44841cbbc5982d55354b1787bc39e2
* 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransactionJoão Barbosa2019-08-252-1/+11
| | | | | Github-Pull: #16322 Rebased-From: 5c1b9714cb0a13be28324f91f4ec9ca66a1de8c7
* 0.18: [wallet] abort when attempting to fund a transaction above maxtxfeeSjors Provoost2019-08-252-0/+10
| | | | | | | FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior. Github-Pull: #16257 Rebased-From: 806b0052c3b45415862f74f20ba5f389e5b673de
* [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0Sjors Provoost2019-08-171-3/+10
|
* [rpc] walletcreatefundedpsbt: use wallet default RBFSjors Provoost2019-08-171-7/+12
|
* signrawtransactionwithkey: report error when missing ↵Anthony Towns2019-07-051-0/+5
| | | | | | | redeemScript/witnessScript param Github-Pull: #16250 Rebased-From: 01174596e69568c434198a86f54cb9ea6740e6c2
* Add comments to Python ECDSA implementationJohn Newbery2019-06-261-16/+56
| | | | | Github-Pull: #15826 Rebased-From: b67978529ad02fc2665f2362418dc53db2e25e17
* Make and get the multisig redeemscript and destination in one function ↵Andrew Chow2019-06-211-1/+29
| | | | | | | | | | | | | | | | | | | | instead of two Instead of creating a redeemScript with CreateMultisigRedeemscript and then getting the destination with AddAndGetDestinationForScript, do both in the same function. CreateMultisigRedeemscript is changed to AddAndGetMultisigDestination. It creates the redeemScript and returns it via an output parameter. Then it calls AddAndGetDestinationForScript to add the destination to the keystore and get the proper destination. This allows us to inspect the public keys in the redeemScript before creating the destination so that the correct destination is used when uncompressed pubkeys are in the multisig. Github-Pull: #16026 Rebased-From: a49503402b6bc21e3878e151c07529941d36aed0
* Pure python ECPieter Wuille2019-06-215-227/+346
| | | | | | | | This removes the dependency on OpenSSL for the interaction tests, by providing a pure-Python toy implementation of secp256k1. Github-Pull: #15826 Rebased-From: 8c7b9324ca3f3ffb178bea56a96ea23f7e0383cb
* test: Add test that addmultisigaddress fails for watchonly addressesMarcoFalke2019-06-211-1/+15
| | | | | Github-Pull: #15831 Rebased-From: fab6a0a659bb856e4598af3e0679fc37d5239478
* test: Fixup creatmultisig documentation and whitespaceMarcoFalke2019-06-211-14/+16
| | | | | Github-Pull: #15831 Rebased-From: fad81d870aa6dd25d4fab5faad4c956ba364734a
* Replace remaining fprintf with tfm::format manuallyMarcoFalke2019-06-182-4/+3
| | | | | Github-Pull: #16205 Rebased-From: fa8f195195945ce6258199af0461e3fbfbc1236d
* rpc: bugfix: Properly use iswitness in converttopsbtMarcoFalke2019-06-181-2/+3
| | | | | | | Also explain the param in all RPCs Github-Pull: #15899 Rebased-From: fa499b5f027f77c0bf13699852c8c06f78e27bef
* Bugfix: test/functional/rpc_psbt: Correct test description commentLuke Dashjr2019-06-181-1/+1
| | | | | Github-Pull: #14818 Rebased-From: c87fc71f7e9316bcc0653cd86c50177424b5b1f9
* Bugfix: test/functional/rpc_psbt: Remove check for specific error message ↵Luke Dashjr2019-06-181-2/+3
| | | | | | | | | | | that depends on uncertain assumptions When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise. Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used. The error code is still checked to ensure it is of the correct kind of failure. Github-Pull: #14818 Rebased-From: 097c4aa379f255639ce0084702693fa72a595d6b
* fixup: Fix prunning testJoão Barbosa2019-06-141-17/+4
| | | | | Github-Pull: #15991 Rebased-From: f402012ccfc596d7d94851dabbf386c278ff5335
* Disallow extended encoding for non-witness transactions (take 3)MarcoFalke2019-05-201-3/+23
| | | | | Github-Pull: #16021 Rebased-From: fa2b52af32f6a4b9c22c270f36e92960c29ef364
* Add test for superfluous witness record in deserializationGregory Sanders2019-05-201-0/+29
| | | | | Github-Pull: #15893 Rebased-From: cc556e4a30b4a32eab6722f590489d89b2875de3
* Fix missing input template by making minimal txGregory Sanders2019-05-202-15/+5
| | | | | Github-Pull: #15893 Rebased-From: 25b078658139c1aea58393a32ac5a79144d8d140
* test: Add test for p2p_blocksonlyMarcoFalke2019-05-163-0/+67
| | | | | Github-Pull: #15990 Rebased-From: fa320de79faaca2b088fcbe7f76701faa9bff236
* test: Format predicate source as multiline on errorMarcoFalke2019-05-161-1/+1
| | | | | Github-Pull: #15990 Rebased-From: fa3872e7b4540857261aed948b94b6b2bfdbc3d1
* Take non-importing keys into account for spendability warning in descriptor ↵Pieter Wuille2019-04-161-1/+2
| | | | | | | import Github-Pull: #15749 Rebased-From: b5d39877242504160a7f2c24c60c07a845d7a064
* qa: Check unconfirmed balance after loadwalletJoão Barbosa2019-04-011-0/+12
| | | | | Github-Pull: #15652 Rebased-From: 4bf1b1cefa9723bf2cfa8b1a938757abc99bb17b
* [tests] Add test for wallet rebroadcastsJohn Newbery2019-04-011-12/+51
| | | | | | | | | | | | | The existing wallet_resendwallettransactions.py test only tests the resendwallettransactions RPC. It does not test whether transactions are actually rebroadcast, or whether the rebroadcast logic is called on a timer. This commit updates the test to not use the resendwallettransactions RPC and test that transactions are rebroadcast on a timer. Github-Pull: #15646 Rebased-From: 529c1ae4a04248a46a8b4a5a63ecbb12a63ff50e
* rpc: return a number for estimated_feerate in analyzepsbtfanquake2019-03-131-1/+1
| | | | | | Github-Pull: #15559 Rebased-From: 335931df4a37467299a2ee0ba521ecd5c4e6d39e Tree-SHA512: ebe460e935e33fbbbe725db403654ee65c86a606401e8519e1180551e2ccd43661eb4ad20bf065f2c0c2a8026c3bb3bce796789f8d612e9e197ceb8d541a63a9
* Merge #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfoMarcoFalke2019-03-013-6/+51
|\ | | | | | | | | | | | | | | | | | | | | | | | | f13ad1cae0 modify test for memory locked in case locking pages failed at some point (Adam Jonas) 2fa85ebd1c add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (Adam Jonas) Pull request description: Creating the `rpc_misc.py` functional test file to add space for adding tests to a file that doesn't have a lot of coverage. - Removing the `getmemoryinfo()` smoke test from wallet basic rather than moving it to keep the wallet decoupled. Feel like testing for reasonable memory allocation values should suffice. - Adding coverage for `mallocinfo()`. Introduced standard lib XML parser since the function exports an XML string that describes the current state of the memory-allocation implementation in the caller. Tree-SHA512: ced30115622916c88d1e729969ee331272ec9f2881eb36dee4bb7331bf633a6810a57fed63a0cfaf86de698edb5162e6a035efd07c89ece1df56b69d61288072
| * modify test for memory locked in case locking pages failed at some pointAdam Jonas2019-03-011-1/+3
| |
| * add rpc_misc.py, mv test getmemoryinfo, add test mallocinfoAdam Jonas2019-02-263-6/+49
| |
* | Merge #15497: rpc: Consistent range arguments in ↵MarcoFalke2019-03-013-7/+11
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | scantxoutset/importmulti/deriveaddresses ca253f6ebf Make deriveaddresses use stop/[start,stop] notation for ranges (Pieter Wuille) 1675b7ce55 Use stop/[start,stop] notation in importmulti desc range (Pieter Wuille) 4566011631 Add support for stop/[start,stop] ranges to scantxoutset (Pieter Wuille) 6b9f45e81b Support ranges arguments in RPC help (Pieter Wuille) 7aa6a8aefb Add ParseRange function to parse args of the form int/[int,int] (Pieter Wuille) Pull request description: This introduces a consistent notation for RPC arguments in `scantxoutset`, `importmulti`, and `deriveaddresses`, either: * `"range" : int` to just specify the end of the range * `"range" : [int,int]` to specify both the begin and the end of the range. For `scantxoutset`, this is a backward compatible new feature. For the two other RPCs, it's an incompatible change, but neither of them has been in a release so far. Because of that non-released reason, this only makes sense in 0.18, in my opinion. I suggest this as an alternative to #15496, which only makes `deriveaddresses` compatible with `importmulti`, but not with the existing `scantxoutset` RPC. I also think `[int,int]` is more convenient than `{"start":int,"stop":int}`. I realize this is technically a feature added to `scantxoutset` after the feature freeze. If desired, I'll drop the `scantxoutset` changes. Tree-SHA512: 1cbebb90cf34f106786dbcec7afbf3f43fb8b7e46cc7e6763faf1bc1babf12375a1b3c3cf86ee83c21ed2171d99b5a2f60331850bc613db25538c38b6a056676
| * | Make deriveaddresses use stop/[start,stop] notation for rangesPieter Wuille2019-02-281-5/+8
| | |
| * | Use stop/[start,stop] notation in importmulti desc rangePieter Wuille2019-02-281-2/+2
| | |
| * | Add support for stop/[start,stop] ranges to scantxoutsetPieter Wuille2019-02-281-0/+1
| | |
* | | test: Bump timeout on tests that timeout on windowsMarcoFalke2019-02-283-1/+3
|/ /
* | Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warningMarcoFalke2019-02-262-23/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ef362f2773 rpc/gui: Remove 'Unknown block versions being mined' warning (Wladimir J. van der Laan) Pull request description: Due to miners inserting garbage into the version numbers causing false positives, the current version signalling has become completely useless. This removes the "unknown block versions" warning which has the tendency to scare users unnecessarily (and might get them to "update" to something bad). It preserves the warning in the logs. Whether this is desirable can be a point of discussion. Tree-SHA512: 51407ccd24a571462465d9c7180f0f28307c50b82a03284abe783e181d8ab7e0638dbb710698d883f28de8a609db70763e39be2470d956e67c833da0768e43e9
| * | rpc/gui: Remove 'Unknown block versions being mined' warningWladimir J. van der Laan2019-02-252-23/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to miners inserting garbage into the version numbers, the current version signalling has become completely useless. This removes the "unknown block versions" warning which has the tendency to scare users unnecessarily (and might get them to "update" to something bad). It preserves the warning in the logs. Whether this is desirable can be a point of discussion.
* | | Merge #15419: qa: Always refresh cache to be out of ibdMarcoFalke2019-02-257-34/+59
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fa2cdc9ac2 test: Simplify create_cache (MarcoFalke) fa25210d62 qa: Fix wallet_txn_doublespend issue (MarcoFalke) 1111aecbb5 qa: Always refresh stale cache to be out of ibd (MarcoFalke) fab0d85802 qa: Remove mocktime unless required (MarcoFalke) Pull request description: When starting a test, we are always in IBD because the timestamps on cached blocks are in the past. Usually, we solve that by generating a block at the beginning of the test. That is clumsy and might even lead to other problems such as #15360 and https://github.com/bitcoin/bitcoin/issues/14446#issuecomment-461926598 So fix that by getting rid of mocktime and always refreshing the last block of the cache when starting the test framework. Should fix #14446 Tree-SHA512: 6af09800f9c86131349a103af617a54551f5f3f3260d38e14e3f30fdd3d91a0feb0100c56cbb12eae4aeac5571ae4b530b16345cbb831d2670237b53351a22c1
| * | test: Simplify create_cacheMarcoFalke2019-02-251-9/+6
| | |
| * | qa: Fix wallet_txn_doublespend issueMarcoFalke2019-02-192-1/+8
| | |
| * | qa: Always refresh stale cache to be out of ibdMarcoFalke2019-02-193-6/+25
| | |
| * | qa: Remove mocktime unless requiredMarcoFalke2019-02-194-22/+24
| | |
* | | Merge #15401: rpc: Actually throw help when passed invalid number of paramsWladimir J. van der Laan2019-02-251-0/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fa4ce7038d444defe0b98a30097174c278054a33 rpc: Actually throw help when passed invalid number of params (MarcoFalke) fa05626ca7a0fe896ac554c79eaea4c36acdf861 rpc: Add RPCHelpMan::IsValidNumArgs() (MarcoFalke) Pull request description: Can be tested by * running the included test against an old binary (compiled without this patch) * calling `setban 1 "add" 3 4 5 6 7 8 9 0` in the gui Tree-SHA512: aa6a25bbe6f40722913ea292252a62a4012c964eed9f4035335a2e2d13be98eb60f368e8a3251a104a26a62c08b2cb926b06e5ab1418ef1cf4abdd71d87c2919
| * | | rpc: Actually throw help when passed invalid number of paramsMarcoFalke2019-02-201-0/+5
| | | |
* | | | Merge #15278: Improve PID file error handlingWladimir J. van der Laan2019-02-211-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3782075a5fd4ad0c15a6119e8cdaf136898f679e Move all PID file stuff to init.cpp (Hennadii Stepanov) 561e375c73a37934fe77a519762d81edf7a3325c Make PID file creating errors fatal (Hennadii Stepanov) 745a2ace18ce857bc712d7e66c8bad7c082c07e2 Improve PID file removing errors logging (Hennadii Stepanov) Pull request description: Digging into #15240 the lack of the proper logging has been discovered. Fixed by this PR. UPDATE (inspired by @laanwj's [comment](https://github.com/bitcoin/bitcoin/pull/15278#discussion_r252641810)): Not being able to create the PID file is fatal now. Output of `bitcoind`: ``` $ src/bitcoind -pid=/run/bitcoind/bitcoind.pid 2019-02-01T23:20:10Z Bitcoin Core version v0.17.99.0-561e375c7 (release build) 2019-02-01T23:20:10Z Assuming ancestors of block 0000000000000037a8cd3e06cd5edbfe9dd1dbcc5dacab279376ef7cfc2b4c75 have valid signatures. 2019-02-01T23:20:10Z Setting nMinimumChainWork=00000000000000000000000000000000000000000000007dbe94253893cbd463 2019-02-01T23:20:10Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation 2019-02-01T23:20:10Z Using RdRand as an additional entropy source 2019-02-01T23:20:11Z Error: Unable to create the PID file '/run/bitcoind/bitcoind.pid': No such file or directory Error: Unable to create the PID file '/run/bitcoind/bitcoind.pid': No such file or directory 2019-02-01T23:20:11Z Shutdown: In progress... 2019-02-01T23:20:11Z Shutdown: Unable to remove PID file: File does not exist 2019-02-01T23:20:11Z Shutdown: done ``` Output of `bitcoin-qt`: ![screenshot from 2019-02-02 01-19-05](https://user-images.githubusercontent.com/32963518/52154886-9349b600-2688-11e9-8128-470f16790305.png) **Notes for reviewers** 1. `CreatePidFile()` has been moved from `util/system.cpp` to `init.cpp` for the following reasons: - to get the ability to use `InitError()` - now `init.cpp` contains code of both creating PID file and removing it 2. Regarding 0.18 release process: this PR modifies 1 string and introduces 2 new ones. Tree-SHA512: ac07d0f800e61ec759e427d0afc0ca43d67f232e977662253963afdd0a220d34b871050f58149fc9fabd427bfc8e0d3f6a6032f2a38f30ad366fc0d074b0f2b3
| * | | Make PID file creating errors fatalHennadii Stepanov2019-02-021-1/+1
| | | |
* | | | Merge #15439: tests: remove byte.hex() to keep compatibilityMarcoFalke2019-02-202-2/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1a062b85f0 tests: remove byte.hex() to keep compatibility (Akio Nakamura) Pull request description: Use ```test_framework.util.bytes_to_hex_str()``` instead of ```bytes.hex()``` that new in Python 3.5 to support minimum version of Python(test). ```test/functional/test_framework/wallet_util.py``` is also reported to have '\.hex()' in #15397, but it does not matter because it calls CScript.hex() defined in wallet_util.py. Tree-SHA512: 1019212e965f0848d235fab4da11959dffa42e8adfcd41216c10795cfc63c804b5deb5a3317f25d29940b9dcf088ab76fe3fa80d2679dc19f5f482dc5bde3283
| * | | | tests: remove byte.hex() to keep compatibilityAkio Nakamura2019-02-192-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | Use test_framework.util.bytes_to_hex_str() instead of bytes.hex() that new in Python 3.5, to support minimum version of Python(test).
* | | | | Merge #15404: [test] Remove -txindex to start nodesWladimir J. van der Laan2019-02-197-52/+40
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8e4b4f683a0b342cec24cd51b1e98433034ea2ea Address test todos by removing -txindex to nodes. Originally added when updating getrawtransaction to stop searching unspent utxos. (Amiti Uttarwar) Pull request description: Original todos added when removing getrawtransaction default behavior of searching unspent utxos. Tree-SHA512: d080953c3b0d2e5dca2265a15966dc25985a614c9cc86271ecd6276178ce428c85e262c24df92501695c32fed7beec0339b989f03cce91b57fb2efba201b7809
generated by cgit v1.2.3 (git 2.25.1) at 2026-04-18 01:18:49 +0000