aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #9532: Remove unused variablesWladimir J. van der Laan2017-02-071-3/+0
|\ | | | | | | | | 90fd29b Remove unused int64_t nSinceLastSeen (practicalswift) ac4a095 Remove unused Python variables (practicalswift)
| * Remove unused int64_t nSinceLastSeenpracticalswift2017-01-131-3/+0
| |
* | Merge #9604: [Trivial] add comment about setting peer as HB peer.Wladimir J. van der Laan2017-02-071-1/+9
|\ \ | | | | | | | | | dd5b011 [Trivial] add comment about setting peer as HB peer. (John Newbery)
| * | [Trivial] add comment about setting peer as HB peer.John Newbery2017-01-201-1/+9
| | | | | | | | | | | | | | | | | | | | | This adds a comment to the new logic for setting HB peers based on block validation (and aligns the code below to reflect the comment). It's not obvious why we're checking mapBlocksInFlight. Add a comment to explain.
* | | Merge #9227: Make nWalletDBUpdated atomic to avoid a potential race.Wladimir J. van der Laan2017-02-065-33/+43
|\ \ \ | | | | | | | | | | | | d63ff62 Make nWalletDBUpdated atomic to avoid a potential race. (Patrick Strateman)
| * | | Make nWalletDBUpdated atomic to avoid a potential race.Patrick Strateman2016-12-215-33/+43
| | | |
* | | | Merge #9378: [trivial] Add documentation for CWalletTx::fFromMe member.Wladimir J. van der Laan2017-02-061-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | 39c77b0 Add documentation for CWalletTx::fFromMe member. (Russell Yanofsky)
| * | | | Add documentation for CWalletTx::fFromMe member.Russell Yanofsky2016-12-151-0/+5
| | | | |
* | | | | Merge #9650: Better handle invalid parameters to signrawtransactionWladimir J. van der Laan2017-02-062-1/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6dbfe08 [qa] test signrawtransaction merge with missing inputs (Matt Corallo) ec4f7e4 [qa] Add second input to signrawtransaction test case (Matt Corallo) 691710a [qa] Test that decoderawtransaction throws with extra data appended (Matt Corallo) 922bea9 Better handle invalid parameters to signrawtransaction (Matt Corallo) 7ea0ad5 Fail in DecodeHexTx if there is extra data at the end (Matt Corallo)
| * | | | | Better handle invalid parameters to signrawtransactionMatt Corallo2017-02-021-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This silently skips trying to merge signatures from inputs which do not exist from transactions provided to signrawtransaction, instead of hitting an assert.
| * | | | | Fail in DecodeHexTx if there is extra data at the endMatt Corallo2017-02-021-0/+2
| | | | | |
* | | | | | Merge #9659: Net: Turn some methods and params/variables constWladimir J. van der Laan2017-02-065-19/+19
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0729102 Net: pass interruptMsgProc as const where possible (Jorge Timón) fc7f2ff Net: Make CNetMsgMaker more const (Jorge Timón) d45955f Net: CConnman: Make some methods const (Jorge Timón)
| * | | | | | Net: pass interruptMsgProc as const where possibleJorge Timón2017-01-312-6/+6
| | | | | | |
| * | | | | | Net: Make CNetMsgMaker more constJorge Timón2017-01-312-7/+7
| | | | | | |
| * | | | | | Net: CConnman: Make some methods constJorge Timón2017-01-312-6/+6
| | | | | | |
* | | | | | | Merge #9651: Fix typosWladimir J. van der Laan2017-02-063-4/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 5f62e3e Fix typos (practicalswift)
| * | | | | | | Fix typospracticalswift2017-01-293-4/+4
| | | | | | | |
* | | | | | | | Merge #9673: Set correct metadata on bumpfee wallet transactionsWladimir J. van der Laan2017-02-061-0/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 4ec057d [wallet] Set correct metadata on bumpfee wallet transactions (Russell Yanofsky)
| * | | | | | | | [wallet] Set correct metadata on bumpfee wallet transactionsRussell Yanofsky2017-02-021-0/+5
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Preserve comment, order form, and account strings from the original wallet transaction. Also set fTimeReceivedIsTxTime and fFromMe fields for consistency with CWallet::CreateTransaction. The latter two fields don't influence current wallet behavior, but do record that the transaction originated in the wallet instead of coming from the network or sendrawtransaction.
* | | | | | | | Merge #9691: Init ECC context for test_bitcoin_fuzzy.Wladimir J. van der Laan2017-02-061-0/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | ac719c9 Init ECC context for test_bitcoin_fuzzy. (Gregory Maxwell)
| * | | | | | | | Init ECC context for test_bitcoin_fuzzy.Gregory Maxwell2017-02-051-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This avoids calling things like pubkey_parse with a null context argument.
* | | | | | | | | Merge #9578: Add missing mempool lock for CalculateMemPoolAncestorsPieter Wuille2017-02-051-0/+2
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | 003cd60 Add missing mempool lock for CalculateMemPoolAncestors (Matt Corallo)
| * | | | | | | | Add missing mempool lock for CalculateMemPoolAncestorsMatt Corallo2017-01-201-0/+2
| | | | | | | | |
* | | | | | | | | Merge #9671: Fix super-unlikely race introduced in 236618061a445d2cb11e72Wladimir J. van der Laan2017-02-041-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 885cfdd Fix super-unlikely race introduced in 236618061a445d2cb11e72 (Matt Corallo)
| * | | | | | | | | Fix super-unlikely race introduced in 236618061a445d2cb11e72Matt Corallo2017-02-021-1/+1
| | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Once the CNode has been added to vNodes, it is possible that it is disconnected+deleted in the socket handler thread. However, after that we now call InitializeNode, which accesses the pnode. helgrind managed to tickle this case (somehow), but I suspect it requires in immensely braindead scheduler.
* | | | | | | | | Merge #9609: net: fix remaining net assertionsWladimir J. van der Laan2017-02-044-111/+102
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 08bb6f4 net: log an error rather than asserting if send version is misused (Cory Fields) 7a8c251 net: Disallow sending messages until the version handshake is complete (Cory Fields) 12752af net: don't run callbacks on nodes that haven't completed the version handshake (Cory Fields) 2046617 net: deserialize the entire version message locally (Cory Fields) 80ff034 Dont deserialize nVersion into CNode, should fix #9212 (Matt Corallo)
| * | | | | | | | | net: log an error rather than asserting if send version is misusedCory Fields2017-02-022-19/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also cleaned up the comments and moved from the header to the .cpp so that logging headers aren't needed from net.h
| * | | | | | | | | net: Disallow sending messages until the version handshake is completeCory Fields2017-02-022-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a change in behavior, though it's much more sane now than before.
| * | | | | | | | | net: don't run callbacks on nodes that haven't completed the version handshakeCory Fields2017-02-022-57/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since ForEach* are can be used to send messages to all nodes, the caller may end up sending a message before the version handshake is complete. To limit this, filter out these nodes. While we're at it, may as well filter out disconnected nodes as well. Delete unused methods rather than updating them.
| * | | | | | | | | net: deserialize the entire version message locallyCory Fields2017-02-022-29/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This avoids having some vars set if the version negotiation fails. Also copy it all into CNode at the same site. nVersion and fSuccessfullyConnected are set last, as they are the gates for the other vars. Make them atomic for that reason.
| * | | | | | | | | Dont deserialize nVersion into CNode, should fix #9212Matt Corallo2017-02-021-6/+8
| |/ / / / / / / /
* / / / / / / / / Access WorkQueue::running only within the cs lock.Matt Corallo2017-02-031-1/+1
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes a "race" between Interrupt() and Run(), though it should not effect any of our supported platforms.
* | | | | | | | Merge #9556: Remove redundant semicolonsWladimir J. van der Laan2017-02-023-4/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 8fc6989 Remove redundant semicolons (practicalswift)
| * | | | | | | | Remove redundant semicolonspracticalswift2017-01-143-4/+4
| | | | | | | | |
* | | | | | | | | Merge #9663: [RPC] clarify listunspent amount descriptionWladimir J. van der Laan2017-02-021-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3eba88d clarify listunspent amount description (Gregory Sanders)
| * | | | | | | | | clarify listunspent amount descriptionGregory Sanders2017-02-011-1/+1
| | | | | | | | | |
* | | | | | | | | | Merge #9625: Increase minimum debug.log size to 10MB after shrink.Wladimir J. van der Laan2017-02-012-3/+10
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 29fb311 Increase minimum debug.log size to 10MB after shrink. (Alex Morcos)
| * | | | | | | | | | Increase minimum debug.log size to 10MB after shrink.Alex Morcos2017-01-242-3/+10
| | | | | | | | | | |
* | | | | | | | | | | rpc: bumpfee: handle errors more gracefullySuhas Daftuar2017-01-311-2/+12
| | | | | | | | | | |
* | | | | | | | | | | rpc: bumpfee: use correct maximum signed tx size for fee calculationSuhas Daftuar2017-01-311-4/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | More accurate than simply adding one byte per input, and properly handles the case where the original transaction happened to have very small signatures
* | | | | | | | | | | wallet: Refactor dummy signature signing for reusabilitySuhas Daftuar2017-01-302-15/+30
| |_|_|_|_|/ / / / / |/| | | | | | | | |
* | | | | | | | | | Merge #9647: Skip RAII event tests if libevent is built without ↵Wladimir J. van der Laan2017-01-301-0/+6
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | event_set_mem_functions 95f97f4 Skip RAII event tests if libevent is built without event_set_mem_functions (Luke Dashjr)
| * | | | | | | | | | Skip RAII event tests if libevent is built without event_set_mem_functionsLuke Dashjr2017-01-281-0/+6
| | | | | | | | | | |
* | | | | | | | | | | Merge #9649: [doc] Remove unused clang format dev scriptMarcoFalke2017-01-301-1/+1
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fa5137c [doc] Remove unused clang format dev script (MarcoFalke)
| * | | | | | | | | | | [doc] Remove unused clang format dev scriptMarcoFalke2017-01-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, update the clang format file to reflect the current coding style mentioned in the developer notes.
* | | | | | | | | | | | qt: periodic translations updateWladimir J. van der Laan2017-01-3049-201/+450
| | | | | | | | | | | |
* | | | | | | | | | | | Merge #9644: [refactor] Remove using namespace <xxx> from src/MarcoFalke2017-01-3013-206/+179
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | b7b48c8 Refactor: Remove using namespace <xxx> from src/*.cpp. (Karl-Johan Alm)
| * | | | | | | | | | | | Refactor: Remove using namespace <xxx> from src/*.cpp.Karl-Johan Alm2017-01-2713-206/+179
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge #9626: Clean up a few CConnman cs_vNodes/CNode thingsWladimir J. van der Laan2017-01-302-46/+14
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2366180 Do not add to vNodes until fOneShot/fFeeler/fAddNode have been set (Matt Corallo) 3c37dc4 Ensure cs_vNodes is held when using the return value from FindNode (Matt Corallo) 5be0190 Delete some unused (and broken) functions in CConnman (Matt Corallo)
| * | | | | | | | | | | | | Do not add to vNodes until fOneShot/fFeeler/fAddNode have been setMatt Corallo2017-01-251-9/+10
| | | | | | | | | | | | | |