aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | Use C++-style numeric limits instead of C-style.Ricardo M. Correia2012-05-311-3/+3
| | | | | | | | | | |
| * | | | | | | | | | Fix noinline definition so that it works for more compilers.Ricardo M. Correia2012-05-312-3/+19
| | |_|_|_|_|_|/ / / | |/| | | | | | | |
| * | | | | | | | | Fix signed subtraction overflow in CBigNum::setint64().Ricardo M. Correia2012-05-141-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As noticed by sipa (Pieter Wuille), this can happen when CBigNum::setint64() is called with an integer value of INT64_MIN (-2^63). When compiled with -ftrapv, the program would crash. Otherwise, it would execute an undefined operation (although in practice, usually the correct one).
| * | | | | | | | | Add test case for CBigNum::setint64().Ricardo M. Correia2012-05-141-0/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the test cases currently aborts when using gcc's flag -ftrapv, due to negating an INT64_MIN int64 variable, which is an undefined operation. This will be fixed in a subsequent commit.
| * | | | | | | | | Don't overflow signed ints in CBigNum::setint64().Ricardo M. Correia2012-05-141-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CBigNum::setint64() does 'n <<= 8', where n is of type "long long". This leads to shifting onto and past the sign bit, which is undefined behavior in C++11 and can cause problems in the future.
| * | | | | | | | | Make CNetAddr::GetHash() return an unsigned val.Ricardo M. Correia2012-05-133-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This prevents an undefined operation in main.cpp, when shifting the hash value left by 32 bits. Shifting a signed int left into the sign bit is undefined in C++11.
* | | | | | | | | | Merge pull request #1477 from gmaxwell/masterPieter Wuille2012-06-171-1/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fix inverted logic for !Discover/!UPNP when !Listen.
| * | | | | | | | | | Fix inverted logic for !Discover/!UPNP when !Listen.Gregory Maxwell2012-06-171-1/+1
| | |_|_|_|/ / / / / | |/| | | | | | | |
* | | | | | | | | | Merge pull request #1434 from Diapolo/GUI_fix_displayunitWladimir J. van der Laan2012-06-176-18/+45
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | GUI: init with correct display unit and update it, when user changes it via options dialog
| * | | | | | | | | | add the slot updateDisplayUnit() to overviewpage, sendcoinsdialog, ↵Philip Kaufmann2012-06-176-18/+45
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sendcoinsentry and connect it to displayUnitChanged() - this ensures all fields in the GUI, who use a display unit are imediately updated, when the user changes this setting in the optionsdialog / ensure used fields init with the current set display unit
* | | | | | | | | | Merge pull request #1451 from Diapolo/sendcoinsWladimir J. van der Laan2012-06-171-0/+9
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | GUI: set cursor for balance field to IBeamCursor (to show the user it IS selectable)
| * | | | | | | | | | set cursor for balance field to IBeamCursor (to show the user it IS ↵Philip Kaufmann2012-06-131-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | selectable) and set autoDefault to false for the buttons that do not need this
* | | | | | | | | | | Merge pull request #1461 from laanwj/2012_06_helpmessageWladimir J. van der Laan2012-06-173-7/+17
|\ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / |/| | | | | | | | | | Show command line options as dialog when opened from debug window
| * | | | | | | | | | Show command line options as dialog when opened from debug windowWladimir J. van der Laan2012-06-143-7/+17
| | |_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Linux/Mac the command-line options were printed to stderr when the button was pressed in the debug window, resulting in confusion. This is fixed in this commit by adding a separate method.
* / | | | | | | | | Use a 64-bit nonce in pingPieter Wuille2012-06-141-1/+2
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | Former code sent '0' as nonce, which was serialized as 32-bit.
* | | | | | | | | Merge pull request #1459 from laanwj/2012_06_trayiconmenuWladimir J. van der Laan2012-06-141-5/+5
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Reorganize tray icon menu into more logical order
| * | | | | | | | | Reorganize tray icon menu into more logical orderWladimir J. van der Laan2012-06-141-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current order of menu options in the tray menu doesn't really match expected usage patterns, this commit changes it to more logical order. - Toggle show/hide first (unchanged) - Then, send/receive coins actions, which are the critical functionality of bitcoin - Then, sign/verify message - Then finally the options, and closing with the debug window
* | | | | | | | | | Fix build of testcases after commit 0f10b21719e1b0d9683a142f0a7105e65f095694Wladimir J. van der Laan2012-06-141-0/+6
| | | | | | | | | |
* | | | | | | | | | Merge pull request #1002 from Diapolo/URL-handling_2Wladimir J. van der Laan2012-06-134-21/+39
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | URI-handling code update: added safety checks and notifications
| * | | | | | | | | | URI-handling code update: added safety checks and tray-notificationsPhilip Kaufmann2012-06-144-21/+39
| |/ / / / / / / / /
* | | | | | | | | | Merge pull request #1439 from Diapolo/ClientShutdownWladimir J. van der Laan2012-06-137-16/+25
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | re-work Shutdown() function
| * | | | | | | | | introduce a new StartShutdown() function, which starts a thread with ↵Philip Kaufmann2012-06-127-16/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Shutdown() if no GUI is used and calls uiInterface.QueueShutdown() if a GUI is used / all direct uiInterface.QueueShutdown() calls are replaced with Shutdown() - this ensures a clean GUI shutdown, even when catching a SIGTERM and allows the BitcoinGUI destructor to get called (which fixes a tray-icon issue and keeps the tray-icon until Bitcoin-Qt exits)
* | | | | | | | | | Merge pull request #1420 from Diapolo/extend_showNormalIfMinimizedWladimir J. van der Laan2012-06-132-31/+25
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | GUI: merge toggleHidden() code into showNormalIfMinimized()
| * | | | | | | | | | merge toggleHidden() code into showNormalIfMinimized() to extend the ↵Philip Kaufmann2012-06-122-31/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | functionality, but keep a simpler toggleHidden() for use in SLOT() macro
* | | | | | | | | | | Merge branch 'refactor_coinselect' of https://github.com/luke-jr/bitcoinGavin Andresen2012-06-133-83/+437
|\ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | Fix coin selection to only include change when it's necessary.Chris Moore2012-06-042-80/+58
| | | | | | | | | | | |
| * | | | | | | | | | | Preserve the shuffled order of coins with equal value to give more ↵Chris Moore2012-06-041-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | randomized coin selection.
| * | | | | | | | | | | Test that the coin selection code is suitably random, and add tests re. ↵Chris Moore2012-06-041-1/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sub-cent change.
| * | | | | | | | | | | Move the random_shuffle call back into SelectCoinsMinConf() so we can unit ↵Chris Moore2012-06-041-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test it.
| * | | | | | | | | | | Refactor SelectCoinsMinConf() and add unit tests.Chris Moore2012-06-043-48/+343
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AvailableCoins() makes a vector of available outputs which is then passed to SelectCoinsMinConf(). This allows unit tests to test the coin selection algorithm without having the whole blockchain available.
* | | | | | | | | | | | Merge pull request #1448 from Diapolo/2012-06-13_translation_updatesWladimir J. van der Laan2012-06-1336-19745/+34832
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | update translation files (fetched from Transifex - 2012-06-13)
| * | | | | | | | | | | | update translation files (fetched from Transifex) and remove translation for ↵Philip Kaufmann2012-06-1336-19745/+34832
| | |_|_|/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fr_FR, which was removed / renamed on TX
* / | | | | | | | | | | Update bitcoinstrings from core and English source translation fileWladimir J. van der Laan2012-06-132-462/+495
|/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is necessary as any strings have changed since last time. Also the python script used to extract bitcoinstrings.cpp, extract_strings_qt.py now sorts the strings before generating the output file. This results in more deterministic output and thus smaller diffs.
* | | | | / / / / / / re-work optionsdialog to a tabbed UI based on an ui-filePhilip Kaufmann2012-06-134-344/+644
| |_|_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - extend network options with a SOCKS version selection - changing "Unit to show amounts in:" now also updates the unit used in the transaction fee box - string updates - link Apply button and OK button when enabling or disabling them - use LookupNumeric() from netbase to verify proxy address (via an EventFilter) - change proxy address field to QValidatedLineEdit and add visual feedback - add a status label used for displaying a message for invalid proxy addresses - allow usage of IPv6 address as proxy address - added warning message when enabling / disabling SOCKS proxy
* | | | | | | | | | Merge pull request #1444 from laanwj/2012_06_opendebuglogWladimir J. van der Laan2012-06-122-10/+2
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Cross-platform “Open debug logfile”
| * | | | | | | | | | Cross-platform "Open debug logfile"Wladimir J. van der Laan2012-06-122-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The option to open the debug logfile from the debug window was implemented only for windows. By using `QDesktopServices::openUrl` it now works on any platform.
* | | | | | | | | | | make buttons in debug window non autoDefaultPhilip Kaufmann2012-06-121-0/+6
| |_|/ / / / / / / / |/| | | | | | | | |
* | | | | | | | | | Merge pull request #1440 from Diapolo/overviewpage_InitialBalanceWladimir J. van der Laan2012-06-121-1/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | change initial Balance on overviewpage from "123.456 BTC" to "0 BTC" to ...
| * | | | | | | | | | change initial Balance on overviewpage from "123.456 BTC" to "0 BTC" to not ↵Philip Kaufmann2012-06-111-1/+1
| | |_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | confuse users, which could see it before we init with the real wallet balance
* | | | | | | | | | Do not select first address automatically in the address bookWladimir J. van der Laan2012-06-121-5/+0
| |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | This contributed to an accidental send (#1384), and has no clear advantage, better to disable it.
* | | | | | | | | Merge pull request #1412 from Diapolo/string_wait_matureWladimir J. van der Laan2012-06-112-3/+2
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | GUI: update info strings for generated blocks
| * | | | | | | | update info string in GUI for generated blocks and change "must wait" into ↵Philip Kaufmann2012-06-092-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "must mature" to take the new immature label into consideration
* | | | | | | | | Merge pull request #1435 from TheBlueMatt/mingwbuildJeff Garzik2012-06-091-0/+2
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Fix Mingw64 build (missing headers according to M$ documentation)
| * | | | | | | | Fix Mingw64 build (missing headers according to M$ documentation)Matt Corallo2012-06-091-0/+2
| | | | | | | | |
* | | | | | | | | Merge pull request #1421 from Diapolo/netbase_fix_sign_warningsPieter Wuille2012-06-081-2/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | fix two signed/unsigned comparison warnings in netbase.cpp
| * | | | | | | | | fix two signed/unsigned comparison warnings in netbase.cppPhilip Kaufmann2012-06-051-2/+2
| | | | | | | | | |
* | | | | | | | | | Update comment about secure_allocator<>Pieter Wuille2012-06-081-1/+0
| | | | | | | | | |
* | | | | | | | | | Merge pull request #1424 from TheBlueMatt/lockcontentionPieter Wuille2012-06-082-2/+13
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | Fix DEBUG_LOCKCONTENTION
| * | | | | | | | | Fix DEBUG_LOCKCONTENTIONMatt Corallo2012-06-052-2/+13
| | | | | | | | | |
* | | | | | | | | | Merge pull request #1418 from Diapolo/GUI_fix_default_proxy_addrPieter Wuille2012-06-051-1/+1
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | fix default Proxy address in Qt options (no hostname allowed currently)