aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* net: Log to net category for exceptions in ProcessMessagesWladimir J. van der Laan2020-01-221-28/+3
| | | | | | | | | | Remove the forest of special exceptions, and simply log a short message to the NET logging category when an exception happens during packet processing. It is not good to panick end users with errors that any peer can generate (let alone writing to stderr). Github-Pull: #17762 Rebased-From: 4d88c3dcb61e7c075ed3dd442044e0eff4e3c8de
* scripts: fix check-symbols & check-security argument passingfanquake2020-01-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The first argument in bin_PROGRAMS (bitcoind) was being silently dropped and never passed into the check-security.py or check-symbols.py scripts. This has been the case since the scripts were added to the makefile in https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719. Example of the behavior: ```python # touch a, touch b, touch c # python3 args.py < a b c import sys if __name__ == '__main__': print(sys.argv) # ['args.py', 'b', 'c'] # if you add some lines to "a", # you'll see them here.. for line in sys.stdin: print(line) ``` Github-Pull: #17857 Rebased-From: 71af793512100ee7d508c3fb815af47925fe80ba
* util: Filter control characters out of log messagesWladimir J. van der Laan2019-10-192-1/+42
| | | | | | | | | | | | Belts and suspenders: make sure outgoing log messages don't contain potentially suspicious characters, such as terminal control codes. This escapes control characters except newline ('\n') in C syntax. It escapes instead of removes them to still allow for troubleshooting issues where they accidentally end up in strings. Github-Pull: #17095 Rebased-From: d7820a1250070f3640246ae497e049bee0b3516f
* build: Factor out qt translations from build systemWladimir J. van der Laan2019-10-012-120/+121
| | | | | | | | | Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36). Github-Pull: #16982 Rebased-From: 4320bfc0c0d88633c84146f8d640f5b6e4596244
* Shuffle inputs and outputs after joining psbtsAndrew Chow2019-09-241-1/+24
| | | | | Github-Pull: #16512 Rebased-From: 6f405a1d3b38395e35571b68aae55cae50e0762a
* addrdb: Remove temporary files created in SerializeFileDB. Fixes ↵practicalswift2019-09-241-4/+16
| | | | | | | non-determinism in unit tests. Github-Pull: #16212 Rebased-From: d9753383b9e1b61d19d98bcd1d66607f398c7e9f
* Handle the result of posix_fallocate system callLuca Venturini2019-09-241-3/+4
| | | | | Github-Pull: #15650 Rebased-From: 5d35ae3326624da3fe5dcb4047c9a7cec6665cab
* torcontrol: Use the default/standard network port for Tor hidden services, ↵Luke Dashjr2019-09-241-4/+4
| | | | | | | | | | even if the internal port is set differently Currently, the hidden service is published on the same port as the public listening port. But if a non-standard port is configured, this can be used to guess (pretty reliably) that the public IP and the hidden service are the same node. Github-Pull: #15651 Rebased-From: 8a2656702b4b5d53d1b8343c3215302e4305a038
* Add vertical spacerJosu Goñi2019-09-241-0/+13
| | | | | Github-Pull: #16090 Rebased-From: 36b0a2f2a6b49008c4f37866a9e3ab702eb34eda
* Give QApplication dummy argumentsAndrew Chow2019-09-243-5/+8
| | | | | | | | | QApplication takes the command line arguments and parses them itself for some built in command line arguments that it has. We don't want any of those built in arguments, so instead give it dummy arguments. Github-Pull: #16578 Rebased-From: a2714a5c69f0b0506689af04c3e785f71ee0915d
* util: No translation of `Bitcoin Core` in the copyrightMarcoFalke2019-09-241-3/+4
| | | | | Github-Pull: #16291 Rebased-From: fa64b947bb3075ff8737656706b941af691908ab
* scripted-diff: Avoid passing PACKAGE_NAME for translationMarcoFalke2019-09-2411-32/+32
| | | | | | | | | -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/\<\w+(::\w+)?\(PACKAGE_NAME\)/PACKAGE_NAME/g' $(git grep -l --extended-regexp '\<\w+(::\w+)?\(PACKAGE_NAME\)' src) -END VERIFY SCRIPT- Github-Pull: #16291 Rebased-From: fabe87d2c923ab3a70b8cde2666a4d1cda8b22fb
* build: Stop translating PACKAGE_NAMEMarcoFalke2019-09-242-2/+2
| | | | | Github-Pull: #16291 Rebased-From: fa5e9f157e568b7fbbea1482b393181f0733f2ba
* rpc: Fix getblocktemplate CLI example (#16594)Emil Engler2019-09-241-1/+1
| | | | | Github-Pull: #16596 Rebased-From: 14f7eec3bdb15a9a75f8686c0a3e879aa8ceef47
* 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransactionJoão Barbosa2019-08-251-5/+5
| | | | | Github-Pull: #16322 Rebased-From: 5c1b9714cb0a13be28324f91f4ec9ca66a1de8c7
* 0.18: [wallet] abort when attempting to fund a transaction above maxtxfeeSjors Provoost2019-08-254-9/+6
| | | | | | | FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior. Github-Pull: #16257 Rebased-From: 806b0052c3b45415862f74f20ba5f389e5b673de
* [doc] rpc: remove "fallback to" from RBF default helpSjors Provoost2019-08-171-8/+8
|
* [rpc] walletcreatefundedpsbt: use wallet default RBFSjors Provoost2019-08-173-9/+21
|
* qt: pre-rc1 translations updateWladimir J. van der Laan2019-07-1951-407/+21707
| | | | Tree-SHA512: b97fd91b7ab1eb2297007a9821def31c065a2a33f12cf51fd5e5be5dff1e8afb4f5b001d220c3873d72ca5b06484ad2d1e2c8df5300770145de0dfebe56db303
* net: Make poll in InterruptibleRecv only filter for POLLIN events.tecnovert2019-07-191-1/+1
| | | | | | | | | | | | poll should block until there is data to be read or the timeout expires. Filtering for the POLLOUT event causes poll to return immediately which leads to high CPU usage when trying to connect to non-responding peers through tor. Removing POLLOUT matches how select is used when USE_POLL isn't defined. Github-Pull: #16412 Rebased-From: a52818cc5633494992da7d1dc8fdb04b4a1b7c29 Tree-SHA512: eaf466630ba9d2a2a7443c9679c83c2cb13e779a5948f409cddb4c48cf32126ac68f3de48e394f9302e99858efa17cdb14650751a1b55c3b79e8a7507cab352d
* fix: tor: Call event_base_loopbreak from the event's callbackJoão Barbosa2019-07-171-1/+3
| | | | | Github-Pull: #16405 Rebased-From: a981e749e6553487cd48eda28e590f769e81c85c
* qt: Assert QMetaObject::invokeMethod resultJoão Barbosa2019-07-097-22/+44
| | | | | Github-Pull: #16348 Rebased-From: 64fee489448c62319e77941c30152084695b5a5d
* gui: Fix missing qRegisterMetaType(WalletModel*)João Barbosa2019-07-091-0/+3
| | | | | Github-Pull: #16348 Rebased-From: f27bd96b5fdc2921d93c44bbf422bff0e979c4de
* signrawtransactionwithkey: report error when missing ↵Anthony Towns2019-07-051-0/+3
| | | | | | | redeemScript/witnessScript param Github-Pull: #16250 Rebased-From: 01174596e69568c434198a86f54cb9ea6740e6c2
* Merge #16035: 0.18.1: Backportsfanquake2019-07-0432-129/+248
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bcb27d7b0 .python-version: Bump to 3.5.6 (MarcoFalke) af25a757e Add comments to Python ECDSA implementation (John Newbery) 715da91e9 Set AA_EnableHighDpiScaling attribute early (Hennadii Stepanov) 2800b3d5c gui: Fix open wallet menu initialization order (João Barbosa) e78007fc1 Make and get the multisig redeemscript and destination in one function instead of two (Andrew Chow) d9fc969e7 Pure python EC (Pieter Wuille) 23ba460c1 test: Add test that addmultisigaddress fails for watchonly addresses (MarcoFalke) 13b3bb564 test: Fixup creatmultisig documentation and whitespace (MarcoFalke) 79745d175 Replace remaining fprintf with tfm::format manually (MarcoFalke) beb09f09b scripted-diff: Replace fprintf with tfm::format (MarcoFalke) e29aa6e72 Exceptions should be caught by reference, not by value. (Kristaps Kaupe) f88959ba7 tinyformat: Add doc to Bitcoin Core specific strprintf (MarcoFalke) 0023c9789 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke) 832eb4ff5 Bugfix: test/functional/rpc_psbt: Correct test description comment (Luke Dashjr) 966d8d084 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (Luke Dashjr) bb36ac82e rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke) d24d0ec05 Add example 2nd arg to signrawtransactionwithkey (Chris Moore) 592016ba1 fixup: Fix prunning test (João Barbosa) c80a498ae Fix RPC/pruneblockchain returned prune height (Jonas Schnelli) b2398240f gui: Enable open wallet menu on setWalletController (João Barbosa) d1f261150 Add test for GCC bug 90348 (Pieter Wuille) d80c558e0 gui: Set progressDialog to nullptr (João Barbosa) 7ed1a6019 gui: Enable console line edit on setClientModel (João Barbosa) b55cbe82d qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 (shannon1916) b6c1f9478 Disallow extended encoding for non-witness transactions (take 3) (MarcoFalke) 86031083c Add test for superfluous witness record in deserialization (Gregory Sanders) 5a58ddb6d Fix missing input template by making minimal tx (Gregory Sanders) 206f5ee87 Disallow extended encoding for non-witness transactions (Pieter Wuille) 3dbc7def0 Show loaded wallets as disabled in open menu instead of nothing (MeshCollider) a635377b6 Install bitcoin-wallet manpage. (Daniel Kraft) eb85ee62b Doc: remove text about txes always relayed from -whitelist (David A. Harding) 890a92eba doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) 3460555f4 test: Add test for p2p_blocksonly (MarcoFalke) 8f215c7a2 test: Format predicate source as multiline on error (MarcoFalke) 9c1a607a0 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) 5935f0126 build with -fstack-reuse=none (MarcoFalke) Pull request description: Tree-SHA512: 5cd73a4319cb69c92b528239cf97c0ed5fcf2b9e8c7fe154e4679eeec95db433a0223d8dc574e4cdc96c1913cfdf160b10c42dcdbcb5bbc8fb743c07930ef9da
| * Set AA_EnableHighDpiScaling attribute earlyHennadii Stepanov2019-06-241-2/+3
| | | | | | | | | | | | | | | | Qt docs: This attribute must be set before QGuiApplication is constructed. Github-Pull: #16254 Rebased-From: 099e4b9ad3d9967051d5c3d45c6315d1b30fea05
| * gui: Fix open wallet menu initialization orderJoão Barbosa2019-06-232-5/+7
| | | | | | | | | | | | | | The menu must be created before connecting to aboutToShow signal. Github-Pull: #16231 Rebased-From: 5224be5a3354e1a22ea4d7f0e40aadfccdf67064
| * Make and get the multisig redeemscript and destination in one function ↵Andrew Chow2019-06-214-11/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of two Instead of creating a redeemScript with CreateMultisigRedeemscript and then getting the destination with AddAndGetDestinationForScript, do both in the same function. CreateMultisigRedeemscript is changed to AddAndGetMultisigDestination. It creates the redeemScript and returns it via an output parameter. Then it calls AddAndGetDestinationForScript to add the destination to the keystore and get the proper destination. This allows us to inspect the public keys in the redeemScript before creating the destination so that the correct destination is used when uncompressed pubkeys are in the multisig. Github-Pull: #16026 Rebased-From: a49503402b6bc21e3878e151c07529941d36aed0
| * Replace remaining fprintf with tfm::format manuallyMarcoFalke2019-06-183-6/+5
| | | | | | | | | | Github-Pull: #16205 Rebased-From: fa8f195195945ce6258199af0461e3fbfbc1236d
| * scripted-diff: Replace fprintf with tfm::formatMarcoFalke2019-06-1810-57/+57
| | | | | | | | | | | | | | | | | | | | | | -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/fprintf\(std(err|out), /tfm::format(std::c\1, /g' $(git grep -l 'fprintf(' -- ':(exclude)src/crypto' ':(exclude)src/leveldb' ':(exclude)src/univalue' ':(exclude)src/secp256k1') -END VERIFY SCRIPT- fixup! scripted-diff: Replace fprintf with tfm::format Github-Pull: #16205 Rebased-From: fac03ec43a15ad547161e37e53ea82482cc508f9
| * Exceptions should be caught by reference, not by value.Kristaps Kaupe2019-06-181-1/+1
| | | | | | | | | | Github-Pull: #16095 Rebased-From: ae7faf20d5fb3e2415ccadc37100dfc44aa0cd94
| * tinyformat: Add doc to Bitcoin Core specific strprintfMarcoFalke2019-06-181-0/+1
| | | | | | | | | | Github-Pull: #16205 Rebased-From: fa72a64b90dc07a80b1ca6127eb50d8244dedc3b
| * rpc: bugfix: Properly use iswitness in converttopsbtMarcoFalke2019-06-182-11/+23
| | | | | | | | | | | | | | Also explain the param in all RPCs Github-Pull: #15899 Rebased-From: fa499b5f027f77c0bf13699852c8c06f78e27bef
| * rpc: Switch touched RPCs to IsValidNumArgsMarcoFalke2019-06-182-12/+18
| | | | | | | | | | Github-Pull: #15899 Rebased-From: fa5c5cd141f0265a5693234690ac757b811157d8
| * Add example 2nd arg to signrawtransactionwithkeyChris Moore2019-06-171-2/+2
| | | | | | | | | | | | | | The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Github-Pull: #16210 Rebased-From: 71fd628adafdeb2a4b343e0d51d7168cdb186312
| * Fix RPC/pruneblockchain returned prune heightJonas Schnelli2019-06-141-1/+6
| | | | | | | | | | Github-Pull: #15991 Rebased-From: 97f517dd851450b1ede1eb6b20f77691883a7737
| * gui: Enable open wallet menu on setWalletControllerJoão Barbosa2019-06-131-1/+4
| | | | | | | | | | Github-Pull: #16118 Rebased-From: 75485ef0962a53946f17b761c4445627b07e6eff
| * Add test for GCC bug 90348Pieter Wuille2019-06-072-0/+44
| | | | | | | | | | Github-Pull: #15985 Rebased-From: 58e291cfad12fa85af87d093acfa7b44702e3521
| * gui: Set progressDialog to nullptrJoão Barbosa2019-06-072-0/+2
| | | | | | | | | | Github-Pull: #16135 Rebased-From: d2ae6be80f6a0156021bf8c9b9d17cd4966ddffc
| * gui: Enable console line edit on setClientModelJoão Barbosa2019-06-072-0/+6
| | | | | | | | | | Github-Pull: #16122 Rebased-From: 2d8ad2f99710a8981e33fe2d6ce834b0076c4e80
| * qt: fix opening bitcoin.conf via Preferences on macOS; see #15409shannon19162019-06-071-1/+10
| | | | | | | | | | Github-Pull: #16044 Rebased-From: 6e6494b3fb345848025494cb7a79c5bf8f35e417
| * Disallow extended encoding for non-witness transactions (take 3)MarcoFalke2019-05-201-11/+10
| | | | | | | | | | Github-Pull: #16021 Rebased-From: fa2b52af32f6a4b9c22c270f36e92960c29ef364
| * Disallow extended encoding for non-witness transactionsPieter Wuille2019-05-201-0/+4
| | | | | | | | | | Github-Pull: #14039 Rebased-From: bb530efa1872ec963417f61da9a95185c7a7a7d6
| * Show loaded wallets as disabled in open menu instead of nothingMeshCollider2019-05-181-1/+14
| | | | | | | | | | Github-Pull: #15957 Rebased-From: c3ef63a52f304a600fff1f9c7caa5cb804d41d43
| * Doc: remove text about txes always relayed from -whitelistDavid A. Harding2019-05-171-2/+2
| | | | | | | | | | | | | | | | Updates text since -whitelistforcerelay was set to false by default in PR #15193. Github-Pull: #15890 Rebased-From: e0bb2799992afe88e6f4efc6d90ed82ddf1ec5ec
| * doc: Mention blocksonly in reduce-traffic.md, unhide optionMarcoFalke2019-05-161-1/+1
| | | | | | | | | | Github-Pull: #15990 Rebased-From: fa8ced32a60dea37ac169241cf9a1f708ef46c4b
| * net: Rename ::fRelayTxes to ::g_relay_txesMarcoFalke2019-05-165-7/+7
| | | | | | | | | | | | | | | | This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d17bd0edf8a3a7cc81e55016f7fd8e7726 Github-Pull: #15990 Rebased-From: fa1dce7329d3e74d46ab98b93772b1832a3f1819
* | Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet optionsLuke Dashjr2019-06-111-0/+1
| | | | | | | | | | Github-Pull: #15913 Rebased-From: 765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0
* | dummywallet: Reformat ignored wallet options listMarcoFalke2019-06-111-4/+25
|/
* gui: Pre-rc4 translations updateWladimir J. van der Laan2019-04-1814-36/+550
| | | | Tree-SHA512: f3a7c9e0c935c869a85e3bc93a4bd33999270ffc13d35de34c46e9dab19229af19fb9c1a61a99264e8411c0966bf8b02a5ee94bf20a07f66b92234473f0e0801