aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/rpcwallet.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #7136Wladimir J. van der Laan2015-12-011-1/+1
|\ | | | | | | | | | | | | | | fa19a58 HelpMessage: Don't hide -mintxfee behind showDebug (MarcoFalke) faffc17 rpcwallet: Clarify what settxfee does (MarcoFalke) 9999cb0 Fix url in .travis.yml (MarcoFalke) fa22a10 contrib: Del. gitian downloader config and update gitian README (MarcoFalke) fad3035 [doc] Minor markdown fixes (MarcoFalke)
| * rpcwallet: Clarify what settxfee doesMarcoFalke2015-11-301-1/+1
| |
* | Keep track of explicit wallet conflicts instead of using mempoolPieter Wuille2015-11-291-1/+5
|/
* Merge pull request #7066Wladimir J. van der Laan2015-11-241-2/+3
|\ | | | | | | 5c2fd38 Add missing "blocktime" description to listtransactions help, fix formatting. (Pavel Janík)
| * Add missing "blocktime" description to listtransactions help, fix formatting.Pavel Janík2015-11-201-2/+3
| |
* | Optimisation: Store transaction list order in memory rather than compute it ↵Luke Dashjr2015-11-211-7/+5
|/ | | | | | every need Huge performance improvement (450%) for zapwallettxes
* Merge pull request #6991Gregory Maxwell2015-11-161-1/+1
|\ | | | | | | 9bd3f03 Clarify 'fee' field in fundrawtransaction help text (Peter Todd)
| * Clarify 'fee' field in fundrawtransaction help textPeter Todd2015-11-111-1/+1
| | | | | | | | | | | | Previous text could be interpreted as the the _additional_ fee paid by the result on top of the fee the original version paid, rather than the correct interpretation: the absolute fee the resulting tx pays.
* | Better error message for fundrawtransaction w/ empty voutPeter Todd2015-11-131-0/+3
| | | | | | | | | | Previously this case failed deep in Cwallet::CreateTransaction() with the error message "Transaction amounts must be positive"
* | Actually use includeWatching value in fundrawtransactionPeter Todd2015-11-131-1/+1
|/ | | | | Previously if you called fundrawtransaction and set includeWatching to false it'd act as through you set it to true.
* Merge pull request #5574Wladimir J. van der Laan2015-11-101-3/+14
|\ | | | | | | fd55571 wallet: Expose GUI labels in RPC (Luke Dashjr)
| * wallet: Expose GUI labels in RPCLuke Dashjr2015-10-021-3/+14
| |
* | [Univalue] add univalue over subtreeJonas Schnelli2015-10-011-1/+1
| | | | | | | | similar to secp256k1 include and compile univalue over a subtree
* | Merge pull request #6539Wladimir J. van der Laan2015-08-191-1/+1
|\ \ | | | | | | | | | 9f68ed6 typofixes (found by misspell_fixer) (Veres Lajos)
| * | typofixes (found by misspell_fixer)Veres Lajos2015-08-101-1/+1
| |/
* | Merge pull request #6415Wladimir J. van der Laan2015-08-141-5/+14
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | d042854 SQUASH "Implement watchonly support in fundrawtransaction" (Matt Corallo) 428a898 SQUASH "Add have-pubkey distinction to ISMINE flags" (Matt Corallo) 6bdb474 Implement watchonly support in fundrawtransaction (Matt Corallo) f5813bd Add logic to track pubkeys as watch-only, not just scripts (Matt Corallo) d3354c5 Add have-pubkey distinction to ISMINE flags (Matt Corallo) 5c17059 Update importaddress help to push its use to script-only (Matt Corallo) a1d7df3 Add importpubkey method to import a watch-only pubkey (Matt Corallo) 907a425 Add p2sh option to importaddress to import redeemScripts (Matt Corallo) 983d2d9 Split up importaddress into helper functions (Matt Corallo) cfc3dd3 Also remove pay-2-pubkey from watch when adding a priv key (Matt Corallo)
| * Implement watchonly support in fundrawtransactionMatt Corallo2015-07-201-5/+14
| | | | | | | | | | Some code and test cases stolen from Bryan Bishop <[email protected]> (pull #5524).
* | Rationalize currency unit to "BTC"Ross Nicoll2015-08-031-25/+26
| | | | | | | | | | | | | | | | | | Previously various user-facing strings have used inconsistent currency units "BTC", "btc" and "bitcoins". This adds a single constant and uses it for each reference to the currency unit. Also adds a description of the unit for --maxtxfee, and adds the missing "amount" field description to the (deprecated) move RPC command.
* | Merge pull request #5697Wladimir J. van der Laan2015-07-271-0/+1
|\ \ | | | | | | | | | | | | 60c8bac Includes: Cleanup around net main and wallet (Jorge Timón) 9dd793f TRIVIAL: Missing includes (Jorge Timón)
| * | TRIVIAL: Missing includesJorge Timón2015-07-231-0/+1
| |/
* | Merge pull request #6287Wladimir J. van der Laan2015-07-231-1/+0
|\ \ | |/ |/| | | | | | | a794284 locking: add a quick example of GUARDED_BY (Cory Fields) 2b890dd locking: fix a few small issues uncovered by -Wthread-safety (Cory Fields) cd27bba locking: teach Clang's -Wthread-safety to cope with our scoped lock macros (Cory Fields)
| * locking: fix a few small issues uncovered by -Wthread-safetyCory Fields2015-06-161-1/+0
| | | | | | | | | | | | - rpcwallet: No need to lock twice here - openssl: Clang doesn't understand selective lock/unlock here. Ignore it. - CNode: Fix a legitimate (though very unlikely) locking bug.
* | Merge pull request #6088Wladimir J. van der Laan2015-06-231-0/+54
|\ \ | |/ |/| | | | | | | | | | | 2085895 fundrawtransaction tests (Jonas Schnelli) 21bbd92 Add fundrawtransaction RPC method (Matt Corallo) 1e0d1a2 Add FundTransaction method to wallet (Matt Corallo) 2d84e22 Small tweaks to CCoinControl for fundrawtransaction (Matt Corallo) 9b4e7d9 Add DummySignatureCreator which just creates zeroed sigs (Pieter Wuille)
| * Add fundrawtransaction RPC methodMatt Corallo2015-06-111-0/+54
| |
* | Merge pull request #6257Wladimir J. van der Laan2015-06-151-0/+2
|\ \ | | | | | | | | | ef2a3de Add paytxfee to getwalletinfo, warnings to getnetworkinfo (Stephen)
| * | Add paytxfee to getwalletinfo, warnings to getnetworkinfoStephen2015-06-111-0/+2
| | |
* | | Fix getbalance *Tom Harding2015-06-121-2/+2
| |/ |/| | | | | | | | | | | | | | | | | Chance "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works. Also fixed a comment -- GetGalance has required 1 confirmation for many years, and the default "getbalance *" behavior matches that.
* | Changes necessary now that zero values accepted in AmountFromValueWladimir J. van der Laan2015-06-061-4/+10
|/ | | | | | | | | - Add an accept test for zero amounts, and a reject test for negative amounts - Remove ugly hack in `settxfee` that is no longer necessary - Do explicit zero checks in wallet RPC functions - Don't add a check for zero amounts in `createrawtransaction` - this could be seen as a feature
* Remove JSON Spirit wrapper, remove JSON Spirit leftoversJonas Schnelli2015-06-041-47/+46
| | | | | | - implement find_value() function for UniValue - replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper - remove JSON Spirit sources
* remove JSON Spirit UniValue wrapperJonas Schnelli2015-06-041-5/+5
|
* expicit set UniValue type to avoid empty valuesJonas Schnelli2015-06-041-25/+26
|
* extend conversion to UniValueJonas Schnelli2015-06-041-39/+42
|
* Convert tree to using univalue. Eliminate all json_spirit uses.Jeff Garzik2015-06-041-29/+35
|
* Fix off-by-one error w/ nLockTime in the walletPeter Todd2015-05-271-4/+4
| | | | | | | | | | | | | | | Previously due to an off-by-one error the wallet ignored nLockTime-by-height transactions that would be valid in the next block even though they are accepted into the mempool. The transactions wouldn't show up until confirmed, nor would they be included in the unconfirmed balance. Similar to the mempool behavior fix in 665bdd3b, the wallet code was calling IsFinalTx() directly without taking into account the fact that doing so tells you if the transaction could have been mined in the *current* block, rather than the next block. To fix this we strip IsFinalTx() of non-consensus-critical functionality, removing the default arguments, and add CheckFinalTx() to check if a transaction will be final in the next block.
* wallet: fix boost::get usage with boost 1.58Cory Fields2015-04-281-1/+1
|
* Show zero value txouts in listunspent.Gregory Maxwell2015-04-201-1/+1
| | | | | | | It's reasonable that automatic coin selection will not pick a zero value txout, but they're actually spendable; and you should know if you have them. Listing also makes them available to tools like dust-b-gone.
* [squashme] fix listunspent code indentationJonas Schnelli2015-04-131-53/+53
|
* Push down RPC reqWallet flagJonas Schnelli2015-04-121-0/+114
|
* [move] move listunspent to wallet/rpcwallet.cppJonas Schnelli2015-04-121-0/+112
|
* Regression test for ResendWalletTransactionsGavin Andresen2015-03-241-0/+22
| | | | | | | | | | | | | | | | Adds a regression test for the wallet's ResendWalletTransactions function, which uses a new, hidden RPC command "resendwallettransactions." I refactored main's Broadcast signal so it is passed the best-block time, which let me remove a global variable shared between main.cpp and the wallet (nTimeBestReceived). I also manually tested the "rebroadcast unconfirmed every half hour or so" functionality by: 1. Running bitcoind -connect=0.0.0.0:8333 2. Creating a couple of send-to-self transactions 3. Connect to a peer using -addnode 4. Waited a while, monitoring debug.log, until I see: ```2015-03-23 18:48:10 ResendWalletTransactions: rebroadcast 2 unconfirmed transactions``` One last change: don't bother putting ResendWalletTransactions messages in debug.log unless unconfirmed transactions were actually rebroadcast.
* Includes: Do not include main.h from any other headerJorge Timón2015-03-241-1/+2
|
* Merge pull request #5745Wladimir J. van der Laan2015-03-201-15/+46
| | | | 50c72f2 [Move Only] Move wallet related things to src/wallet/ (Jonas Schnelli)
* [Move Only] Move wallet related things to src/wallet/Jonas Schnelli2015-03-121-0/+2066
could once be renamed from /src/wallet to /src/legacywallet.