| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | refactor: Remove null setting check in GetSetting() | Russell Yanofsky | 2019-11-13 | 1 | -7/+9 |
| | | | | | | | | | | | | | | | Also rename the "result_complete" variable in GetSettingsList() to "done" to be more consistent with GetSetting(). This change doesn't affect current behavior but could be useful in the future to support dynamically changing settings at runtime and adding new settings sources, because it lets high priority sources reset settings back to default (see test). By removing a special case for null, this change also helps merge code treat settings values more like black boxes, and interfere less with settings parsing and retrieval. | ||||
| * | refactor: Clean up long lines in settings code | Russell Yanofsky | 2019-11-13 | 1 | -3/+10 |
| | | | | | | | | Suggested by James O'Beirne <[email protected]> https://github.com/bitcoin/bitcoin/pull/15934#discussion_r344366743 This commit does not change behavior. | ||||
| * | Add util::Settings struct and helper functions. | Russell Yanofsky | 2019-11-07 | 1 | -0/+169 |
| Implement merging of settings from different sources (command line and config file) separately from parsing code in system.cpp, so it is easier to add new sources. Document current inconsistent merging behavior without changing it. This commit only adds new settings code without using it. The next commit calls the new code to replace existing code in system.cpp. Co-authored-by: John Newbery <[email protected]> | |||||