| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
This reverts commits:
- 220de9aafbdb76fa620531fc5c0b01ffa6616d7b Qt: small header changes / fixes
- caeafd1bd1b217276005c6bb422136f379d881cf fix some double-spaces in strings
- deb9f100a04dbb9c25d6ba320eba4c653a2f5423 fix some double-spaces in strings
- 65cee0bbbdea49c08bc84be7824ab004cc19f57e don't use memset() in privacy/security relevant code parts
- ff31f1fa10e2062465520ad8a3ff846c23b7a96f don't use memset() in privacy/security relevant code parts
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/bitcoinrpc.cpp
src/crypter.h
src/main.cpp
src/qt/bitcoin.cpp
src/qt/qtipcserver.cpp
src/util.cpp
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/init.cpp
src/main.cpp
src/serialize.h
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As memset() can be optimized out by a compiler it should not be used in
privacy/security relevant code parts. OpenSSL provides the safe
OPENSSL_cleanse() function in crypto.h, which perfectly does the job of
clean and overwrite data.
For details see: http://www.viva64.com/en/b/0178/
- change memset() to OPENSSL_cleanse() where appropriate
- change a hard-coded number from netbase.cpp into a sizeof()
|
| | |\| |
|
| | | |\
| | | |
| | | |
| | | |
| | | | |
Conflicts:
src/qt/transactiondesc.cpp
|
| | | | |\
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
src/bitcoinrpc.cpp
src/init.cpp
|
| | | | | | |
|
| | |\| | | |
|
| | | |\| |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
doc/unit-tests.txt
|
| | | | |\| |
|
| | | | | | |
|
| | |\| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
src/init.cpp
src/util.cpp
|
| | | |\| | |
|
| | | | |\| |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
(this fixes a Mac OS X gitian build error for 0.5.x)
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
(this fixes a Mac OS X gitian build error for 0.5.x)
|
| | |\| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
contrib/debian/patches/1001_use_system_json-spirit.patch
src/key.h
src/main.cpp
src/main.h
src/net.cpp
|
| | | | | | |
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | | |
git://gitorious.org/+bitcoin-stable-developers/bitcoin/bitcoind-stable into 0.6.3
|
| | | |\| | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
.gitignore
src/bitcoinrpc.cpp
src/main.cpp
src/qt/bitcoingui.cpp
src/ui_interface.h
src/util.cpp
|
| | | | |\| |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/main.h
src/net.cpp
src/serialize.h
|
| | | | | |\|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
doc/release-process.txt
src/serialize.h
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Acquire an exclusive, advisory lock before sending output to debug.log
and release it when we're done. This should avoid output from multiple
threads being interspersed in the log file.
We can't use CRITICAL_SECTION machinery for this because the debug log
is written during startup and shutdown when that machinery is not
available.
(Thanks to Gavin for pointing out the CRITICAL_SECTION problems based
on his earlier work in this area)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I originally created a pull to replace the "COPYING" in crypter.cpp and
crypter.h, but it turned out that COPYING was actually the correct
file.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I originally created a pull to replace the "COPYING" in crypter.cpp and
crypter.h, but it turned out that COPYING was actually the correct
file.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I originally created a pull to replace the "COPYING" in crypter.cpp and
crypter.h, but it turned out that COPYING was actually the correct
file.
|
| | | | |\| |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/main.cpp
src/serialize.h
|
| | | | | |\| |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
value [-Wparentheses]" in util.cpp
|
| | | | | |\|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/main.cpp
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
|
| | | | | | | |
|
| | | | |\| |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/qt/bitcoin.cpp
src/qt/bitcoingui.cpp
src/qt/guiutil.cpp
src/qt/guiutil.h
src/qt/sendcoinsdialog.cpp
src/qt/sendcoinsdialog.h
src/util.cpp
|
| | | | | |\|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/keystore.h
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
clang
|
| | | | | | | |
|
| | | | | |\| |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Upstream commit: 21ae37d (partial)
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Upstream commit: 21ae37d (partial)
|
| | | | | |\|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/bitcoinrpc.cpp
|
| | | | | | | |
|
| | | | | |\|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/util.cpp
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/init.cpp
src/util.cpp
|
| | | | | | | |
|