aboutsummaryrefslogtreecommitdiff
path: root/src/test/validation_block_tests.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Merge #14811: Mining: Enforce that segwit option must be set in GBTMarcoFalke2018-12-211-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d2ce315fbf [docs] add release note for change to GBT (John Newbery) 0025c9eae4 [mining] segwit option must be set in GBT (John Newbery) Pull request description: Calling getblocktemplate without the segwit rule specified is most likely a client error, since it results in lower fees for the miner. Prevent this client error by failing getblocktemplate if called without the segwit rule specified. Of the previous 1000 blocks (measured at block [551591 (hash 0x...173c811)](https://blockstream.info/block/000000000000000000173c811e79858808abc3216af607035973f002bef60a7a)), 991 included segwit transactions. Tree-SHA512: 7933b073d72683c9ab9318db46a085ec19a56a14937945c73f783ac7656887619a86b74db0bdfcb8121df44f63a1d6a6fb19e98505b2a26a6a8a6e768e442fee
| * [mining] segwit option must be set in GBTJohn Newbery2018-12-101-1/+1
| | | | | | | | | | | | | | Calling getblocktemplate without the segwit rule specified is most likely a client error, since it results in lower fees for the miner. Prevent this client error by failing getblocktemplate if called without the segwit rule specified.
* | test: Undo thread_local g_insecure_rand_ctxMarcoFalke2018-12-171-4/+7
| |
* | Merge #14935: tests: Test for expected return values when calling functions ↵MarcoFalke2018-12-141-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | returning a success code c84c2b8c92 tests: Test for expected return values when calling functions returning a success code (practicalswift) Pull request description: Test for expected return values when calling functions returning a success code (instead of discarding the return values). **Note to reviewers:** The following commands can be used to verify that the only text fragments added in this PR are `BOOST_CHECK(`, `!` and `)` : ``` $ git diff HEAD~1 | grep -E '^[\-][^\-]' | cut -b2- > before.txt $ git diff HEAD~1 | grep -E '^[\+][^\+]' | cut -b2- > after.txt $ cat after.txt | sed 's/BOOST_CHECK(//g' | sed 's/));/);/g' | tr -d '!' > after-sed.txt $ diff -u before.txt after-sed.txt $ ``` Tree-SHA512: ff0863ef2046a2eda3c44e9c6b9aedfe167881f2fa58db29fef859416831233ef6502a3a11fd2322bc1a924db83df8d4a5c5879298007f2a7b085e2a7286af70
| * | tests: Test for expected return values when calling functions returning a ↵practicalswift2018-12-131-1/+1
| |/ | | | | | | success code
* / Make unit tests use the insecure_rand_ctx exclusivelyPieter Wuille2018-12-121-3/+3
|/
* Mark single-argument constructors "explicit"practicalswift2018-07-261-1/+1
|
* trivial: Mark overrides as such.Daniel Kraft2018-05-201-3/+3
| | | | | | | | This trivial change adds the "override" keyword to some methods of subclasses meant to override interface methods. This ensures that any future change to the interface' method signatures which are not correctly mirrored in the subclass will break at compile time with a clear error message, rather than fail at runtime (which is harder to debug).
* Add unit tests for signals generated by ProcessNewBlock()Jesse Cohen2018-05-161-0/+184
After a recent bug discovered in callback ordering in MainSignals, this test checks invariants in ordering of BlockConnected / BlockDisconnected / UpdatedChainTip signals