aboutsummaryrefslogtreecommitdiff
path: root/src/rpcrawtransaction.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Clarify that redeemScript is often optionalZak Wilcox2014-08-281-1/+1
| | | | Rebased-From: 6265ecc
* switch from boost int types to <stdint.h>Kamil Domanski2014-07-091-6/+6
| | | | | | Rebased-By: Wladimir J. van der Laan <[email protected]> Rebased-From: 4b61a6a, 3e74ac2, d56e30c Github-Pull: #4129
* typosDavid A. Harding2014-06-291-10/+5
|
* Create (MANDATORY|STANDARD)_SCRIPT_VERIFY_FLAGS constantsPeter Todd2014-06-291-1/+1
|
* Fix a typo in RPC signrawtransaction helpHector Jusforgues2014-05-261-1/+1
|
* 'sendrawtransaction' improvementsWladimir J. van der Laan2014-05-251-16/+14
| | | | | - Make it report the reject code and reason - Make it possible to re-send transactions that are already in the mempool
* Replaced occurrences of "bitcoin" with "dogecoin" or "Dogecoin" as appropriateRoss Nicoll2014-03-281-10/+10
| | | | (specific, use of "Dogecoin" as a noun are now capitalised).
* Replaced references to Bitcoin with Dogecoin/Dogecoin Core as appropriate.Ross Nicoll2014-03-281-2/+2
|
* change currency three-letter-code to DOGEJannis Froese2014-03-241-4/+4
| | | | | | also change length of currency amounts in UI (cherry picked from commit inutoshi/inutoshi@8dcef8791a02327c8061235df7a77e2da6b59ee2)
* Make the signrawtransaction docs explicit that the arguments can be 'null'.Gregory Maxwell2014-02-221-2/+2
|
* Copyright header updates s/2013/2014 on files whose last git commit was done ↵gubatron2014-02-091-1/+1
| | | | | | in 2014. contrib/devtools/fix-copyright-headers.py script to be able to perform this maintenance task with ease during the rest of the year, every year. Modifications to contrib/devtools/README.md to document what fix-copyright-headers.py does.
* small headers ordering cleanupPhilip Kaufmann2014-01-111-4/+4
| | | | | | - keep headers in alphabetical order - fix Makefile.am (2 files in 1 line - leftover) - remove some spaces etc.
* Merge pull request #3332Wladimir J. van der Laan2013-12-081-0/+15
|\ | | | | | | | | | | | | | | | | | | | | 5094f8d Split off rpc_wallet_tests (Wladimir J. van der Laan) 829c920 Move CCryptoKeyStore to crypter.cpp (Wladimir J. van der Laan) ae6ea5a Update build-unix.md to mention --disable-wallet (Wladimir J. van der Laan) 4f9e993 Add --disable-wallet option to build system (Wladimir J. van der Laan) d004d72 Move CAddrDB frrom db to net (Wladimir J. van der Laan) 48ba56c Delimit code with #ifdef ENABLE_WALLET (Wladimir J. van der Laan) 991685d Move getinfo to rpcnet.cpp (Wladimir J. van der Laan) bbb0936 Move HelpExample* from rpcwallet to rpcserver (Wladimir J. van der Laan)
| * Delimit code with #ifdef ENABLE_WALLETWladimir J. van der Laan2013-12-041-0/+15
| | | | | | | | | | Delimit all code that uses the wallet functions in implementation files that conditionally use the wallet.
* | Restore hex to getrawtransaction vout scriptPubkey.Gregory Maxwell2013-12-061-1/+1
|/ | | | | | | | | Commit be066fad accidentally removed the hex field. This gets in the way of doing offline signing. (credit belongs to sipa for actually looking for the cause instead of being lazy like me and just shrugging and writing the scriptpubkey from the asm.)
* Split up bitcoinrpc (code movement only)Wladimir J. van der Laan2013-11-271-3/+1
| | | | | | | | | | | | | | Split bitcoinrpc up into - rpcserver: bitcoind RPC server - rpcclient: bitcoin-cli RPC client - rpcprotocol: shared common HTTP/JSON-RPC protocol code One step towards making bitcoin-cli independent from the rest of the code, and thus a smaller executable that doesn't have to be linked against leveldb. This commit only does code movement, there are no functional changes.
* Issue #1865 - Clean up RPC help messagessje2013-11-131-30/+246
| | | | | | | | | | | | | | | | | | | Based on the proposal, update the help message of rpc methods - strings arguments are in double quotes rather than square brackets - numeric arguments have no quotes (and no default value) - optional parameters are surrounded by round brackets - json arguments are strings but don't use double quotes Added 3 sections for the details - Arguments: lists each argument, it's type, required or not, a default, and a description - Result: The method result, with json format if applicable, type, and a description - Examples: examples calls using bitcoin-cli and curl for json rpc call Problems - maybe this is too verbose - lines might be too long - description are not good or complete - examples may be too much
* Cleanup code using forward declarations.Brandon Dahler2013-11-101-4/+10
| | | | | | | | | Use misc methods of avoiding unnecesary header includes. Replace int typedefs with int##_t from stdint.h. Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h. Normalize QT_VERSION ifs where possible. Resolve some indirect dependencies as direct ones. Remove extern declarations from .cpp files.
* Refactor: CTxMempool class to its own txmempool.{cpp,h}Gavin Andresen2013-11-041-1/+1
|
* Merge pull request #3128Gavin Andresen2013-11-011-1/+1
|\ | | | | | | | | | | | | 0056095 Show short scriptPubKeys correctly (Peter Todd) 22de68d Relay OP_RETURN TxOut as standard transaction type (Peter Todd) Signed-off-by: Gavin Andresen <[email protected]>
| * Relay OP_RETURN TxOut as standard transaction typePeter Todd2013-10-241-1/+1
| | | | | | | | | | | | Also fix decoderawtransaction to not show reqSigs or addresses for nulldata txouts. (Previous version also left reqSigs uninitialized mistakenly)
* | Use boost signals for callbacks from main to walletPieter Wuille2013-10-261-1/+1
|/
* Merge pull request #3119Pieter Wuille2013-10-201-1/+1
|\ | | | | | | db0e8cc Bump Year Number to 2013 (super3)
| * Bump Year Number to 2013super32013-10-201-1/+1
| |
* | Refactor/encapsulate chain globals into a CChain classPieter Wuille2013-10-111-2/+2
|/
* Support absence of wallet (pwalletMain==NULL) in several locations,Jeff Garzik2013-10-011-1/+2
| | | | notably RPC.
* Merge pull request #2949 from gmaxwell/fewer_fee_footgunsGavin Andresen2013-09-221-3/+7
|\ | | | | [raw] reject insanely high fees by default in sendrawtransaction
| * [raw] reject insanely high fees by default in sendrawtransactionGregory Maxwell2013-08-281-3/+7
| | | | | | | | | | | | | | | | | | | | | | There have been several incidents where mainnet experimentation with raw transactions resulted in insane fees. This is hard to prevent in the raw transaction api because the inputs may not be known. Since sending doesn't work if the inputs aren't known, we can catch it there. This rejects fees > than 10000 * nMinRelayTxFee or 1 BTC with the defaults and can be overridden with a bool at the rpc.
* | Add RPC call decodescriptPeter Todd2013-09-121-3/+27
| |
* | Move Parse{Hash|Hex} to be usable by all RPC codePeter Todd2013-09-121-33/+0
|/
* Refactor: CAddressBookData for mapAddressBookGavin Andresen2013-08-221-1/+1
| | | | | | | | Straight refactor, so mapAddressBook stores a CAddressBookData (which just contains a std::string) instead of a std::string. Preparation for payment protocol work, which will add the notion of refund addresses to the address book.
* main.h->core.h include dependency improvements.Jeff Garzik2013-06-241-1/+0
|
* Remove broken option to skip input checking for wallet txn.Matt Corallo2013-06-131-1/+1
|
* Removed AcceptToMemoryPool method from CTransaction. This method belongs to ↵Eric Lombrozo2013-06-051-1/+1
| | | | | | | | | | | | | | | | | the mempool instance. Removed AreInputsStandard from CTransaction, made it a regular function in main. Moved CTransaction::GetOutputFor to CCoinsViewCache. Moved GetLegacySigOpCount and GetP2SHSigOpCount out of CTransaction into regular functions in main. Moved GetValueIn and HaveInputs from CTransaction into CCoinsViewCache. Moved AllowFree, ClientCheckInputs, CheckInputs, UpdateCoins, and CheckTransaction out of CTransaction and into main. Moved IsStandard and IsFinal out of CTransaction and put them in main as IsStandardTx and IsFinalTx. Moved GetValueOut out of CTransaction into main. Moved CTxIn, CTxOut, and CTransaction into core. Added minimum fee parameter to CTxOut::IsDust() temporarily until CTransaction is moved to core.h so that CTxOut needn't know about CTransaction.
* CSecret/CKey -> CKey/CPubKey split/refactorPieter Wuille2013-05-301-4/+1
|
* add address and account information to listunspentmb300sd2013-02-271-0/+7
|
* Signrawtransaction shouldn't require redeemScript for non-p2sh txins.Gregory Maxwell2013-02-011-6/+10
| | | | | | The redeemScript functionality broke plain offline signing, this change makes it only look for that parameter when signing a p2sh input.
* CValidationState frameworkPieter Wuille2013-01-301-2/+3
|
* Merge pull request #2182 from gavinandresen/addressoracleGavin Andresen2013-01-261-1/+1
|\ | | | | Remove IsFromMe() check in CTxMemPool::accept()
| * Remove IsFromMe() check in CTxMemPool::accept()Gavin Andresen2013-01-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes issue #2178 : attacker could penny-flood with invalid-signature transactions to deduce which addresses belonged to your node. I'm committing this early for code review; I still need to write up a test plan. Executive summary of fix: check all transactions received from the network for penny-flood rate-limiting before adding to the memory pool. But do NOT ratelimit transactions added to the memory pool: - because of blockchain reorgs - stored in the wallet and added at startup - sent from the GUI or one of the send* RPC commands (CWallet::CommitTransaction) The limit-free-transactions code really should be a method on CNode, with counters per-peer. But that is a bigger change for another day.
* | Replace RelayMessage with RelayTransaction.Matt Corallo2013-01-161-1/+1
|/
* Introduce script verification flagsPieter Wuille2012-11-151-1/+1
| | | | | | | | These flags select features to be enabled/disabled during script evaluation/checking, instead of several booleans passed along. Currently these flags are defined: * SCRIPT_VERIFY_P2SH: enable BIP16-style subscript evaluation * SCRIPT_VERIFY_STRICTENC: enforce strict adherence to pubkey/sig encoding standards.
* Add redeemScript to listunspent output and signrawtransaction inputGavin Andresen2012-10-291-23/+46
| | | | | | | signrawtransaction was unable to sign pay-to-script-hash inputs when given the list of private keys to use. With this commit you can provide the p2sh redemption script in the list of inputs.
* Tests for raw transactions argument checkingGavin Andresen2012-10-291-28/+44
|
* change blockchain -> block chain (spelling)Philip Kaufmann2012-10-211-1/+1
| | | | | - Wiki says "block chain" is correct ;) - remove some unneeded spaces I found in the source, while fixing the spelling
* Transaction hash cachingPieter Wuille2012-10-201-1/+1
| | | | | | Use CBlock's vMerkleTree to cache transaction hashes, and pass them along as argument in more function calls. During initial block download, this results in every transaction's hash to be only computed once.
* Batch block connection during IBDPieter Wuille2012-10-201-11/+6
| | | | | | | During the initial block download (or -loadblock), delay connection of new blocks a bit, and perform them in a single action. This reduces the load on the database engine, as subsequent blocks often update an earlier block's transaction already.
* UltraprunePieter Wuille2012-10-201-44/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This switches bitcoin's transaction/block verification logic to use a "coin database", which contains all unredeemed transaction output scripts, amounts and heights. The name ultraprune comes from the fact that instead of a full transaction index, we only (need to) keep an index with unspent outputs. For now, the blocks themselves are kept as usual, although they are only necessary for serving, rescanning and reorganizing. The basic datastructures are CCoins (representing the coins of a single transaction), and CCoinsView (representing a state of the coins database). There are several implementations for CCoinsView. A dummy, one backed by the coins database (coins.dat), one backed by the memory pool, and one that adds a cache on top of it. FetchInputs, ConnectInputs, ConnectBlock, DisconnectBlock, ... now operate on a generic CCoinsView. The block switching logic now builds a single cached CCoinsView with changes to be committed to the database before any changes are made. This means no uncommitted changes are ever read from the database, and should ease the transition to another database layer which does not support transactions (but does support atomic writes), like LevelDB. For the getrawtransaction() RPC call, access to a txid-to-disk index would be preferable. As this index is not necessary or even useful for any other part of the implementation, it is not provided. Instead, getrawtransaction() uses the coin database to find the block height, and then scans that block to find the requested transaction. This is slow, but should suffice for debug purposes.
* Merge pull request #1742 from sipa/canonicalJeff Garzik2012-10-201-1/+1
|\ | | | | Check for canonical public keys and signatures
| * Check for canonical public keys and signaturesPieter Wuille2012-09-211-1/+1
| | | | | | | | Only enabled inside tests for now.