aboutsummaryrefslogtreecommitdiff
path: root/src/qt/transactionview.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Fix issue #9683 "gui, wallet: random abort (segmentation fault) running ↵Chris Moore2019-02-041-1/+1
| | | | | | | | | master/HEAD". Patch taken from @ryanofsky's comment https://github.com/bitcoin/bitcoin/issues/9683#issuecomment-448035913 and refined according to https://github.com/bitcoin/bitcoin/pull/15203#discussion_r249168229
* Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)practicalswift2019-01-131-2/+2
| | | | Qt-only changes.
* Set C locale for amountWidgetHennadii Stepanov2018-09-261-1/+5
| | | | Fix #13873
* qt: Use new Qt5 connect syntaxJoão Barbosa2018-08-211-28/+29
|
* Merge #12818: [qt] TransactionView: highlight replacement tx after fee bumpMarcoFalke2018-08-201-1/+12
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d795c610d3 [qt] TransactionView: highlight replacement tx after fee bump (Sjors Provoost) Pull request description: Consistent with #12421 which highlights the transaction after send. <img width="747" alt="1" src="https://user-images.githubusercontent.com/10217/38036280-a7358ea4-32a6-11e8-8f92-417e9e1e3e8b.png"> <img width="685" alt="2" src="https://user-images.githubusercontent.com/10217/38036289-aac87040-32a6-11e8-9f94-81745ff6c592.png"> ~I'm not too proud of the `QTimer::singleShot(10` bit; any suggestions on how to properly wait for the transactions table to become aware of the new transaction?~ Although I could have called `focusTransaction()` directly from `TransactionView::bumpFee()` I'm using the same signal as the send screen. This should make it easier to move fee bump / transaction replacement functionality around later. Tree-SHA512: 242055b7c3d32c7b2cf871f5ceda2581221902fd53fa29e0b092713fc16d3191adbe8cbb28417d522dda9febec8cc05e07afe3489cd7caaecd33460c1dde6fbc
| * [qt] TransactionView: highlight replacement tx after fee bumpSjors Provoost2018-08-011-1/+12
| |
* | Update copyright headers to 2018DrahtBot2018-07-271-1/+1
|/
* gui: Remove QT_VERSION fallbacks for Qt < 5Wladimir J. van der Laan2018-06-181-4/+0
| | | | | | | There were surprisingly many `#ifdef` fallbacks for Qt 4. Remiving them simplifies maintenance, as well as adding new GUI functionality.
* Remove most direct bitcoin calls from qt/walletmodel.cppRussell Yanofsky2018-04-041-5/+5
|
* qt: Remove TransactionTableModel::TxIDRoleJoão Barbosa2018-03-071-2/+2
|
* [qt] navigate to transaction history page after sendSjors Provoost2018-03-011-2/+27
| | | | | The transaction will be selected. When sending to multiple destinations, all will be selected (thanks @promag).
* Merge #10498: Use static_cast instead of C-style casts for non-fundamental typesMarcoFalke2018-02-071-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9ad6746ccd Use static_cast instead of C-style casts for non-fundamental types (practicalswift) Pull request description: A C-style cast is equivalent to try casting in the following order: 1. `const_cast(...)` 2. `static_cast(...)` 3. `const_cast(static_cast(...))` 4. `reinterpret_cast(...)` 5. `const_cast(reinterpret_cast(...))` By using `static_cast<T>(...)` explicitly we avoid the possibility of an unintentional and dangerous `reinterpret_cast`. Furthermore `static_cast<T>(...)` allows for easier grepping of casts. For a more thorough discussion, see ["ES.49: If you must use a cast, use a named cast"](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es49-if-you-must-use-a-cast-use-a-named-cast) in the C++ Core Guidelines (Stroustrup & Sutter). Tree-SHA512: bd6349b7ea157da93a47b8cf238932af5dff84731374ccfd69b9f732fabdad1f9b1cdfca67497040f14eaa85346391404f4c0495e22c467f26ca883cd2de4d3c
| * Use static_cast instead of C-style casts for non-fundamental typespracticalswift2017-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | A C-style cast is equivalent to try casting in the following order: 1. const_cast(...) 2. static_cast(...) 3. const_cast(static_cast(...)) 4. reinterpret_cast(...) 5. const_cast(reinterpret_cast(...)) By using static_cast<T>(...) explicitly we avoid the possibility of an unintentional and dangerous reinterpret_cast. Furthermore static_cast<T>(...) allows for easier grepping of casts.
* | Merge #12074: [qt] Optimizes boolean expression model && model->haveWatchOnly()Jonas Schnelli2018-01-031-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6dda059bd [qt] Simplifies boolean expression model && model->haveWatchOnly() (251) Pull request description: This PR optimizes the boolean expression `model && model->haveWatchOnly()` to `model->haveWatchOnly()`. The boolean expression can be optimized because the method `TransactionView::exportClicked` already guards against a potential dereferenced null pointer by returning early if `model` is null. https://github.com/bitcoin/bitcoin/blob/63a4dc10876bfc61c2e87d35dcf17da2f0f8c316/src/qt/transactionview.cpp#L351-L353 Tree-SHA512: 8bdd0d05bf879745fa39d3ca7524471720ae08ceee9427d5a08776e7b56d18542ae87a6991cd6779e232305f504fdfc77223702b72ecbe231f5f5e98453456dd
| * | [qt] Simplifies boolean expression model && model->haveWatchOnly()2512018-01-021-1/+1
| | | | | | | | | | | | The boolean expression model && model->haveWatchOnly() can be simplified to model->haveWatchOnly(), because if (!model || !model->getOptionsModel()) { return; } guards against a potential dereferenced null pointer.
* | | Increment MIT Licence copyright header year on files modified in 2017Akira Takizawa2018-01-031-1/+1
|/ /
* | Merge #10574: Remove includes in .cpp files for things the corresponding .h ↵Wladimir J. van der Laan2017-12-121-1/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | file already included a720b92 Remove includes in .cpp files for things the corresponding .h file already included (practicalswift) Pull request description: Remove includes in .cpp files for things the corresponding .h file already included. Example case: * `addrdb.cpp` includes `addrdb.h` and `fs.h` * `addrdb.h` includes `fs.h` Then remove the direct inclusion of `fs.h` in `addrman.cpp` and rely on the indirect inclusion of `fs.h` via the included `addrdb.h`. In line with the header include guideline (see #10575). Tree-SHA512: 8704b9de3011a4c234db336a39f7d2c139e741cf0f7aef08a5d3e05197e1e18286b863fdab25ae9638af4ff86b3d52e5cab9eed66bfa2476063aa5c79f9b0346
| * | Remove includes in .cpp files for things the corresponding .h file already ↵practicalswift2017-11-161-1/+0
| | | | | | | | | | | | included
* | | Merge #11395: Qt: Enable searching by transaction idJonas Schnelli2017-11-291-7/+7
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | eac2abca0 Qt: Enable searching by transaction id (Luke Dashjr) c407c61c5 Qt: Avoid invalidating the search filter, when it doesn't really change (Luke Dashjr) b1f634242 Qt: Rename confusingly-named "address prefix" to "search string" (Luke Dashjr) Pull request description: Tree-SHA512: 1c67037d19689fbaff21d15ed7848ac86188e5de34728312e1f9758dada759cab50d913a5bc09e413ecaa3e07557cf253809b95b5637ff79f2e3cf24d86dd3ed
| * | Qt: Enable searching by transaction idLuke Dashjr2017-11-101-1/+1
| | |
| * | Qt: Rename confusingly-named "address prefix" to "search string"Luke Dashjr2017-11-101-7/+7
| | |
* | | scripted-diff: Replace #include "" with #include <> (ryanofsky)MeshCollider2017-11-161-17/+17
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
* / [Qt] Add delay before filtering transactionsLucas Betschart2017-09-181-7/+20
|/ | | | Fixes 3141
* scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal ↵practicalswift2017-08-071-1/+1
| | | | | | | | | | | | | instead of the macro NULL -BEGIN VERIFY SCRIPT- sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp -END VERIFY SCRIPT-
* [qt] Avoid potential null pointer dereference in ↵practicalswift2017-06-271-0/+4
| | | | TransactionView::exportClicked()
* [Qt] hide bump context menu action if tx already has been bumpedJonas Schnelli2017-05-241-1/+1
|
* Add Qt tests for wallet spends & bumpfeeRussell Yanofsky2017-05-231-2/+5
| | | | | | | | | | | | | | | | | | | | | | | A few code changes were needed to accompany the test: * Adding setObjectName() calls for a few Qt controls to make them easily accessible from the test. * Calling contextMenu->popup() instead of contextMenu->exec() to open the transaction list context menu without blocking the test thread. * Opening the context menu at the contextualMenu event point rather than the cursor position (this change was not strictly needed to make the test work, but is more correct). * Updating the bumped transaction row with showTransaction=true instead of false. This is needed to prevent the bumped tx from being hidden, so the last part of the test which attempts to bump the bumped tx can work. (Technically this change is a more general bugfix not limited to the testing environment, but the bug doesn't happen outside of the testing environment because in the full Qt client, a queued NotifyTransactionChanged notification causes the row to be updated twice, first with showTransaction=false, then immediately after with showTransaction=true.)
* Only update the transactionrecord if the fee bump has been commitedJonas Schnelli2017-05-111-4/+4
|
* Make sure we always update the table row after a bumpfee callJonas Schnelli2017-05-111-0/+3
|
* [Qt] simple fee bumper with user verificationJonas Schnelli2017-05-111-1/+21
|
* Increment MIT Licence copyright header year on files modified in 2016isle29832016-12-311-1/+1
| | | | | | Edited via: $ contrib/devtools/copyright_header.py update .
* qt: Plug many memory leaksWladimir J. van der Laan2016-11-231-3/+3
| | | | | | | | | None of these are very serious, and are leaks in objects that are created at most one time. In most cases this means properly using the QObject parent hierarchy, except for BanTablePriv/PeerTablePriv which are not QObject, so use a std::unique_ptr instead.
* Do not shadow in src/qtPavel Janík2016-09-231-8/+8
|
* check that transactionView->selectionModel()->selectedRows(0) existsfsb40002016-06-241-0/+2
|
* Qt: Sort transactions by dateTyler Hardin2016-05-091-1/+1
| | | | Conflicted transactions can get stuck at the top. This fixes that.
* qt: Make it possible to show details for multiple transactionsWladimir J. van der Laan2016-04-251-2/+3
| | | | | | | | | A small GUI annoyance for me has always been that it's impossible to have multiple transaction detail windows open, for example to compare transactions. This patch makes the window non-modal so that it is possible to open transaction details at will.
* [Qt] Support for abandoned/abandoning transactionsJonas Schnelli2016-04-041-2/+31
|
* QT: Add 'copy full transaction details' optionEric Shaw2016-03-071-6/+10
| | | | | | | | Adds feature from issue #7484 modifies the ctrl-c binding to copy full transaction details in transaction view. Added translation
* [Wallet] Transaction View: LastMonth calculation fixedcrowning-2016-01-131-1/+1
|
* Bump copyright headers to 2015MarcoFalke2015-12-131-1/+1
|
* ui: Add "Copy raw transaction data" to transaction list context menuWladimir J. van der Laan2015-11-191-0/+8
| | | | | | | Add a way to quickly copy transaction hex. Primarily useful when manually submitting transactions, e.g. `-walletbroadcast=0` is set.
* qt: Introduce PlatformStyleWladimir J. van der Laan2015-07-311-31/+32
| | | | | | | | | | | | | | Introduce a PlatformStyle to handle platform-specific customization of the UI. This replaces 'scicon', as well as #ifdefs to determine whether to place icons on buttons. The selected PlatformStyle defaults to the platform that the application was compiled on, but can be overridden from the command line with `-uiplatform=<x>`. Also fixes the warning from #6328.
* qt: define QT_NO_KEYWORDSWladimir J. van der Laan2015-07-151-2/+2
| | | | | | | | QT_NO_KEYWORDS prevents Qt from defining the `foreach`, `signals`, `slots` and `emit` macros. Avoid overlap between Qt macros and boost - for example #undef hackiness in #6421.
* Adopt style colour for button iconsLuke Dashjr2014-12-271-2/+3
|
* Added "Core" to copyright headerssandakersmann2014-12-191-1/+1
| | | | | Github-Pull: #5494 Rebased-From: 15de949bb9277e442302bdd8dee299a8d6deee60
* Remove references to X11 licenceMichael Ford2014-12-161-1/+1
|
* Use a typedef for monetary valuesMark Friedenbach2014-09-261-1/+1
|
* [Qt] minor watch-only changesPhilip Kaufmann2014-08-281-1/+1
| | | | | | - use watch-only, not watchonly - add back a tooltip hint when hovering addresses and attach "(watch-only)" at the end
* [Qt] Add column Watch-only to transactions listCozz Lovan2014-08-111-0/+32
|
* Merge remote-tracking branch 'upstream/master'Roy Badami2014-07-071-1/+1
|\ | | | | | | | | | | Conflicts: src/qt/overviewpage.cpp src/qt/transactiondesc.cpp
generated by cgit v1.2.3 (git 2.25.1) at 2026-03-13 20:52:39 +0000