aboutsummaryrefslogtreecommitdiff
path: root/src/qt/coincontroldialog.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Update copyright headers to 2018DrahtBot2018-07-271-1/+1
|
* [qt] coincontrol: Remove unused qt4 workaroundMarcoFalke2018-06-251-4/+0
|
* gui: Remove QT_VERSION fallbacks for Qt < 5Wladimir J. van der Laan2018-06-181-6/+0
| | | | | | | There were surprisingly many `#ifdef` fallbacks for Qt 4. Remiving them simplifies maintenance, as well as adding new GUI functionality.
* wallet: Make fee settings non-static membersMarcoFalke2018-04-231-1/+1
|
* scripted-diff: Avoid `interface` keyword to fix windows gitian buildRussell Yanofsky2018-04-071-2/+2
| | | | | | | | | | | | | | | | | | Rename `interface` to `interfaces` Build failure reported by Chun Kuan Lee <[email protected]> https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-379434756 -BEGIN VERIFY SCRIPT- git mv src/interface src/interfaces ren() { git grep -l "$1" | xargs sed -i "s,$1,$2,g"; } ren interface/ interfaces/ ren interface:: interfaces:: ren BITCOIN_INTERFACE_ BITCOIN_INTERFACES_ ren "namespace interface" "namespace interfaces" -END VERIFY SCRIPT-
* Remove direct bitcoin calls from qt/coincontroldialog.cppRussell Yanofsky2018-04-041-34/+31
|
* Remove most direct bitcoin calls from qt/walletmodel.cppRussell Yanofsky2018-04-041-6/+6
|
* Fix typosDimitris Apostolou2018-03-211-2/+2
|
* Split key_io (address/key encodings) off from base58Pieter Wuille2018-02-191-0/+1
|
* Merge #10498: Use static_cast instead of C-style casts for non-fundamental typesMarcoFalke2018-02-071-3/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9ad6746ccd Use static_cast instead of C-style casts for non-fundamental types (practicalswift) Pull request description: A C-style cast is equivalent to try casting in the following order: 1. `const_cast(...)` 2. `static_cast(...)` 3. `const_cast(static_cast(...))` 4. `reinterpret_cast(...)` 5. `const_cast(reinterpret_cast(...))` By using `static_cast<T>(...)` explicitly we avoid the possibility of an unintentional and dangerous `reinterpret_cast`. Furthermore `static_cast<T>(...)` allows for easier grepping of casts. For a more thorough discussion, see ["ES.49: If you must use a cast, use a named cast"](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es49-if-you-must-use-a-cast-use-a-named-cast) in the C++ Core Guidelines (Stroustrup & Sutter). Tree-SHA512: bd6349b7ea157da93a47b8cf238932af5dff84731374ccfd69b9f732fabdad1f9b1cdfca67497040f14eaa85346391404f4c0495e22c467f26ca883cd2de4d3c
| * Use static_cast instead of C-style casts for non-fundamental typespracticalswift2017-09-221-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | A C-style cast is equivalent to try casting in the following order: 1. const_cast(...) 2. static_cast(...) 3. const_cast(static_cast(...)) 4. reinterpret_cast(...) 5. const_cast(reinterpret_cast(...)) By using static_cast<T>(...) explicitly we avoid the possibility of an unintentional and dangerous reinterpret_cast. Furthermore static_cast<T>(...) allows for easier grepping of casts.
* | [gui] Defer coin control instancingJoão Barbosa2018-02-011-9/+14
| | | | | | | | | | Defer the GUI coin control instancing so that argument processing is taken into account for the default coin control values.
* | Increment MIT Licence copyright header year on files modified in 2017Akira Takizawa2018-01-031-1/+1
| |
* | Remove includes in .cpp files for things the corresponding .h file already ↵practicalswift2017-11-161-2/+0
| | | | | | | | included
* | qt: refactor: Changes to make include paths absoluteWladimir J. van der Laan2017-11-161-1/+1
| | | | | | | | | | | | | | This makes all include paths in the GUI absolute. Many changes are involved as every single source file in src/qt/ assumes to be able to use relative includes.
* | scripted-diff: Replace #include "" with #include <> (ryanofsky)MeshCollider2017-11-161-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
* | Fix crash via division by zero assertionJonas Schnelli2017-10-151-2/+1
| |
* | Merge #11133: Document assumptions that are being made to avoid division by zeroWladimir J. van der Laan2017-10-121-0/+1
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | 55509f1 Document assumptions that are being made to avoid division by zero (practicalswift) Pull request description: Document assumptions (via `assert(…)`:s) that are being made to avoid division by zero. Rationale: * Make it clear to human reviewers and non-human static analyzers that what might look like potential division by zero cases are written the way they are intentionally (these cases are currently flagged by various static analyzers). Tree-SHA512: bbb67b1370afd8f39bda35f9e3a20f4325f017d94cc1bfac3b0d36c9f34c2d95a9efe11efe44db29fb4aadd25d8276d8f0e03c8806ac64f0d21d821912e13b8e
| * Document assumptions that are being made to avoid division by zeropracticalswift2017-08-281-0/+1
| |
* | Introduce wrappers around CBitcoinAddressPieter Wuille2017-09-061-1/+1
| | | | | | | | | | | | | | This patch removes the need for the intermediary Base58 type CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination function that directly operate on the conversion between strings and CTxDestination.
* | Move some static functions out of wallet.h/cppRussell Yanofsky2017-08-141-1/+2
|/ | | | | | | | | | | | | | | This commit just moves a few function declarations and updates callers. Function bodies are moved in two followup MOVEONLY commits. This change is desirable because wallet.h/cpp are monolithic and hard to navigate, so pulling things out and grouping together pieces of related functionality should improve the organization. Another proximate motivation is the wallet process separation work in https://github.com/bitcoin/bitcoin/pull/10973, where (at least initially) parameter parsing and fee estimation are still done in the main process rather than the wallet process, and having functions that run in different processes scrambled up throughout wallet.cpp is unnecessarily confusing.
* Make QT fee displays use GetMinimumFee instead of estimateSmartFeeAlex Morcos2017-07-141-8/+2
| | | | | | Remove helper function (CalculateEstimateType) for determining whether estimates should be conservative or not, now that this is only called once from GetMinimumFee and incorporate the logic directly there.
* Refactor to use CoinControl in GetMinimumFee and FeeBumperAlex Morcos2017-07-141-2/+2
| | | | Improve parameter precedence in coin_control
* Change default fee estimation mode.Alex Morcos2017-07-061-1/+1
| | | | Fee estimates will default to be non-conservative if the transaction in question is opt-in-RBF.
* Introduce a fee estimate mode.Alex Morcos2017-07-061-2/+4
| | | | | | GetMinimumFee now passes the conservative argument into estimateSmartFee. Call CalculateEstimateType(mode) before calling GetMinimumFee or estimateSmartFee to determine the value of this argument. CCoinControl can now be used to control this mode.
* remove default argument from GetMinimumFeeAlex Morcos2017-07-061-1/+1
|
* Merge #10633: doc: Fix various typosWladimir J. van der Laan2017-06-221-1/+1
|\ | | | | | | | | | | 0a5a6b9 Fixed multiple typos (Dimitris Tsapakidis) Tree-SHA512: 57748710bcbc03945b160db5e95bd686a2c64605f25d5e11d8ed9d0e1be3b3bf287a63588dc6eb33d0cef4ff17c765fda7c226d667a357acc539c8fcf2b9bb7e
| * Fixed multiple typosDimitris Tsapakidis2017-06-221-1/+1
| | | | | | | | | | | | | | A few "a->an" and "an->a". "Shows, if the supplied default SOCKS5 proxy" -> "Shows if the supplied default SOCKS5 proxy". Change made on 3 occurrences. "without fully understanding the ramification of a command" -> "without fully understanding the ramifications of a command". Removed duplicate words such as "the the".
* | Merge #9343: Don't create change at dust limitWladimir J. van der Laan2017-06-221-7/+4
|\ \ | |/ |/| | | | | | | 6171826 Don't create change at the dust limit, even if it means paying more than expected (Alex Morcos) Tree-SHA512: d4cf939b97a92d63d4703ad152093c9dc60e74af590697bc21adbcdf17fc9e6ffb37d46d5eefafbd69327d1bcb79911f1b826ce1d960d895d464c4408c4995c3
| * Don't create change at the dust limit, even if it means paying more than ↵Alex Morcos2017-06-141-7/+4
| | | | | | | | expected
* | Merge #10582: Pass in smart fee slider value to coin control dialogWladimir J. van der Laan2017-06-151-2/+2
|\ \ | |/ |/| | | | | | | e9cd778 Pass in smart fee slider value to coin control dialog (Alex Morcos) Tree-SHA512: 3899c3eb89b06e9cc842b33fabcce40a84fcc3a88ac2b02861f63419925312ac2a9f632567c02b0a060f5c5cd55f337e35e99b80535d1c1b8fcb7fd0c539f3c0
| * Pass in smart fee slider value to coin control dialogAlex Morcos2017-06-141-2/+2
| | | | | | | | | | Since cfe77ef41 the global nTxConfirmTarget wasn't being updated by the smart fee slider and thus the coin control dialog and labels were not being updated.
* | Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPEPieter Wuille2017-06-131-4/+4
|\ \ | |/ |/| | | | | | | | | | | | | 1238f13cf scripted-diff: Remove PAIRTYPE (Jorge Timón) 18dc3c396 scripted-diff: Remove Q_FOREACH (Jorge Timón) 7c00c2672 scripted-diff: Fully remove BOOST_FOREACH (Jorge Timón) a5410ac5e Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal (Jorge Timón) Tree-SHA512: d3ab4a173366402e7dcef31608977b757d4aa07abbbad2ee1bcbcfa311e994a4552f24e5a55272cb22c2dcf89a4b0495e02e9d9aceae4b08c0bab668f20e324c
| * scripted-diff: Remove PAIRTYPEJorge Timón2017-06-051-1/+1
| | | | | | | | | | | | | | -BEGIN VERIFY SCRIPT- sed -i 's/PAIRTYPE(\([^,]*\), \([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; sed -i ':a;N;$!ba;s/#define std::pair<t1, t2> std::pair<t1, t2>\n//' ./src/utilstrencodings.h ; -END VERIFY SCRIPT-
| * scripted-diff: Remove Q_FOREACHJorge Timón2017-06-051-1/+1
| | | | | | | | | | | | -BEGIN VERIFY SCRIPT- sed -i 's/Q_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
| * scripted-diff: Fully remove BOOST_FOREACHJorge Timón2017-06-051-3/+3
| | | | | | | | | | | | -BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
* | Use list initialization (C++11) for maps/vectors instead of ↵practicalswift2017-06-061-2/+0
|/ | | | boost::assign::map_list_of/list_of
* remove minimum total fee optionGregory Sanders2017-05-111-3/+1
|
* Consensus: Minimal way to move dust out of consensusJorge Timón2017-05-031-4/+3
|
* Call estimate(Smart)Fee directly from CBlockPolicyEstimatorAlex Morcos2017-04-101-2/+3
|
* wallet: Remove sendfreeMarcoFalke2017-02-271-20/+0
| | | | | | | | This removes the option from the wallet to not pay a fee on "small" transactions which spend "old" inputs. This code is no longer worth keeping around, as almost all miners prefer not to include transactions which pay no fee at all.
* Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0;practicalswift2017-02-071-3/+1
|
* Introduce -dustrelayfeeAlex Morcos2017-01-161-4/+5
|
* Increment MIT Licence copyright header year on files modified in 2016isle29832016-12-311-1/+1
| | | | | | Edited via: $ contrib/devtools/copyright_header.py update .
* Make CWalletTx store a CTransactionRef instead of inheritingPieter Wuille2016-12-021-8/+8
|
* Rename the remaining main.{h,cpp} to validation.{h,cpp}Matt Corallo2016-12-021-1/+1
|
* Merge #9190: qt: Plug many memory leaksWladimir J. van der Laan2016-11-241-1/+1
|\ | | | | | | | | | | | | | | ed998ea qt: Avoid OpenSSL certstore-related memory leak (Wladimir J. van der Laan) 5204598 qt: Avoid shutdownwindow-related memory leak (Wladimir J. van der Laan) e4f126a qt: Avoid splash-screen related memory leak (Wladimir J. van der Laan) 693384e qt: Prevent thread/memory leak on exiting RPCConsole (Wladimir J. van der Laan) 47db075 qt: Plug many memory leaks (Wladimir J. van der Laan)
| * qt: Plug many memory leaksWladimir J. van der Laan2016-11-231-1/+1
| | | | | | | | | | | | | | | | | | None of these are very serious, and are leaks in objects that are created at most one time. In most cases this means properly using the QObject parent hierarchy, except for BanTablePriv/PeerTablePriv which are not QObject, so use a std::unique_ptr instead.
* | [Qt] Clean up and fix coincontrol tree widget handlingWladimir J. van der Laan2016-11-201-24/+10
| | | | | | | | | | | | | | | | | | | | - Do sorting for date, amount and confirmations column as longlong, not unsigned longlong. - Use `UserRole` to store our own data. This makes it treated as ancillary data prevents it from being displayed. - Get rid of `getMappedColumn` `strPad` - these are no longer necessary. - Get rid of hidden `_INT64` columns. - Start enumeration from 0 (otherwise values are undefined).
* | [Qt] fix coincontrol sort issueJonas Schnelli2016-11-181-6/+15
|/