aboutsummaryrefslogtreecommitdiff
path: root/src/qt/askpassphrasedialog.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)practicalswift2019-01-131-1/+1
| | | | Qt-only changes.
* Better error message for user when corrupt wallet unlock failsMeshCollider2018-11-101-8/+9
|
* Merge #12493: [wallet] Reopen CDBEnv after encryption instead of shutting downWladimir J. van der Laan2018-09-141-3/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | c1dde3a949b36ce9c2155777b3fa1372e7ed97d8 No longer shutdown after encrypting the wallet (Andrew Chow) d7637c5a3f1d62922594cdfb6272e30dacf60ce9 After encrypting the wallet, reload the database environment (Andrew Chow) 5d296ac810755dc47f105eb95b52b7e2bcb8aea8 Add function to close all Db's and reload the databae environment (Andrew Chow) a769461d5e37ddcb771ae836254fdc69177a28c4 Move BerkeleyEnvironment deletion from internal method to callsite (Andrew Chow) Pull request description: This is the replacement for #11678 which implements @ryanofsky's [suggestion](https://github.com/bitcoin/bitcoin/pull/11678#pullrequestreview-76464511). Shutting down the software was to prevent the BDB environment from writing unencrypted private keys to disk in the database log files, as was noted [here](https://bitcointalk.org/index.php?topic=51474.msg616068#msg616068). This PR replaces the shutdown behavior with a CDBEnv flush, close, and reopen which achieves the same effect: everything is cleanly flushed and closed, the log files are removed, and then the environment reopened to continue normal operation. To ensure that no unencrypted private keys are in the log files after encrypting the wallet, I wrote [this script](https://gist.github.com/achow101/7f7143e6c3d3fdc034d3470e72823e9d) to pull private keys from the original wallet file and searches for these keys in the log files (note that you will have to change your file paths to make it work on your own machine). As for concerns about private keys being written to slack space or being kept in memory, these behaviors no longer exist after the original wallet encryption PR and the shutting down solution from 2011. cc @ryanofsky Tree-SHA512: 34b894283b0677a873d06dee46dff8424dec85a2973009ac9b84bcf3d22d05f227c494168c395219d9aee3178e420cf70d4b3eeacc9785aa86b6015d25758e75
| * No longer shutdown after encrypting the walletAndrew Chow2018-08-091-3/+2
| | | | | | | | | | Since the database environment is flushed, closed, and reopened during EncryptWallet, there is no need to shut down the software anymore.
* | qt: Use new Qt5 connect syntaxJoão Barbosa2018-08-211-4/+4
|/
* Update copyright headers to 2018DrahtBot2018-07-271-1/+1
|
* Increment MIT Licence copyright header year on files modified in 2017Akira Takizawa2018-01-031-1/+1
|
* qt: refactor: Changes to make include paths absoluteWladimir J. van der Laan2017-11-161-1/+1
| | | | | | | This makes all include paths in the GUI absolute. Many changes are involved as every single source file in src/qt/ assumes to be able to use relative includes.
* scripted-diff: Replace #include "" with #include <> (ryanofsky)MeshCollider2017-11-161-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | -BEGIN VERIFY SCRIPT- for f in \ src/*.cpp \ src/*.h \ src/bench/*.cpp \ src/bench/*.h \ src/compat/*.cpp \ src/compat/*.h \ src/consensus/*.cpp \ src/consensus/*.h \ src/crypto/*.cpp \ src/crypto/*.h \ src/crypto/ctaes/*.h \ src/policy/*.cpp \ src/policy/*.h \ src/primitives/*.cpp \ src/primitives/*.h \ src/qt/*.cpp \ src/qt/*.h \ src/qt/test/*.cpp \ src/qt/test/*.h \ src/rpc/*.cpp \ src/rpc/*.h \ src/script/*.cpp \ src/script/*.h \ src/support/*.cpp \ src/support/*.h \ src/support/allocators/*.h \ src/test/*.cpp \ src/test/*.h \ src/wallet/*.cpp \ src/wallet/*.h \ src/wallet/test/*.cpp \ src/wallet/test/*.h \ src/zmq/*.cpp \ src/zmq/*.h do base=${f%/*}/ relbase=${base#src/} sed -i "s:#include \"\(.*\)\"\(.*\):if test -e \$base'\\1'; then echo \"#include <\"\$relbase\"\\1>\\2\"; else echo \"#include <\\1>\\2\"; fi:e" $f done -END VERIFY SCRIPT-
* [ui] Add toggle for unblinding password fieldsThomas Snider2017-10-181-0/+10
|
* Increment MIT Licence copyright header year on files modified in 2016isle29832016-12-311-1/+1
| | | | | | Edited via: $ contrib/devtools/copyright_header.py update .
* Do not shadow in src/qtPavel Janík2016-09-231-4/+4
|
* qt: askpassphrasedialog: Clear pass fields on acceptPavel Vasin2016-05-191-4/+17
| | | | | This is usability improvement in a case if user gets re-asked passphrase. (e.g. made a typo)
* Merge branch 'master' into single_prodnameLuke Dashjr2016-02-031-1/+1
|\
| * Bump copyright headers to 2015MarcoFalke2015-12-131-1/+1
| |
* | Unify package name to as few places as possible without major changesLuke Dashjr2015-12-141-2/+6
|/
* Bugfix: Grammar fixesCorinne Dashjr2015-05-011-1/+1
|
* allocators: split allocators and pagelockerCory Fields2015-03-201-1/+1
| | | | | Pagelocker is only needed for secure (usually wallet) operations, so don't make the zero-after-free allocator depend on it.
* Added "Core" to copyright headerssandakersmann2014-12-191-1/+1
| | | | | Github-Pull: #5494 Rebased-From: 15de949bb9277e442302bdd8dee299a8d6deee60
* Merge pull request #5470Wladimir J. van der Laan2014-12-191-1/+1
|\ | | | | | | 78253fc Remove references to X11 licence (Michael Ford)
| * Remove references to X11 licenceMichael Ford2014-12-161-1/+1
| |
* | [Qt] change some strings to reflect name change to Bitcoin CorePhilip Kaufmann2014-12-021-1/+1
|/
* qt: Make askpassphrase dialog behave more sanelyWladimir J. van der Laan2014-11-201-2/+5
| | | | | Set minimum sizes appropriately, and make sure that they are enforced. Replaces #5226.
* Consistent letteringWhit J2014-06-241-1/+1
|
* Cleanup code using forward declarations.Brandon Dahler2013-11-101-1/+3
| | | | | | | | | Use misc methods of avoiding unnecesary header includes. Replace int typedefs with int##_t from stdint.h. Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h. Normalize QT_VERSION ifs where possible. Resolve some indirect dependencies as direct ones. Remove extern declarations from .cpp files.
* qt: add license header to source filesWladimir J. van der Laan2013-11-041-0/+4
| | | | Closes #839
* fix some cosmetic glitches in the codebasePhilip Kaufmann2013-09-091-0/+1
| | | | | | | | | | | - rename URL into URI in paymentserver where correct - add some missing Qt-coding-stuff in paymentserver - change QSpinBox to QLineEdit as base for BitcoinAmountField in .ui files (as this is the result when converting the BAF back into base) - remove some c_str() and replace with QString::fromStdString() - remove several new-lines - remove unneeded spaces - indentation fixes
* qt: Improve capslock detection on non-us keyboards (issue #1855)Wladimir J. van der Laan2013-03-291-1/+1
| | | | | On non-us keyboards you can obtain lower case characters even pressing the SHIFT, this caused false positives.
* ensure AskPassphraseDialog::eventFilter forwards eventsPhilip Kaufmann2012-10-251-7/+7
| | | | | | - instead of "return false;" use "return QDialog::eventFilter(object, event);" to harmonize this event filter with our default behaviour - remove orphan spaces found while editting the files
* Merge branch 'master' of github.com:runeksvendsen/bitcoinGavin Andresen2012-10-011-1/+10
|\
| * When encrypting the wallet, warn user that old backups will become useless.Rune K. Svendsen2012-09-301-1/+10
| | | | | | | | | | | | Don't include HTML in translation strings. Do split the huge message over several lines. Prettier lines
* | Merge pull request #1632 from luke-jr/spellingJeff Garzik2012-08-011-1/+1
|\ \ | | | | | | Fix spelling and grammar errors
| * | Bugfix: Fix a variety of misspellingsLuke Dashjr2012-08-011-1/+1
| | |
* | | Update Warning-strings to use a standard-formatPhilip Kaufmann2012-08-011-3/+3
|/ / | | | | | | | | | | | | | | | | - ensure warnings always start with "Warning:" and that the first character after ":" is written uppercase - ensure the first sentence in warnings ends with an "!" - remove unneeded spaces from Warning-strings - add missing Warning-string translation - remove a "\n" and replace with untranslatable "<br><br>"
* / Fix spelling of successfullyStephane Glondu2012-07-241-1/+1
|/
* passphrasedialog: change dialog title to "Passphrase Dialog" / remove ↵Philip Kaufmann2012-05-061-2/+1
| | | | style-sheet for bold font and use Qt Designer option / remove an unused label default-text and remove an obsolete clear()'
* Enable wordwrap for long message in passphrase dialogWladimir J. van der Laan2011-12-131-1/+0
| | | | - Remove explicit resizing from constructor to prevent potential hang
* Merge commit '7298ebb'v0.5.1rc1Gavin Andresen2011-12-121-1/+52
|\
| * Added Caps Lock check and warning at askpassphrasedialog.Nick Bosma2011-10-181-1/+52
| |
* | Implement an mlock()'d string class for storing passphrasesDylan Noblesmith2011-11-261-5/+6
| | | | | | | | | | | | | | SecureString is identical to std::string except with secure_allocator substituting for std::allocator. This makes casting between them impossible, so converting between the two at API boundaries requires calling ::c_str() for now.
* | add message about restarting bitcoin after encrypting wallet succesfullyWladimir J. van der Laan2011-11-151-1/+2
| |
* | Add robustness against null modelsWladimir J. van der Laan2011-11-081-0/+2
|/
* Wallet encryption part 2: ask passphrase when needed, add menu optionsWladimir J. van der Laan2011-08-311-0/+186
generated by cgit v1.2.3 (git 2.25.1) at 2026-04-06 02:05:26 +0000