aboutsummaryrefslogtreecommitdiff
path: root/src/net_processing.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #2417 from patricklodder/1.14-serialize-getheadersPatrick Lodder2021-08-091-6/+37
|\ | | | | Reduce getheaders spam by serializing getheader requests per peer
| * Reduce getheaders spam by serializing getheader requests per peerPatrick Lodder2021-07-221-6/+37
| | | | | | | | | | | | | | | | | | | | | | | | Introduces a counter for getheader requests that have been sent to a peer but are pending response, reducing the number of parallel requests a node pushes out to its peers when needing to sync large amounts of headers. All getheader requests are serialized during initial sync, except when a non-connecting header is received, allowing the node to resolve issues with peers sending faulty blocks using the DoS mechanism, and when we get an inv for a block that we do not know, because it's possible we're only connected to legacy nodes that do not implement header announcement properly.
* | Initial back end framework to separate wallet and relay fees + dust.Michi Lumin2021-07-301-2/+2
|/
* fix: Disconnect stalling peers after timeout of header syncp-j012021-06-141-2/+36
|
* Don't re-check AuxPoW when sending data to peersShibe2021-02-081-6/+6
| | | | | | Checking scrypt PoW is expensive and needless in this case. All block headers are already checked when they are accepted, and they will be checked again on the receiving end.
* Update QT client messages and translations to Doge equivalents (#1429)Ross Nicoll2019-03-251-1/+1
| | | | Update QT client messages and translations to Doge equivalents.
* Re-introduce alert functionality (#1470)Ross Nicoll2018-09-191-7/+58
| | | Re-introduce alert functionality removed from Bitcoin upstream
* Clean up RPC tests (#1465)Ross Nicoll2018-09-191-1/+1
| | | | | | | | | | * Enable full block tests * Fix invalidblocktest * Move watch only address funding to immediately before it's used, so node 0 doesn't spend the output before it checks it later. * Fix `fundrawtransaction` tests and sanitize fee calculation at the same time * Correct resolution of chain parameters when validating tx inputs, especially from previous coinbase transactions * Set block versions on full block tests so that the generated blocks are AuxPoW compatible
* Modify chain consensus parameters to be height aware (#1396)Ross Nicoll2018-09-191-21/+21
| | | | | | | | | * Modify chain consensus parameters to be height aware * Correct implementation of simplified rewards in parameters * Correct max money * Use base block version in IsSuperMajority() instead of full version * Correct mining of blocks in AuxPoW tests * Add in missing pre-AuxPoW consensus checks
* Stop sending a Bitcoin alert to Dogecoin clientsRoss Nicoll2018-09-191-4/+4
|
* Merge AuxPoW support from NamecoreRoss Nicoll2018-09-191-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes are as below: Wrap CBlockHeader::nVersion into a new class (CBlockVersion). This allows to take care of interpreting the field into a base version, auxpow flag and the chain ID. Update getauxblock.py for new 'generate' RPC call. Add 'auxpow' to block JSON. Accept auxpow as PoW verification. Add unit tests for auxpow verification. Add check for memory-layout of CBlockVersion. Weaken auxpow chain ID checks for the testnet. Allow Params() to overrule when to check the auxpow chain ID and for legacy blocks. Use this to disable the checks on testnet. Introduce CPureBlockHeader. Split the block header part that is used by auxpow and the "real" block header (that uses auxpow) to resolve the cyclic dependency between the two. Differentiate between uint256 and arith_uint256. This change was done upstream, modify the auxpow code. Add missing lock in auxpow_tests. Fix REST header check for auxpow headers. Those can be longer, thus take that into account. Also perform the check actually on an auxpow header. Correctly set the coinbase for getauxblock results. Call IncrementExtraNonce in getauxblock so that the coinbase is actually initialised with the stuff it should be. (BIP30 block height and COINBASE_FLAGS.) Implement getauxblock plus regression test. Turn auxpow test into FIXTURE test. This allows using of the Params() calls. Move CMerkleTx code to auxpow.cpp. Otherwise we get linker errors when building without wallet. Fix rebase with BIP66. Update the code to handle BIP66's nVersion=3. Enforce that auxpow parent blocks have no auxpow block version. This is for compatibility with namecoind. See also https://github.com/namecoin/namecoin/pull/199. Move auxpow-related parameters to Consensus::Params.
* Annotate work to be done to Dogecoin-ifyRoss Nicoll2018-09-191-0/+2
|
* Merge #9720: net: fix banning and disallow sending messages before receiving ↵Wladimir J. van der Laan2017-02-141-49/+68
|\ | | | | | | | | | | | | | | | | | | | | verack d943491 qa: add a test to detect leaky p2p messages (Cory Fields) 8650bbb qa: Expose on-connection to mininode listeners (Matt Corallo) 5b5e4f8 qa: mininode learns when a socket connects, not its first action (Matt Corallo) cbfc5a6 net: require a verack before responding to anything else (Cory Fields) 8502e7a net: parse reject earlier (Cory Fields) c45b9fb net: correctly ban before the handshake is complete (Cory Fields)
| * net: require a verack before responding to anything elseCory Fields2017-02-131-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7a8c251901 made this logic hard to follow. After that change, messages would not be sent to a peer via SendMessages() before the handshake was complete, but messages could still be sent as a response to an incoming message. For example, if a peer had not yet sent a verack, we wouldn't notify it about new blocks, but we would respond to a PING with a PONG. This change makes the behavior straightforward: until we've received a verack, never send any message other than version/verack/reject. The behavior until a VERACK is received has always been undefined, this change just tightens our policy. This also makes testing much easier, because we can now connect but not send version/verack, and anything sent to us is an error.
| * net: parse reject earlierCory Fields2017-02-131-26/+24
| | | | | | | | | | | | | | | | | | | | | | Prior to this change, all messages were ignored until a VERSION message was received, as well as possibly incurring a ban score. Since REJECT messages can be sent at any time (including as a response to a bad VERSION message), make sure to always parse them. Moving this parsing up keeps it from being caught in the if (pfrom->nVersion == 0) check below.
| * net: correctly ban before the handshake is completeCory Fields2017-02-131-23/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 7a8c251901 made a change to avoid getting into SendMessages() until the version handshake (VERSION + VERACK) is complete. That was done to avoid leaking out messages to nodes who could connect, but never bothered sending us their version/verack. Unfortunately, the ban tally and possible disconnect are done as part of SendMessages(). So after 7a8c251901, if a peer managed to do something bannable before completing the handshake (say send 100 non-version messages before their version), they wouldn't actually end up getting disconnected/banned. That's fixed here by checking the banscore as part of ProcessMessages() in addition to SendMessages().
* | Move CNode::addrLocal access behind locked accessorsMatt Corallo2017-02-101-2/+2
| |
* | Move CNode::addrName accesses behind locked accessorsMatt Corallo2017-02-101-1/+1
| |
* | Make nTimeBestReceived atomicMatt Corallo2017-02-101-1/+1
| |
* | Move [clean|str]SubVer writes/copyStats into a lockMatt Corallo2017-02-101-3/+8
| |
* | net: fix a few races. Credit @TheBlueMattCory Fields2017-02-101-1/+1
|/ | | | | | | | | | | These are (afaik) all long-standing races or concurrent accesses. Going forward, we can clean these up so that they're not all individual atomic accesses. - Reintroduce cs_vRecv to guard receive-specific vars - Lock vRecv/vSend for CNodeStats - Make some vars atomic. - Only set the connection time in CNode's constructor so that it doesn't change
* Merge #9604: [Trivial] add comment about setting peer as HB peer.Wladimir J. van der Laan2017-02-071-1/+9
|\ | | | | | | dd5b011 [Trivial] add comment about setting peer as HB peer. (John Newbery)
| * [Trivial] add comment about setting peer as HB peer.John Newbery2017-01-201-1/+9
| | | | | | | | | | | | | | This adds a comment to the new logic for setting HB peers based on block validation (and aligns the code below to reflect the comment). It's not obvious why we're checking mapBlocksInFlight. Add a comment to explain.
* | Merge #9659: Net: Turn some methods and params/variables constWladimir J. van der Laan2017-02-061-9/+9
|\ \ | | | | | | | | | | | | | | | 0729102 Net: pass interruptMsgProc as const where possible (Jorge Timón) fc7f2ff Net: Make CNetMsgMaker more const (Jorge Timón) d45955f Net: CConnman: Make some methods const (Jorge Timón)
| * | Net: pass interruptMsgProc as const where possibleJorge Timón2017-01-311-4/+4
| | |
| * | Net: Make CNetMsgMaker more constJorge Timón2017-01-311-5/+5
| | |
* | | net: Disallow sending messages until the version handshake is completeCory Fields2017-02-021-3/+3
| | | | | | | | | | | | This is a change in behavior, though it's much more sane now than before.
* | | net: deserialize the entire version message locallyCory Fields2017-02-021-27/+34
| | | | | | | | | | | | | | | | | | | | | | | | This avoids having some vars set if the version negotiation fails. Also copy it all into CNode at the same site. nVersion and fSuccessfullyConnected are set last, as they are the gates for the other vars. Make them atomic for that reason.
* | | Dont deserialize nVersion into CNode, should fix #9212Matt Corallo2017-02-021-6/+8
|/ /
* | Refactor: Remove using namespace <xxx> from src/*.cpp.Karl-Johan Alm2017-01-271-53/+51
| |
* | Merge #9594: Send final alert message to older peers after connecting.Wladimir J. van der Laan2017-01-261-0/+6
|\ \ | | | | | | | | | 8ff8d21 Send final alert message to older peers after connecting. (Gregory Maxwell)
| * | Send final alert message to older peers after connecting.Gregory Maxwell2017-01-201-0/+6
| |/ | | | | | | | | | | | | | | | | | | | | The old Bitcoin alert system has long since been retired. ( See also: https://bitcoin.org/en/alert/2016-11-01-alert-retirement ) This change causes each node to send any old peers that it connects with a copy of the final alert. The alert it hardcode cancels all other alerts including other final alerts.
* / Do not shadow local variable named `tx`.Pavel Janík2017-01-201-2/+2
|/
* Merge #9499: Use recent-rejects, orphans, and recently-replaced txn for ↵Wladimir J. van der Laan2017-01-191-4/+31
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | compact-block-reconstruction c594580 Add braces around AddToCompactExtraTransactions (Matt Corallo) 1ccfe9b Clarify comment about mempool/extra conflicts (Matt Corallo) fac4c78 Make PartiallyDownloadedBlock::InitData's second param const (Matt Corallo) b55b416 Add extra_count lower bound to compact reconstruction debug print (Matt Corallo) 863edb4 Consider all (<100k memusage) txn for compact-block-extra-txn cache (Matt Corallo) 7f8c8ca Consider all orphan txn for compact-block-extra-txn cache (Matt Corallo) 93380c5 Use replaced transactions in compact block reconstruction (Matt Corallo) 1531652 Keep shared_ptrs to recently-replaced txn for compact blocks (Matt Corallo) edded80 Make ATMP optionally return the CTransactionRefs it replaced (Matt Corallo) c735540 Move ORPHAN constants from validation.h to net_processing.h (Matt Corallo)
| * Add braces around AddToCompactExtraTransactionsMatt Corallo2017-01-161-2/+4
| |
| * Consider all (<100k memusage) txn for compact-block-extra-txn cacheMatt Corallo2017-01-101-1/+4
| |
| * Consider all orphan txn for compact-block-extra-txn cacheMatt Corallo2017-01-101-0/+2
| |
| * Use replaced transactions in compact block reconstructionMatt Corallo2017-01-101-2/+2
| |
| * Keep shared_ptrs to recently-replaced txn for compact blocksMatt Corallo2017-01-101-2/+22
| |
* | Merge #9561: Wake message handling thread when we receive a new blockPieter Wuille2017-01-161-0/+1
|\ \ | | | | | | | | | | | | 241d893 Wake message handling thread when we receive a new block (Matt Corallo) f13914a Make WakeMessageHandler public (Matt Corallo)
| * | Wake message handling thread when we receive a new blockMatt Corallo2017-01-141-0/+1
| | | | | | | | | | | | | | | | | | This forces the message handling thread to make another full iteration of SendMessages prior to going back to sleep, ensuring we announce the new block to all peers before sleeping.
* | | Merge #9400: Set peers as HB peers upon full block validationPieter Wuille2017-01-151-27/+28
|\ \ \ | | | | | | | | | | | | d4781ac Set peers as HB peers upon full block validation (Gregory Sanders)
| * | | Set peers as HB peers upon full block validationGregory Sanders2016-12-301-27/+28
| | | |
* | | | Merge #9486: Make peer=%d log prints consistentWladimir J. van der Laan2017-01-151-3/+3
|\ \ \ \ | |_|/ / |/| | | | | | | e6111b2 Make peer id logging consistent ("peer=%d" instead of "peer %d") (Matt Corallo)
| * | | Make peer id logging consistent ("peer=%d" instead of "peer %d")Matt Corallo2017-01-071-3/+3
| | | |
* | | | Merge #9375: Relay compact block messages prior to full block connectionPieter Wuille2017-01-131-41/+161
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 02ee4eb Make most_recent_compact_block a pointer to a const (Matt Corallo) 73666ad Add comment to describe callers to ActivateBestChain (Matt Corallo) 962f7f0 Call ActivateBestChain without cs_main/with most_recent_block (Matt Corallo) 0df777d Use a temp pindex to avoid a const_cast in ProcessNewBlockHeaders (Matt Corallo) c1ae4fc Avoid holding cs_most_recent_block while calling ReadBlockFromDisk (Matt Corallo) 9eb67f5 Ensure we meet the BIP 152 old-relay-types response requirements (Matt Corallo) 5749a85 Cache most-recently-connected compact block (Matt Corallo) 9eaec08 Cache most-recently-announced block's shared_ptr (Matt Corallo) c802092 Relay compact block messages prior to full block connection (Matt Corallo) 6987219 Add a CValidationInterface::NewPoWValidBlock callback (Matt Corallo) 180586f Call AcceptBlock with the block's shared_ptr instead of CBlock& (Matt Corallo) 8baaba6 [qa] Avoid race in preciousblock test. (Matt Corallo) 9a0b2f4 [qa] Make compact blocks test construction using fetch methods (Matt Corallo) 8017547 Make CBlockIndex*es in net_processing const (Matt Corallo)
| * | | | Make most_recent_compact_block a pointer to a constMatt Corallo2017-01-131-2/+2
| | | | |
| * | | | Call ActivateBestChain without cs_main/with most_recent_blockMatt Corallo2017-01-111-4/+14
| |/ / / | | | | | | | | | | | | | | | | | | | | There is still a call to ActivateBestChain with cs_main if a peer requests the block prior to it being validated, but this one is more specifically-gated, so should be less of an issue.
| * | | Avoid holding cs_most_recent_block while calling ReadBlockFromDiskMatt Corallo2017-01-051-8/+13
| | | |
| * | | Ensure we meet the BIP 152 old-relay-types response requirementsMatt Corallo2017-01-051-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to do this, we must call ActivateBestChain prior to responding getdata requests for blocks which we announced using compact blocks. For getheaders responses we dont need code changes, but do note that we must reset the bestHeaderSent so that the SendMessages call re-announces the header in question. While we could do something smarter for getblocks, calling ActivateBestChain is simple and more obviously correct, instead of doing something more similar to getheaders. See-also the BIP clarifications at https://github.com/bitcoin/bips/pull/486
generated by cgit v1.2.3 (git 2.25.1) at 2026-03-11 19:04:05 +0000