aboutsummaryrefslogtreecommitdiff
path: root/src/net.cpp
Commit message (Collapse)AuthorAgeFilesLines
...
| * net: only disconnect if fDisconnect has been setCory Fields2017-01-041-2/+1
| | | | | | | | | | These conditions are problematic to check without locking, and we shouldn't be relying on the refcount to disconnect.
| * net: make vRecvMsg a list so that we can use splice()Cory Fields2017-01-041-1/+1
| |
| * net: fix typo causing the wrong receive buffer sizeCory Fields2017-01-041-1/+1
| | | | | | | | | | | | | | Surprisingly this hasn't been causing me any issues while testing, probably because it requires lots of large blocks to be flying around. Send/Recv corks need tests!
* | Remove stray semicolon (Fix empty body warning)Douglas Roark2017-01-071-1/+1
| | | | | | | | Empty body introduced by commit #9319 should not be empty.
* | RPC help documentation for addnode peerinfo.Gregory Maxwell2017-01-051-0/+5
| | | | | | | | Also adds a comment about the netgroup exclusion behavior.
* | Break addnode out from the outbound connection limits.Gregory Maxwell2017-01-051-6/+31
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously addnodes were in competition with outbound connections for access to the eight outbound slots. One result of this is that frequently a node with several addnode configured peers would end up connected to none of them, because while the addnode loop was in its two minute sleep the automatic connection logic would fill any free slots with random peers. This is particularly unwelcome to users trying to maintain links to specific nodes for fast block relay or purposes. Another result is that a group of nine or more nodes which are have addnode configured towards each other can become partitioned from the public network. This commit introduces a new limit of eight connections just for addnode peers which is not subject to any of the other connection limitations (including maxconnections). The choice of eight is sufficient so that under no condition would a user find themselves connected to fewer addnoded peers than previously. It is also low enough that users who are confused about the significance of more connections and have gotten too copy-and-paste happy will not consume more than twice the slot usage of a typical user. Any additional load on the network resulting from this will likely be offset by a reduction in users applying even more wasteful workaround for the prior behavior. The retry delays are reduced to avoid nodes sitting around without their added peers up, but are still sufficient to prevent overly aggressive repeated connections. The reduced delays also make the system much more responsive to the addnode RPC. Ban-disconnects are also exempted for peers added via addnode since the outbound addnode logic ignores bans. Previously it would ban an addnode then immediately reconnect to it. A minor change was also made to CSemaphoreGrant so that it is possible to re-acquire via an object whos grant was moved.
* Merge #9289: net: drop boost::thread_groupWladimir J. van der Laan2017-01-041-41/+77
|\ | | | | | | | | | | | | | | | | | | 67ee4ec net: misc header cleanups (Cory Fields) 8b3159e net: make proxy receives interruptible (Cory Fields) 5cb0fce net: remove thread_interrupted catch (Cory Fields) d3d7056 net: make net processing interruptible (Cory Fields) 0985052 net: make net interruptible (Cory Fields) 799df91 net: add CThreadInterrupt and InterruptibleSleep (Cory Fields) 7325b15 net: a few small cleanups before replacing boost threads (Cory Fields)
| * net: misc header cleanupsCory Fields2017-01-031-2/+0
| |
| * net: make proxy receives interruptibleCory Fields2017-01-031-0/+2
| |
| * net: make net processing interruptibleCory Fields2017-01-031-2/+2
| |
| * net: make net interruptibleCory Fields2017-01-031-34/+71
| | | | | | | | | | Also now that net threads are interruptible, switch them to use std threads/binds/mutexes/condvars.
| * net: a few small cleanups before replacing boost threadsCory Fields2017-01-031-4/+3
| | | | | | | | | | | | - Drop the interruption point directly after the pnode allocation. This would be leaky if hit. - Rearrange thread creation so that the socket handler comes first
* | Increment MIT Licence copyright header year on files modified in 2016isle29832016-12-311-1/+1
|/ | | | | | Edited via: $ contrib/devtools/copyright_header.py update .
* Fix non-const mapMultiArgs[] access after init.Matt Corallo2016-12-231-4/+5
| | | | | Swap mapMultiArgs for a const-reference to a _mapMultiArgs which is only accessed in util.cpp
* Merge #9226: Remove fNetworkNode and pnodeLocalHost.Pieter Wuille2016-11-301-19/+1
|\ | | | | | | | | bdb922b Remove pnodeLocalHost. (Gregory Maxwell) 083f203 Remove fNetworkNode. (Gregory Maxwell)
| * Remove pnodeLocalHost.Gregory Maxwell2016-11-271-15/+0
| | | | | | | | Mostly a legacy of the long removed pub/sub system.
| * Remove fNetworkNode.Gregory Maxwell2016-11-271-4/+1
| | | | | | | | Matt pointed out to me that this appeared to be doing nothing (except involving itself in data races).
* | Merge #9225: Fix some benign racesWladimir J. van der Laan2016-11-291-2/+7
|\ \ | |/ |/| | | | | | | | | | | dfed983 Fix unlocked access to vNodes.size() (Matt Corallo) 3033522 Remove double brackets in addrman (Matt Corallo) dbfaade Fix AddrMan locking (Matt Corallo) 047ea10 Make fImporting an std::atomic (Matt Corallo) 42071ca Make fDisconnect an std::atomic (Matt Corallo)
| * Fix unlocked access to vNodes.size()Matt Corallo2016-11-261-2/+7
| |
* | net: push only raw data into CConnmanCory Fields2016-11-251-27/+19
|/ | | | | | | | This fixes one of the last major layer violations in the networking stack. The network side is no longer in charge of message serialization, so it is now decoupled from Bitcoin structures. Only the header is serialized and attached to the payload.
* Merge #8996: Network activity toggleJonas Schnelli2016-11-111-0/+31
|\ | | | | | | | | | | | | | | | | 19f46f1 Qt: New network_disabled icon (Luke Dashjr) 54cf997 RPC/Net: Use boolean consistently for networkactive, and remove from getinfo (Luke Dashjr) b2b33d9 Overhaul network activity toggle (Jonas Schnelli) 32efa79 Qt: Add GUI feedback and control of network activity state. (Jon Lund Steffensen) e38993b RPC: Add "togglenetwork" method to toggle network activity temporarily (Jon Lund Steffensen) 7c9a98a Allow network activity to be temporarily suspended. (Jon Lund Steffensen)
| * Qt: Add GUI feedback and control of network activity state.Jon Lund Steffensen2016-10-241-0/+2
| | | | | | | | | | | | | | Add getNetworkActive()/setNetworkActive() method to client model. Send network active status through NotifyNetworkActiveChanged. Indicate in tool tip of gui status bar network indicator whether network activity is disabled. Indicate in debug window whether network activity is disabled and add button to allow user to toggle network activity state.
| * Allow network activity to be temporarily suspended.Jon Lund Steffensen2016-10-241-0/+29
| | | | | | | | Added the function SetNetworkActive() which when called with argument set to false disconnects all nodes and sets the flag fNetworkActive to false. As long as this flag is false no new connections are attempted and no incoming connections are accepted. Network activity is reenabled by calling the function with argument true.
* | Merge #9045: Hash P2P messages as they are received instead of at process-timePieter Wuille2016-11-071-0/+9
|\ \ | | | | | | | | | fe1dc62 Hash P2P messages as they are received instead of at process-time (Matt Corallo)
| * | Hash P2P messages as they are received instead of at process-timeMatt Corallo2016-10-301-0/+9
| | |
* | | Merge #9052: Use RelevantServices instead of node_network in AttemptToEvict.Wladimir J. van der Laan2016-11-071-3/+4
|\ \ \ | | | | | | | | | | | | d32036a Use RelevantServices instead of node_network in AttemptToEvict. (Gregory Maxwell)
| * | | Use RelevantServices instead of node_network in AttemptToEvict.Gregory Maxwell2016-11-011-3/+4
| |/ / | | | | | | | | | | | | | | | Use of node_network here is really meant to be a proxy of "likely to send us blocks in the future". RelevantServices is the right criteria now.
* | | net: handle version push in InitializeNodeCory Fields2016-11-031-29/+5
| | |
* | | net: remove now-unused ssSend and FuzzCory Fields2016-11-031-37/+1
| | |
* | | drop the optimistic write counter hackCory Fields2016-11-031-5/+0
| | | | | | | | | | | | This is now handled properly in realtime.
* | | net: switch all callers to connman for pushing messagesCory Fields2016-11-031-61/+0
| | | | | | | | | | | | Drop all of the old stuff.
* | | connman is in charge of pushing messagesCory Fields2016-11-031-22/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes here are dense and subtle, but hopefully all is more explicit than before. - CConnman is now in charge of sending data rather than the nodes themselves. This is necessary because many decisions need to be made with all nodes in mind, and a model that requires the nodes calling up to their manager quickly turns to spaghetti. - The per-node-serializer (ssSend) has been replaced with a (quasi-)const send-version. Since the send version for serialization can only change once per connection, we now explicitly tag messages with INIT_PROTO_VERSION if they are sent before the handshake. With this done, there's no need to lock for access to nSendVersion. Also, a new stream is used for each message, so there's no need to lock during the serialization process. - This takes care of accounting for optimistic sends, so the nOptimisticBytesWritten hack can be removed. - -dropmessagestest and -fuzzmessagestest have not been preserved, as I suspect they haven't been used in years.
* | | net: Use deterministic randomness for CNode's nonce, and make it constCory Fields2016-10-311-5/+16
| | |
* | | net: constify a few CNode vars to indicate that they're threadsafeCory Fields2016-10-311-6/+5
|/ /
* | Merge #9008: [net] Remove assert(nMaxInbound > 0)Wladimir J. van der Laan2016-10-251-1/+0
|\ \ | | | | | | | | | fa1c3c2 [net] Remove assert(nMaxInbound > 0) (MarcoFalke)
| * | [net] Remove assert(nMaxInbound > 0)MarcoFalke2016-10-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | nMaxInbound might very well be 0 or -1, if the user prefers to keep a small number of maxconnections. Note: nMaxInbound of -1 means that the user set maxconnections to 8 or less, but we still want to keep an additional slot for the feeler connection.
* | | Make connect=0 disable automatic outbound connections.Gregory Maxwell2016-10-251-2/+3
|/ / | | | | | | | | Otherwise it just responds to this obvious bit of configuration by trying to connect to "0" in a loop.
* | Merge #8949: Be more agressive in getting connections to peers with relevant ↵Wladimir J. van der Laan2016-10-191-3/+10
|\ \ | | | | | | | | | | | | | | | | | | services. 4630479 Make dnsseed's definition of acute need include relevant services. (Gregory Maxwell) 9583477 Be more aggressive in connecting to peers with relevant services. (Gregory Maxwell)
| * | Make dnsseed's definition of acute need include relevant services.Gregory Maxwell2016-10-191-1/+8
| | | | | | | | | | | | | | | | | | | | | We normally prefer to connect to peers offering the relevant services. If we're not connected to enough peers with relevant services, we probably don't know about them and could use dnsseed's help.
| * | Be more aggressive in connecting to peers with relevant services.Gregory Maxwell2016-10-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Only allow skipping relevant services until there are four outbound connections up. This avoids quickly filling up with peers lacking the relevant services when addrman has few or none of them.
* | | Merge #8914: Kill insecure_random and associated global stateWladimir J. van der Laan2016-10-181-1/+2
|\ \ \ | | | | | | | | | | | | 5eaaa83 Kill insecure_random and associated global state (Wladimir J. van der Laan)
| * | | Kill insecure_random and associated global stateWladimir J. van der Laan2016-10-171-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are only a few uses of `insecure_random` outside the tests. This PR replaces uses of insecure_random (and its accompanying global state) in the core code with an FastRandomContext that is automatically seeded on creation. This is meant to be used for inner loops. The FastRandomContext can be in the outer scope, or the class itself, then rand32() is used inside the loop. Useful e.g. for pushing addresses in CNode or the fee rounding, or randomization for coin selection. As a context is created per purpose, thus it gets rid of cross-thread unprotected shared usage of a single set of globals, this should also get rid of the potential race conditions. - I'd say TxMempool::check is not called enough to warrant using a special fast random context, this is switched to GetRand() (open for discussion...) - The use of `insecure_rand` in ConnectThroughProxy has been replaced by an atomic integer counter. The only goal here is to have a different credentials pair for each connection to go on a different Tor circuit, it does not need to be random nor unpredictable. - To avoid having a FastRandomContext on every CNode, the context is passed into PushAddress as appropriate. There remains an insecure_random for test usage in `test_random.h`.
* | | | Merge #8925: qt: Display minimum ping in debug window.Wladimir J. van der Laan2016-10-181-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | 1724a40 Display minimum ping in debug window. (R E Broadley)
| * | | | Display minimum ping in debug window.R E Broadley2016-10-151-1/+1
| |/ / /
* | / / Remove bogus assert on number of oubound connections.Matt Corallo2016-10-171-1/+0
| |/ / |/| | | | | | | | This value can be significantly higher if the users uses addnode
* | | Comment that most dnsseeds only support some service bits combosMatt Corallo2016-10-171-0/+1
|/ /
* | gui: fix ban from qt consoleCory Fields2016-10-041-0/+1
| | | | | | | | | | | | | | Rather than doing a circle and re-resolving the node's IP, just use the one from nodestats directly. This requires syncing the addr field from CNode.
* | net: Consistent checksum handlingWladimir J. van der Laan2016-09-281-4/+2
|/ | | | | | | | | | | | In principle, the checksums of P2P packets are simply 4-byte blobs which are the first four bytes of SHA256(SHA256(payload)). Currently they are handled as little-endian 32-bit integers half of the time, as blobs the other half, sometimes copying the one to the other, resulting in somewhat confused code. This PR changes the handling to be consistent both at packet creation and receiving, making it (I think) easier to understand.
* Merge #8688: Move static global randomizer seeds into CConnmanWladimir J. van der Laan2016-09-191-10/+13
|\ | | | | | | d9ff591 Move static global randomizer seeds into CConnman (Pieter Wuille)
| * Move static global randomizer seeds into CConnmanPieter Wuille2016-09-191-10/+13
| |
generated by cgit v1.2.3 (git 2.25.1) at 2026-03-12 14:40:46 +0000