aboutsummaryrefslogtreecommitdiff
path: root/src/net.cpp
Commit message (Collapse)AuthorAgeFilesLines
...
| * Do not add to vNodes until fOneShot/fFeeler/fAddNode have been setMatt Corallo2017-01-251-9/+10
| |
| * Ensure cs_vNodes is held when using the return value from FindNodeMatt Corallo2017-01-241-5/+4
| |
| * Delete some unused (and broken) functions in CConnmanMatt Corallo2017-01-241-28/+0
| |
* | Merge #9606: net: Consistently use GetTimeMicros() for inactivity checksWladimir J. van der Laan2017-01-261-4/+4
|\ \ | |/ |/| | | 99464bc net: Consistently use GetTimeMicros() for inactivity checks (Suhas Daftuar)
| * net: Consistently use GetTimeMicros() for inactivity checksSuhas Daftuar2017-01-251-4/+4
| | | | | | | | | | | | | | | | | | | | | | The use of mocktime in test logic means that comparisons between GetTime() and GetTimeMicros()/1000000 are unreliable since the former can use mocktime values while the latter always gets the system clock; this changes the networking code's inactivity checks to consistently use the system clock for inactivity comparisons. Also remove some hacks from setmocktime() that are no longer needed, now that we're using the system clock for nLastSend and nLastRecv.
* | Make the cs_sendProcessing a LOCK instead of a TRY_LOCKMatt Corallo2017-01-131-3/+2
| | | | | | | | | | | | Technically cs_sendProcessing is entirely useless now because it is only ever taken on the one MessageHandler thread, but because there may be multiple of those in the future, it is left in place
* | Split CNode::cs_vSend: message processing and message sendingMatt Corallo2017-01-131-13/+9
|/ | | | | | | | | cs_vSend is used for two purposes - to lock the datastructures used to queue messages to place on the wire and to only call SendMessages once at a time per-node. I believe SendMessages used to access some of the vSendMsg stuff, but it doesn't anymore, so these locks do not need to be on the same mutex, and also make deadlocking much more likely.
* Merge #9441: Net: Massive speedup. Net locks overhaulPieter Wuille2017-01-131-58/+57
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e60360e net: remove cs_vRecvMsg (Cory Fields) 991955e net: add a flag to indicate when a node's send buffer is full (Cory Fields) c6e8a9b net: add a flag to indicate when a node's process queue is full (Cory Fields) 4d712e3 net: add a new message queue for the message processor (Cory Fields) c5a8b1b net: rework the way that the messagehandler sleeps (Cory Fields) c72cc88 net: remove useless comments (Cory Fields) ef7b5ec net: Add a simple function for waking the message handler (Cory Fields) f5c36d1 net: record bytes written before notifying the message processor (Cory Fields) 60befa3 net: handle message accounting in ReceiveMsgBytes (Cory Fields) 56212e2 net: set message deserialization version when it's actually time to deserialize (Cory Fields) 0e973d9 net: remove redundant max sendbuffer size check (Cory Fields) 6042587 net: wait until the node is destroyed to delete its recv buffer (Cory Fields) f6315e0 net: only disconnect if fDisconnect has been set (Cory Fields) 5b4a8ac net: make GetReceiveFloodSize public (Cory Fields) e5bcd9c net: make vRecvMsg a list so that we can use splice() (Cory Fields) 53ad9a1 net: fix typo causing the wrong receive buffer size (Cory Fields)
| * net: remove cs_vRecvMsgCory Fields2017-01-121-26/+7
| | | | | | | | | | | | | | | | | | | | | | vRecvMsg is now only touched by the socket handler thread. The accounting vars (nRecvBytes/nLastRecv/mapRecvBytesPerMsgCmd) are also only used by the socket handler thread, with the exception of queries from rpc/gui. These accesses are not threadsafe, but they never were. This needs to be addressed separately. Also, update comment describing data flow
| * net: add a flag to indicate when a node's send buffer is fullCory Fields2017-01-121-3/+8
| | | | | | | | | | | | | | | | Similar to the recv flag, but this one indicates whether or not the net's send buffer is full. The socket handler checks the send queue when a new message is added and pauses if necessary, and possibly unpauses after each message is drained from its buffer.
| * net: add a flag to indicate when a node's process queue is fullCory Fields2017-01-121-3/+7
| | | | | | | | | | | | | | | | | | Messages are dumped very quickly from the socket handler to the processor, so it's the depth of the processing queue that's interesting. The socket handler checks the process queue's size during the brief message hand-off and pauses if necessary, and the processor possibly unpauses each time a message is popped off of its queue.
| * net: add a new message queue for the message processorCory Fields2017-01-121-1/+11
| | | | | | | | | | This separates the storage of messages from the net and queued messages for processing, allowing the locks to be split.
| * net: rework the way that the messagehandler sleepsCory Fields2017-01-121-14/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to sleep accurately, the message handler needs to know if _any_ node has more processing that it should do before the entire thread sleeps. Rather than returning a value that represents whether ProcessMessages encountered a message that should trigger a disconnnect, interpret the return value as whether or not that node has more work to do. Also, use a global fProcessWake value that can be set by other threads, which takes precedence (for one cycle) over the messagehandler's decision. Note that the previous behavior was to only process one message per loop (except in the case of a bad checksum or invalid header). That was changed in PR #3180. The only change here in that regard is that the current node now falls to the back of the processing queue for the bad checksum/invalid header cases.
| * net: Add a simple function for waking the message handlerCory Fields2017-01-121-4/+6
| | | | | | | | This may be used publicly in the future
| * net: record bytes written before notifying the message processorCory Fields2017-01-121-1/+1
| |
| * net: handle message accounting in ReceiveMsgBytesCory Fields2017-01-121-3/+4
| | | | | | | | | | | | This allows locking to be pushed down to only where it's needed Also reuse the current time rather than checking multiple times.
| * net: set message deserialization version when it's actually time to deserializeCory Fields2017-01-041-1/+1
| | | | | | | | We'll soon no longer have access to vRecvMsg, and this is more intuitive anyway.
| * net: wait until the node is destroyed to delete its recv bufferCory Fields2017-01-041-5/+0
| | | | | | | | | | when vRecvMsg becomes a private buffer, it won't make sense to allow other threads to mess with it anymore.
| * net: only disconnect if fDisconnect has been setCory Fields2017-01-041-2/+1
| | | | | | | | | | These conditions are problematic to check without locking, and we shouldn't be relying on the refcount to disconnect.
| * net: make vRecvMsg a list so that we can use splice()Cory Fields2017-01-041-1/+1
| |
| * net: fix typo causing the wrong receive buffer sizeCory Fields2017-01-041-1/+1
| | | | | | | | | | | | | | Surprisingly this hasn't been causing me any issues while testing, probably because it requires lots of large blocks to be flying around. Send/Recv corks need tests!
* | Remove stray semicolon (Fix empty body warning)Douglas Roark2017-01-071-1/+1
| | | | | | | | Empty body introduced by commit #9319 should not be empty.
* | RPC help documentation for addnode peerinfo.Gregory Maxwell2017-01-051-0/+5
| | | | | | | | Also adds a comment about the netgroup exclusion behavior.
* | Break addnode out from the outbound connection limits.Gregory Maxwell2017-01-051-6/+31
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously addnodes were in competition with outbound connections for access to the eight outbound slots. One result of this is that frequently a node with several addnode configured peers would end up connected to none of them, because while the addnode loop was in its two minute sleep the automatic connection logic would fill any free slots with random peers. This is particularly unwelcome to users trying to maintain links to specific nodes for fast block relay or purposes. Another result is that a group of nine or more nodes which are have addnode configured towards each other can become partitioned from the public network. This commit introduces a new limit of eight connections just for addnode peers which is not subject to any of the other connection limitations (including maxconnections). The choice of eight is sufficient so that under no condition would a user find themselves connected to fewer addnoded peers than previously. It is also low enough that users who are confused about the significance of more connections and have gotten too copy-and-paste happy will not consume more than twice the slot usage of a typical user. Any additional load on the network resulting from this will likely be offset by a reduction in users applying even more wasteful workaround for the prior behavior. The retry delays are reduced to avoid nodes sitting around without their added peers up, but are still sufficient to prevent overly aggressive repeated connections. The reduced delays also make the system much more responsive to the addnode RPC. Ban-disconnects are also exempted for peers added via addnode since the outbound addnode logic ignores bans. Previously it would ban an addnode then immediately reconnect to it. A minor change was also made to CSemaphoreGrant so that it is possible to re-acquire via an object whos grant was moved.
* Merge #9289: net: drop boost::thread_groupWladimir J. van der Laan2017-01-041-41/+77
|\ | | | | | | | | | | | | | | | | | | 67ee4ec net: misc header cleanups (Cory Fields) 8b3159e net: make proxy receives interruptible (Cory Fields) 5cb0fce net: remove thread_interrupted catch (Cory Fields) d3d7056 net: make net processing interruptible (Cory Fields) 0985052 net: make net interruptible (Cory Fields) 799df91 net: add CThreadInterrupt and InterruptibleSleep (Cory Fields) 7325b15 net: a few small cleanups before replacing boost threads (Cory Fields)
| * net: misc header cleanupsCory Fields2017-01-031-2/+0
| |
| * net: make proxy receives interruptibleCory Fields2017-01-031-0/+2
| |
| * net: make net processing interruptibleCory Fields2017-01-031-2/+2
| |
| * net: make net interruptibleCory Fields2017-01-031-34/+71
| | | | | | | | | | Also now that net threads are interruptible, switch them to use std threads/binds/mutexes/condvars.
| * net: a few small cleanups before replacing boost threadsCory Fields2017-01-031-4/+3
| | | | | | | | | | | | - Drop the interruption point directly after the pnode allocation. This would be leaky if hit. - Rearrange thread creation so that the socket handler comes first
* | Increment MIT Licence copyright header year on files modified in 2016isle29832016-12-311-1/+1
|/ | | | | | Edited via: $ contrib/devtools/copyright_header.py update .
* Fix non-const mapMultiArgs[] access after init.Matt Corallo2016-12-231-4/+5
| | | | | Swap mapMultiArgs for a const-reference to a _mapMultiArgs which is only accessed in util.cpp
* Merge #9226: Remove fNetworkNode and pnodeLocalHost.Pieter Wuille2016-11-301-19/+1
|\ | | | | | | | | bdb922b Remove pnodeLocalHost. (Gregory Maxwell) 083f203 Remove fNetworkNode. (Gregory Maxwell)
| * Remove pnodeLocalHost.Gregory Maxwell2016-11-271-15/+0
| | | | | | | | Mostly a legacy of the long removed pub/sub system.
| * Remove fNetworkNode.Gregory Maxwell2016-11-271-4/+1
| | | | | | | | Matt pointed out to me that this appeared to be doing nothing (except involving itself in data races).
* | Merge #9225: Fix some benign racesWladimir J. van der Laan2016-11-291-2/+7
|\ \ | |/ |/| | | | | | | | | | | dfed983 Fix unlocked access to vNodes.size() (Matt Corallo) 3033522 Remove double brackets in addrman (Matt Corallo) dbfaade Fix AddrMan locking (Matt Corallo) 047ea10 Make fImporting an std::atomic (Matt Corallo) 42071ca Make fDisconnect an std::atomic (Matt Corallo)
| * Fix unlocked access to vNodes.size()Matt Corallo2016-11-261-2/+7
| |
* | net: push only raw data into CConnmanCory Fields2016-11-251-27/+19
|/ | | | | | | | This fixes one of the last major layer violations in the networking stack. The network side is no longer in charge of message serialization, so it is now decoupled from Bitcoin structures. Only the header is serialized and attached to the payload.
* Merge #8996: Network activity toggleJonas Schnelli2016-11-111-0/+31
|\ | | | | | | | | | | | | | | | | 19f46f1 Qt: New network_disabled icon (Luke Dashjr) 54cf997 RPC/Net: Use boolean consistently for networkactive, and remove from getinfo (Luke Dashjr) b2b33d9 Overhaul network activity toggle (Jonas Schnelli) 32efa79 Qt: Add GUI feedback and control of network activity state. (Jon Lund Steffensen) e38993b RPC: Add "togglenetwork" method to toggle network activity temporarily (Jon Lund Steffensen) 7c9a98a Allow network activity to be temporarily suspended. (Jon Lund Steffensen)
| * Qt: Add GUI feedback and control of network activity state.Jon Lund Steffensen2016-10-241-0/+2
| | | | | | | | | | | | | | Add getNetworkActive()/setNetworkActive() method to client model. Send network active status through NotifyNetworkActiveChanged. Indicate in tool tip of gui status bar network indicator whether network activity is disabled. Indicate in debug window whether network activity is disabled and add button to allow user to toggle network activity state.
| * Allow network activity to be temporarily suspended.Jon Lund Steffensen2016-10-241-0/+29
| | | | | | | | Added the function SetNetworkActive() which when called with argument set to false disconnects all nodes and sets the flag fNetworkActive to false. As long as this flag is false no new connections are attempted and no incoming connections are accepted. Network activity is reenabled by calling the function with argument true.
* | Merge #9045: Hash P2P messages as they are received instead of at process-timePieter Wuille2016-11-071-0/+9
|\ \ | | | | | | | | | fe1dc62 Hash P2P messages as they are received instead of at process-time (Matt Corallo)
| * | Hash P2P messages as they are received instead of at process-timeMatt Corallo2016-10-301-0/+9
| | |
* | | Merge #9052: Use RelevantServices instead of node_network in AttemptToEvict.Wladimir J. van der Laan2016-11-071-3/+4
|\ \ \ | | | | | | | | | | | | d32036a Use RelevantServices instead of node_network in AttemptToEvict. (Gregory Maxwell)
| * | | Use RelevantServices instead of node_network in AttemptToEvict.Gregory Maxwell2016-11-011-3/+4
| |/ / | | | | | | | | | | | | | | | Use of node_network here is really meant to be a proxy of "likely to send us blocks in the future". RelevantServices is the right criteria now.
* | | net: handle version push in InitializeNodeCory Fields2016-11-031-29/+5
| | |
* | | net: remove now-unused ssSend and FuzzCory Fields2016-11-031-37/+1
| | |
* | | drop the optimistic write counter hackCory Fields2016-11-031-5/+0
| | | | | | | | | | | | This is now handled properly in realtime.
* | | net: switch all callers to connman for pushing messagesCory Fields2016-11-031-61/+0
| | | | | | | | | | | | Drop all of the old stuff.
* | | connman is in charge of pushing messagesCory Fields2016-11-031-22/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes here are dense and subtle, but hopefully all is more explicit than before. - CConnman is now in charge of sending data rather than the nodes themselves. This is necessary because many decisions need to be made with all nodes in mind, and a model that requires the nodes calling up to their manager quickly turns to spaghetti. - The per-node-serializer (ssSend) has been replaced with a (quasi-)const send-version. Since the send version for serialization can only change once per connection, we now explicitly tag messages with INIT_PROTO_VERSION if they are sent before the handshake. With this done, there's no need to lock for access to nSendVersion. Also, a new stream is used for each message, so there's no need to lock during the serialization process. - This takes care of accounting for optimistic sends, so the nOptimisticBytesWritten hack can be removed. - -dropmessagestest and -fuzzmessagestest have not been preserved, as I suspect they haven't been used in years.
generated by cgit v1.2.3 (git 2.25.1) at 2026-04-14 15:05:34 +0000