aboutsummaryrefslogtreecommitdiff
path: root/src/main.cpp
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge pull request #2884 from gavinandresen/canonicalsizes2Gavin Andresen2013-10-191-1/+0
|\ \ \ \ | | | | | | | | | | Reject non-canonically-encoded CompactSize
| * | | | Reject non-canonically-encoded sizesGavin Andresen2013-08-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The length of vectors, maps, sets, etc are serialized using Write/ReadCompactSize -- which, unfortunately, do not use a unique encoding. So deserializing and then re-serializing a transaction (for example) can give you different bits than you started with. That doesn't cause any problems that we are aware of, but it is exactly the type of subtle mismatch that can lead to exploits. With this pull, reading a non-canonical CompactSize throws an exception, which means nodes will ignore 'tx' or 'block' or other messages that are not properly encoded. Please check my logic... but this change is safe with respect to causing a network split. Old clients that receive non-canonically-encoded transactions or blocks deserialize them into CTransaction/CBlock structures in memory, and then re-serialize them before relaying them to peers. And please check my logic with respect to causing a blockchain split: there are no CompactSize fields in the block header, so the block hash is always canonical. The merkle root in the block header is computed on a vector<CTransaction>, so any non-canonical encoding of the transactions in 'tx' or 'block' messages is erased as they are read into memory by old clients, and does not affect the block hash. And, as noted above, old clients re-serialize (with canonical encoding) 'tx' and 'block' messages before relaying to peers.
* | | | | Merge pull request #3008 from gavinandresen/CENTruleGavin Andresen2013-10-191-6/+9
|\ \ \ \ \ | | | | | | | | | | | | Two small free transaction policy changes
| * | | | | Lower maximum size for free transaction creationGavin Andresen2013-10-041-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes the maximum size of a free transaction that will be created from 10,000 bytes to 1,000 bytes. The idea behind this change is to make the free transaction area available to a greater number of people; with the default 27K-per-block, just three very-large very-high-priority transactions could fill the space.
| * | | | | Remove CENT-output free transaction rule when relayingGavin Andresen2013-10-041-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the (relay/mempool) rule that all outputs of free transactions must be greater than 0.01 XBT. Dust spam is now taken care of by making dusty outputs non-standard.
* | | | | | Merge pull request #3083 from sipa/chainlocatorGavin Andresen2013-10-151-85/+38
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | CBlockLocator improvements & move to core
| * | | | | Reimplement CBlockLocator's chain-related logic in CChain.Pieter Wuille2013-10-151-85/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes a few unused CBlockLocator methods, and moves the construction and fork-finding logic to CChain (which can do these more efficiently, as it has a height-indexable chain available). It also makes CBlockLocator independent from the validation code.
* | | | | | replace %zu with %"PRIszu" macro to prevent compiler warningsPhilip Kaufmann2013-10-151-9/+9
|/ / / / /
* | | | | Merge pull request #3077 from sipa/chainGavin Andresen2013-10-141-96/+95
|\ \ \ \ \ | | | | | | | | | | | | Refactor/encapsulate chain globals into a CChain class
| * | | | | Refactor/encapsulate chain globals into a CChain classPieter Wuille2013-10-111-96/+95
| | |_|/ / | |/| | |
* | | | | Merge pull request #2937Pieter Wuille2013-10-131-4/+81
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | 971bb3e Added ping time measurement. New RPC "ping" command to request ping. Implemented "pong" message handler. New "pingtime" field in getpeerinfo, to provide results to user. New "pingwait" field, to show pings still in flight, to better see newly lagging peers. (Josh Lehan)
| * | | | Added ping time measurement.Josh Lehan2013-10-041-4/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | New RPC "ping" command to request ping. Implemented "pong" message handler. New "pingtime" field in getpeerinfo, to provide results to user. New "pingwait" field, to show pings still in flight, to better see newly lagging peers.
* | | | | style-police: fixed badly readable code in ProcessMessage()Philip Kaufmann2013-10-071-4/+6
| | | | | | | | | | | | | | | | | | | | - I introduced the problem and fixed it with better readable code
* | | | | special case DoS value == 0 in ProcessMessage()Philip Kaufmann2013-10-041-4/+4
|/ / / / | | | | | | | | | | | | | | | | - prevents unneeded log messages, which could make users think something bad was happening
* | | | Merge pull request #2947 from gmaxwell/theyre_maturing_faster_these_daysGavin Andresen2013-10-031-1/+1
|\ \ \ \ | |_|_|/ |/| | | [wallet] Consider generated coins mature at COINBASE_MATURITY+1
| * | | [wallet] Consider generated coins mature at COINBASE_MATURITY+1Gregory Maxwell2013-08-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We're not seeing large reorgs that would justify waiting a large amount past the rule required maturity, and the extra three hours is just a nuisance. Take one more block to at least give the 100th block time to propagate.
* | | | internal miner: move 2 globals from main to minerPhilip Kaufmann2013-09-251-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | - moves 2 global variables from main.cpp/h to miner.cpp/h - also removes 2 unneded includes in miner.cpp, that come from miner.h already
* | | | Skip unspendable outputs in consistency checkPieter Wuille2013-09-241-0/+1
| | | |
* | | | Merge pull request #2949 from gmaxwell/fewer_fee_footgunsGavin Andresen2013-09-221-1/+6
|\ \ \ \ | | | | | | | | | | [raw] reject insanely high fees by default in sendrawtransaction
| * | | | [raw] reject insanely high fees by default in sendrawtransactionGregory Maxwell2013-08-281-1/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There have been several incidents where mainnet experimentation with raw transactions resulted in insane fees. This is hard to prevent in the raw transaction api because the inputs may not be known. Since sending doesn't work if the inputs aren't known, we can catch it there. This rejects fees > than 10000 * nMinRelayTxFee or 1 BTC with the defaults and can be overridden with a bool at the rpc.
* | / / Replace printf with LogPrintf / LogPrintGavin Andresen2013-09-181-76/+74
| |/ / |/| |
* | | Merge pull request #2982 from gmaxwell/20130908_ccoins_corruptGregory Maxwell2013-09-101-1/+6
|\ \ \ | | | | | | | | Longer term workaround for chainstate corruption from negative versions.
| * | | Longer term workaround for chainstate corruption from negative versions.Gregory Maxwell2013-09-091-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also makes negative transaction versions non-standard. This avoids an issue triggered in block 256818 where transactions with negative version numbers were incorrectly serialized into the UTXO set. On restart nodes detect the inconsistency and refuse to start so long as a block with these transactions is inside the self-consistency check window, logging "coin database inconsistencies found". The software recommends reindexing, but reindexing does not correct the problem. This should be fixed by changing the chainstate serialization, but working around it seems harmless for now because the version is not used by any network rule currently. A patch free workaround is to start with -checklevel=2 which skips the consistency checks, but the IsStandard change is important for miners in order to protect unpatched nodes.
* | | | fix some cosmetic glitches in the codebasePhilip Kaufmann2013-09-091-2/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - rename URL into URI in paymentserver where correct - add some missing Qt-coding-stuff in paymentserver - change QSpinBox to QLineEdit as base for BitcoinAmountField in .ui files (as this is the result when converting the BAF back into base) - remove some c_str() and replace with QString::fromStdString() - remove several new-lines - remove unneeded spaces - indentation fixes
* / / Don't warn about forks while fIsInitialDownloadMatt Corallo2013-09-031-0/+5
|/ /
* | Fix out-of-bounds checkPieter Wuille2013-08-241-1/+2
| |
* | Update the bloom state on the real object, not the temporary one.Gregory Maxwell2013-08-201-1/+1
| | | | | | | | | | This resulted in just passing all transactions to filtered wallets which worked surprisingly well, except where it didn't.
* | Performance optimization for bloom filters.Gregory Maxwell2013-08-201-1/+2
| | | | | | | | | | | | | | | | This reduces a peer's ability to attack network resources by using a full bloom filter, but without reducing the usability of bloom filters. It sets a default match everything filter for peers and it generalizes a prior optimization to cover more cases.
* | Mempool consistency checkPieter Wuille2013-08-151-0/+45
| |
* | Fix non-standard disconnected transactions causing mempool orphansPieter Wuille2013-08-151-8/+9
| |
* | Merge pull request #2658 from TheBlueMatt/forkalertGavin Andresen2013-08-121-6/+88
|\ \ | | | | | | Detect any sufficiently long fork and alert the user just like any other alert
| * | Better warning/"alert" messages for large-work forks.Matt Corallo2013-07-221-5/+26
| | |
| * | Call the -alertnotify script when we see a long or invalid fork.Matt Corallo2013-07-221-0/+10
| | |
| * | Detect any sufficiently long fork and add a warning.Matt Corallo2013-07-221-5/+56
| | | | | | | | | | | | | | | Such a fork is defined as being at least 7 blocks long and having a tip which is within 72 blocks of our best block.
* | | do not call BuildMerkleTree() unnecessarily twiceCozz Lovan2013-08-101-1/+1
| |/ |/|
* | Merge pull request #2871 from gavinandresen/simplify_maporphanGavin Andresen2013-08-061-48/+28
|\ \ | | | | | | Simplify storage of orphan transactions, fix CVE-2013-4627
| * | Simplify storage of orphan transactionsGavin Andresen2013-08-021-38/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | Orphan transactions were stored as a CDataStream pointer; this changes the mapOrphanTransactions data structures to store orphans as a CTransaction. This also fixes CVE-2013-4627 by always re-serializing transactions before relaying them.
| * | Revert "Truncate oversize 'tx' messages before relaying/storing."Gavin Andresen2013-08-021-10/+0
| | | | | | | | | | | | This reverts commit c40a5aaaf484855a4350fd702e8e72fd21a68155.
* | | Merge pull request #2851 from TheBlueMatt/masterGavin Andresen2013-08-051-6/+6
|\ \ \ | |/ / |/| | Prepare for mempool testing in pull-tester and fix multi-block transaction resurrection
| * | Fix multi-block reorg transaction resurrectionMatt Corallo2013-07-231-3/+3
| | |
| * | Don't use checkpoints and accept nonstd txn on -regtestMatt Corallo2013-07-231-3/+3
| |/
* | Move internal miner/block creation to separate miner.cpp module.Jeff Garzik2013-07-311-658/+2
| | | | | | | | Public functions referenced elsewhere are added to miner.h.
* | Minor miner fixes (hey hey it's fun to say)Jeff Garzik2013-07-311-1/+1
| | | | | | | | | | | | * Fix UpdateCoins() definition in main.h * Remove pwalletMain reference from BitcoinMiner(), as it is passed a wallet argument.
* | Remove #define loop from util.hGavin Andresen2013-07-311-2/+2
|/ | | | | Replace the loop macro with while (true). The #define caused problems for Qt.
* Merge pull request #2743 from jgarzik/reject-reasonJeff Garzik2013-07-101-10/+27
|\ | | | | Log reason for non-standard transaction rejection
| * Log reason for non-standard transaction rejectionJeff Garzik2013-06-231-10/+27
| |
* | Merge pull request #2209 from CodeShark/WalletRegistrationLocksPieter Wuille2013-06-251-0/+14
|\ \ | | | | | | Wallet registration locks in main.cpp + UnregisterAllWallet() function
| * | Added locks on the setpwalletRegistered functions in main.cpp and added an ↵Eric Lombrozo2013-06-241-0/+14
| | | | | | | | | | | | UnregisterAllWallets function.
* | | Merge pull request #2792 from sipa/coreimplJeff Garzik2013-06-251-53/+0
|\ \ \ | | | | | | | | Move core implementations to core.cpp
| * | | Move core implementations to core.cppPieter Wuille2013-06-251-53/+0
| |/ /
generated by cgit v1.2.3 (git 2.25.1) at 2026-03-17 13:52:18 +0000