| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | | |
|
| | |\ \
| | | |
| | | | |
Denial-of-service prevention
|
| | | | | |
|
| | | |/ |
|
| | |\ \
| | |/
| |/| |
Qt GUI
|
| | | |
| | |
| | |
| | |
| | |
| | | |
- fixes problem that one misconfigured or malicious node can mess up progress bar
- implementation in src/util.h
- testcase in src/test/util_tests.cpp
|
| |\| |
| |/
|/| |
|
| | | |
|
| |\| |
|
| | |\
| | |
| | |
| | | |
git://gitorious.org/~Luke-Jr/bitcoin/luke-jr-bitcoin into unique_coinbase
|
| | | |
| | |
| | |
| | | |
coinbase txn is unique even if address is the same
|
| | | | |
|
| | | |
| | |
| | |
| | | |
blocks as initial value for number of peer blocks
|
| |\| |
| | |
| | |
| | |
| | | |
Conflicts:
.gitignore
|
| | | |
| | |
| | |
| | | |
Patch from ArtForz, who discovered the problem.
|
| |\| | |
|
| | | |
| | |
| | |
| | | |
them
|
| | | | |
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | | |
Conflicts:
src/main.cpp
|
| | |\ \
| | | |
| | | | |
Logic running with -keypool=0 was wrong (empty keys were being returned).
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes #445
Renames GetOrReuseKeyFromKeyPool to GetKeyFromPool, with fAllowReuse arg and bool result.
|
| | |\ \ \
| | |/ /
| |/| | |
|
| | | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Explicitly make these global variables less-global to reduce the maximum
scope of this global state.
In my experience global variables tend to be a major source of bugs. As
such the less accessible they are the less likely they are to be the
source of a bug.
Signed-off-by: Giel van Schijndel <[email protected]>
|
| | |\ \
| | | |
| | | | |
Checkpoints
|
| | | | |
| | | |
| | | |
| | | | |
and maximum minimum tx should be 0.0010.
|
| | | |/
| |/|
| | |
| | |
| | | |
Collapsed multiple wallet mutexes to a single cs_wallet, to avoid deadlocks with wallet methods that acquired locks in different order.
Also change master RPC call handler to acquire cs_main and cs_wallet locks before executing RPC calls; requiring each RPC call to acquire the right set of locks in the right order was too error-prone.
|
| |\| | |
|
| | |/ |
|
| |\| |
|
| | |\
| | |
| | | |
Unify copyright notices.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
To a variation on:
// Copyright (c) 2009-2010 Satoshi Nakamoto
// Copyright (c) 2011 The Bitcoin developers
|
| |\| | |
|
| | |\ \
| | | |
| | | | |
Use 'unsigned char' rather than 'char' for pchMessageStart.
|
| | | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Regarding https://bitcointalk.org/index.php?topic=28022.0
main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
Per discussion on the thread linked, leaving the signedness of
pchMessageStart is unsafe for values > 0x80. This patch specifies
'unsigned char' in main.cpp and net.h.
Signed-off-by: Jeff Garzik <[email protected]>
|
| | |/ |
|
| |\|
| |
| |
| |
| | |
Conflicts:
src/bitcoinrpc.cpp
|
| | |\
| | |
| | | |
keys indexed by address + introduced CBitcoinaddress
|
| | | |
| | |
| | |
| | |
| | | |
Make CKeyStore's interface work on uint160's instead of pubkeys, so
no separate global mapPubKeys is necessary anymore.
|
| |\| | |
|
| | |/
| |
| |
| |
| |
| |
| |
| | |
Previously, mapAlreadyAskedFor was read from, but never added to.
The original intent was to use mapAlreadyAskedFor to keep track
of the time an item was requested and "Each retry is 2 minutes
after the last".
This implements that intent.
|
| |/
|
|
| |
responses
|
| |
|
|
| |
Cuts disk activity at startup immensely
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the assert()s take advantage of the fact that string constants
("string") are effectively of type 'const char []', which when used in
an expression yield a non-NULL pointer.
An assertion that should always fail can thus be formulated as:
assert(!"fail);
An assertion where a text message should be added to the expression can
be written as such:
assert("message" && expression);
Signed-off-by: Giel van Schijndel <[email protected]>
|
| |
|
|
|
| |
This prevents old clients from opening, and thus corrupting
or otherwise causing harm to encrypted wallets.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds support for ckeys, or enCrypted private keys, to the wallet.
All keys are stored in memory in their encrypted form and thus the passphrase
is required from the user to spend coins, or to create new addresses.
Keys are encrypted with AES-256-CBC using OpenSSL's EVP library. The key is
calculated via EVP_BytesToKey using SHA512 with (by default) 25000 rounds and
a random salt.
By default, the user's wallet remains unencrypted until they call the RPC
command encryptwallet <passphrase> or, from the GUI menu, Options->
Encrypt Wallet.
When the user is attempting to call RPC functions which require the password
to unlock the wallet, an error will be returned unless they call
walletpassphrase <passphrase> <time to keep key in memory> first.
A keypoolrefill command has been added which tops up the users keypool
(requiring the passphrase via walletpassphrase first).
keypoolsize has been added to the output of getinfo to show the user the
number of keys left before they need to specify their passphrase (and call
keypoolrefill).
Note that walletpassphrase will automatically fill keypool in a separate
thread which it spawns when the passphrase is set. This could cause some
delays in other threads waiting for locks on the wallet passphrase, including
one which could cause the passphrase to be stored longer than expected,
however it will not allow the passphrase to be used longer than expected as
ThreadCleanWalletPassphrase will attempt to get a lock on the key as soon
as the specified lock time has arrived.
When the keypool runs out (and wallet is locked) GetOrReuseKeyFromPool
returns vchDefaultKey, meaning miners may start to generate many blocks to
vchDefaultKey instead of a new key each time.
A walletpassphrasechange <oldpassphrase> <newpassphrase> has been added to
allow the user to change their password via RPC.
Whenever keying material (unencrypted private keys, the user's passphrase,
the wallet's AES key) is stored unencrypted in memory, any reasonable attempt
is made to mlock/VirtualLock that memory before storing the keying material.
This is not true in several (commented) cases where mlock/VirtualLocking the
memory is not possible.
Although encryption of private keys in memory can be very useful on desktop
systems (as some small amount of protection against stupid viruses), on an
RPC server, the password is entered fairly insecurely. Thus, the only main
advantage encryption has for RPC servers is for RPC servers that do not spend
coins, except in rare cases, eg. a webserver of a merchant which only receives
payment except for cases of manual intervention.
Thanks to jgarzik for the original patch and sipa, gmaxwell and many others
for all their input.
Conflicts:
src/wallet.cpp
|
| | |
|
| |
|
|
|
|
| |
Introduce SendBufferSize() and ReceiveBufferSize(), and limit
the blocks sent as response to the "getblocks" message to
half of the active send buffer size.
|
| |\ |
|
| | | |
|