aboutsummaryrefslogtreecommitdiff
path: root/src/logging.cpp
Commit message (Collapse)AuthorAgeFilesLines
* log: Use Join() helper when listing log categoriesMarcoFalke2020-04-161-19/+4
|
* scripted-diff: Bump copyright of files changed in 2020MarcoFalke2020-01-151-1/+1
| | | | | | -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-
* Merge #16688: log: Add validation interface loggingWladimir J. van der Laan2020-01-091-0/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f Add logging for CValidationInterface events (Jeffrey Czyz) 6edebacb2191373e76d79a4972d6192300976096 Refactor FormatStateMessage for clarity (Jeffrey Czyz) 72f3227c83810936e7a334304e5fd7c6dab8e91b Format CValidationState properly in all cases (Jeffrey Czyz) 428ac70095253225f64462ee15c595644747f376 Add VALIDATION to BCLog::LogFlags (Jeffrey Czyz) Pull request description: Add logging of `CValidationInterface` callbacks using a new `VALIDATIONINTERFACE` log flag (see #12994). A separate flag is desirable as the logging can be noisy and thus may need to be disabled without affecting other logging. This could help debug issues where there may be race conditions at play, such as #12978. ACKs for top commit: jnewbery: ACK f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f hebasto: ACK f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f ariard: ACK f9abf4a, only changes since 0cadb12 are replacing log indication `VALIDATIONINTERFACE` by `VALIDATION` and avoiding a forward declaration with a new include ryanofsky: Code review ACK f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f. Just suggested changes since last review (thanks!) Tree-SHA512: 3e0f6e2c8951cf46fbad3ff440971d95d526df2a52a2e4d6452a82785c63d53accfdabae66b0b30e2fe0b00737f8d5cb717edbad1460b63acb11a72c8f5d4236
| * Add VALIDATION to BCLog::LogFlagsJeffrey Czyz2020-01-031-0/+1
| | | | | | | | | | | | This flag is for logging from within CValidationInterface (see #12994). A separate flag is desirable as the logging can be noisy and thus may need to be disabled without affecting other logging.
* | scripted-diff: Bump copyright of files changed in 2019MarcoFalke2019-12-301-1/+1
|/ | | | | | -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-
* scripted-diff: Change `BCLog::DB` to `BCLog::WALLETDB`Wladimir J. van der Laan2019-11-081-2/+2
| | | | | | | -BEGIN VERIFY SCRIPT- git grep -l "BCLog::DB" src | xargs sed -i "s/BCLog::DB/BCLog::WALLETDB/g" sed -i "s/DB =/WALLETDB =/g" src/logging.h -END VERIFY SCRIPT-
* Rename `db` log category to `walletdb` (like `coindb`)Wladimir J. van der Laan2019-11-081-2/+10
| | | | Deprecate (but still accept) '-debug=db'.
* logging: Add member for arbitrary print callbacksMarcoFalke2019-11-041-0/+7
|
* util: Filter control characters out of log messagesWladimir J. van der Laan2019-10-151-1/+23
| | | | | | | | | Belts and suspenders: make sure outgoing log messages don't contain potentially suspicious characters, such as terminal control codes. This escapes control characters except newline ('\n') in C syntax. It escapes instead of removes them to still allow for troubleshooting issues where they accidentally end up in strings.
* test: Log to debug.log in all testsMarcoFalke2019-06-201-0/+8
|
* logging: Add threadsafety commentsMarcoFalke2019-05-281-3/+3
|
* Log early messages with -printtoconsoleAnthony Towns2019-05-281-25/+38
| | | | | This ensures log messages prior to StartLogging() are replayed to the console as well as to the debug log file.
* Replace OpenDebugLog() with StartLogging()Anthony Towns2019-05-281-1/+2
| | | | | StartLogging() is used to mark the start of logging generically, whether using -printtoconsole or -debuglogfile.
* threads: prefix log messages with thread namesJames O'Beirne2019-04-291-10/+16
| | | | | Introduce a new flag (`-logthreadnames`) which allows toggling of this behavior.
* log: Construct global logger on first useMarcoFalke2019-01-291-1/+7
|
* scripted-diff: Move util files to separate directory.Jim Posen2018-11-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
* Don't close old debug log file handle prematurely when trying to re-open (on ↵practicalswift2018-08-291-5/+5
| | | | SIGHUP)
* refactor: use fs:: over boost::filesystem::fanquake2018-08-151-1/+1
|
* Merge #13149: Handle unsuccessful fseek(...):sWladimir J. van der Laan2018-05-071-1/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | 20ce5af Print a log message if we fail to shrink the debug log file (practicalswift) 29c9bdc Handle unsuccessful fseek(...):s (practicalswift) Pull request description: Handle unsuccessful `fseek(...)`:s. **Note to reviewers:** What is the most appropriate course of actions for each of these unsuccessful `fseek(...)`:s? Tree-SHA512: 5b3d82dbdd15d434d3f08dcb4df62888da4df8541d2586f56a4e529083005f6782c39e10645acd1ec403da83061bbfd8dbf2dddc66e09268d410ad0918c61876
| * Print a log message if we fail to shrink the debug log filepracticalswift2018-05-031-0/+1
| |
| * Handle unsuccessful fseek(...):spracticalswift2018-05-021-1/+4
| |
* | logging: remove unused return value from LogPrintStrpracticalswift2018-05-021-8/+4
| | | | | | | | | | | | | | | | | | `LogPrintStr` returns the number of characters printed. This number is doubled if both logging to console and logging to file is enabled. As the return value is never used, I've opted to remove it instead of try to fix it. Credit: @laanwj
* | logging: Fix potential use-after-free in LogPrintStr(...)practicalswift2018-05-021-2/+5
|/
* util: Store debug log file path in BCLog::Logger member.Jim Posen2018-04-291-15/+10
| | | | This breaks the cyclic between logging and util.
* scripted-diff: Rename BCLog::Logger member variables.Jim Posen2018-04-291-27/+27
| | | | | | | | | | | | | | | -BEGIN VERIFY SCRIPT- sed -i "s/fileout/m_fileout/" src/logging.h src/logging.cpp sed -i "s/mutexDebugLog/m_file_mutex/" src/logging.h src/logging.cpp sed -i "s/vMsgsBeforeOpenLog/m_msgs_before_open/" src/logging.h src/logging.cpp sed -i "s/logCategories/m_categories/" src/logging.h src/logging.cpp sed -i "s/fPrintToConsole/m_print_to_console/" src/logging.h src/logging.cpp src/init.cpp sed -i "s/fPrintToDebugLog/m_print_to_file/" src/logging.h src/logging.cpp src/init.cpp src/test/test_bitcoin.cpp src/bench/bench_bitcoin.cpp sed -i "s/fLogTimestamps/m_log_timestamps/" src/logging.h src/logging.cpp src/init.cpp sed -i "s/fLogTimeMicros/m_log_time_micros/" src/logging.h src/logging.cpp src/init.cpp sed -i "s/fReopenDebugLog/m_reopen_file/" src/logging.h src/logging.cpp src/init.cpp sed -i "s/fStartedNewLine/m_started_new_line/" src/logging.h src/logging.cpp -END VERIFY SCRIPT-
* util: Refactor GetLogCategory.Jim Posen2018-04-291-19/+32
| | | | | Changing parameter types from pointers to references and uint32_t to BCLog::LogFlags simplies calling code.
* util: Encapsulate logCategories within BCLog::Logger.Jim Posen2018-04-271-3/+20
|
* util: Move debug file management functions into Logger.Jim Posen2018-04-271-50/+9
|
* util: Establish global logger object.Jim Posen2018-04-271-17/+20
| | | | | The object encapsulates logging configuration, and in a later commit, set up routines will also be moved into the class.
* MOVEONLY: Move logging code from util.{h,cpp} to new files.Jim Posen2018-04-181-0/+283